Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YeastPathways import: "source: null:*pathway-name" instead of "source: SGD:*pathway-name*" #242

Closed
suzialeksander opened this issue Apr 14, 2023 · 4 comments

Comments

@suzialeksander
Copy link

Spotchecking these YeastPathways models, and for Evidencethe source field for the CC term "occurs in (cytosol)" has a null: prefix before whatever pathway name:
Screenshot 2023-04-12 at 23 06 48

Same for other models, like http://noctua-dev.berkeleybop.org/editor/graph/gomodel:PWY3O-123? - the green evidence box on the cytosol term has the null: prefix. In the same model, the Evidence fields for the rest of the bits are fine, and show source: SGD:SERSYN-PWY or whatever the pathway is.

@dustine32

@suzialeksander
Copy link
Author

Screenshot 2023-04-12 at 23 18 41

@dustine32
Copy link
Collaborator

The source field issue should be handled once #126 is solved.

@dustine32
Copy link
Collaborator

Oh, I see now there's a conditional that sets source prefix depending on providedBy value and the case for SGD didn't match what we were currently supplying:
image

}else if(base_provider.equals("https://yeastcyc.org")) {

AFAIK this discrepancy was only occuring for rule-inferred edges. I'll fix it by changing the conditional value to https://yeastgenome.org.

@suzialeksander
Copy link
Author

Fixed!
Screenshot 2023-05-12 at 11 18 28

@suzialeksander suzialeksander moved this from In progress to Done in DONE YeastPathways May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants