Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null source prefix for #242 #250

Merged
merged 2 commits into from
May 9, 2023
Merged

Fix null source prefix for #242 #250

merged 2 commits into from
May 9, 2023

Conversation

dustine32
Copy link
Collaborator

For #242.

This is a quick fix to just match the SGD providedBy value that we're using and it is consistent with groups.yaml.

@dustine32 dustine32 requested a review from kltm May 9, 2023 17:32
@kltm
Copy link
Member

kltm commented May 9, 2023

@dustine32 @suzialeksander Noting that in groups.yaml we have: http://www.yeastgenome.org
I'm assuming that these are all supposed to be aligned?

@kltm
Copy link
Member

kltm commented May 9, 2023 •
edited
Loading

@dustine32 Sorry, you mention that. I'm just noting that scheme difference.

@dustine32
Copy link
Collaborator Author

dustine32 commented May 9, 2023 •
edited
Loading

Oh cool, the fixed providedBy in 879b0b6 actually links out now:
image

@kltm
Copy link
Member

kltm commented May 9, 2023

The change looks good to me.

kltm
kltm approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to self-merge on your schedule

@dustine32 dustine32 merged commit 9fa48df into master May 9, 2023
@dustine32 dustine32 mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kltm kltm kltm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dustine32 @kltm