Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View button in /go-cam for model should point to Alliance Pathway Viewer #21

Open
dustine32 opened this issue Oct 3, 2022 · 12 comments
Assignees

Comments

@dustine32
Copy link
Contributor

Title explains (most of) it all:
image
This View button should go to:
image
Not to the Noctua editorial interface.

@tmushayahama already has the code change in a branch. I can merge the change and deploy to AWS.

Tagging @thomaspd @kltm

@kltm
Copy link
Member

kltm commented Oct 3, 2022

@dustine32 @tmushayahama Could you link the branch?

@kltm
Copy link
Member

kltm commented Oct 3, 2022

Or setup a PR so we can see the code/link changes? <-- preferred

@dustine32
Copy link
Contributor Author

@kltm Ah crud, you're right. Sorry! The branch is creatively named "dev": https://github.com/geneontology/web-gocam/commits/dev

I just realized there were a lot of formatting changes that clutter the changes relevant to this ticket (noctuaAlliancePathwayViewUrl env var, getAlliancePathwayView function, hook function into browse-models.component.html). I also need to remove the URL change to point back to the regular go-public endpoint for fetching the JSON files. Thinking of just copying the relevant changes to a new branch and PR.

@kltm
Copy link
Member

kltm commented Oct 3, 2022

No worries, sometimes things get confused. Operationally, the change would be:

  noctuaAlliancePathwayViewUrl: 'http://noctua.geneontology.org/workbench/noctua-alliance-pathway-preview/?model_id=',
  noctuaPathwayViewUrl: "http://noctua.geneontology.org/workbench/pathwayview/?model_id=",

?

My understanding is that we wanted to have this be an embedded widget in the /go-cam site and not have traffic heading towards the curation system.

@dustine32
Copy link
Contributor Author

Correct on both @kltm. I think (@thomaspd may want to weigh in) this is a short-term fix to at least direct users to a more digestible graph. The full widget embedding could be handled in a new ticket?

@kltm
Copy link
Member

kltm commented Oct 3, 2022

I think the question here is if this is a "project" or not. If @thomaspd and @pgaudet agree, I'm more than happy to take this as a software maintenance ticket, but we do need to track both of these.

dustine32 added a commit that referenced this issue Oct 3, 2022
@thomaspd
Copy link

thomaspd commented Oct 4, 2022

Yes, this would be fine as a maintenance ticket. I think we're all in agreement that the public GO-CAM site should not point to our curation tool, and it's important to provide a visualization of these GO-CAMs so our users can understand what each of them represents.

@kltm
Copy link
Member

kltm commented Oct 4, 2022

@thomaspd I think the technical point that I miscommunicated is that this is still pointing to our curation tool and creating system traffic, load, and hinting bots. I agree that this is an improvement (getting rid of the login button if nothing else), but I still think we need to prioritized the "stronger" version of this much sooner than later.

@kltm
Copy link
Member

kltm commented Oct 6, 2022

@tmushayahama Believes that the stronger version of this--having the widget open on click--is quite easy, so we will take a look at that path first.

@dustine32
Copy link
Contributor Author

@tmushayahama can fill in the details but we discussed (with @thomaspd) that there is some Angular version issue that makes implementing the "on click widget open" much more difficult than expected. So, for a short-term fix, I can PR this change f648a87 and deploy.

@kltm
Copy link
Member

kltm commented Oct 10, 2022

@tmushayahama @dustine32 Yes, it would be good to get the details here for review.

@kltm kltm changed the title View button for model should point to Alliance Pathway Viewer View button in /go-cam for model should point to Alliance Pathway Viewer Dec 7, 2022
@kltm
Copy link
Member

kltm commented Dec 7, 2022

Pulling this out of project for keeping traffic away from curation interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants