Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External links should go to new AmiGO GO-CAM pages #23

Closed
kltm opened this issue Oct 28, 2022 · 9 comments
Closed

External links should go to new AmiGO GO-CAM pages #23

kltm opened this issue Oct 28, 2022 · 9 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@kltm
Copy link
Member

kltm commented Oct 28, 2022

This would be a fully fixed version of #21 (comment)

Some links at external locations point to the noctua curation system, creating load and outages for something that is not meant to be a public interface. An example (the only one?) is the pathway widget, which routes to a noctua view.

This would be closed when user all traffic associated with this repo is directed away from noctua (in conjunction with geneontology/api-gorest-2021#6).

@kltm kltm added the enhancement New feature or request label Nov 17, 2022
@kltm kltm changed the title No external links (GO-provided widgets or public interfaces) should point to the Noctua curation system External links (GO-provided widgets or public interfaces) and traffic come into the Noctua curation system Nov 17, 2022
@kltm kltm added the bug Something isn't working label Nov 17, 2022
@kltm kltm changed the title External links (GO-provided widgets or public interfaces) and traffic come into the Noctua curation system External links (GO-provided widgets or public interfaces) and go to the Noctua curation system Nov 17, 2022
@kltm kltm changed the title External links (GO-provided widgets or public interfaces) and go to the Noctua curation system External links (GO-provided widgets or public interfaces) go to the Noctua curation system Nov 17, 2022
@kltm kltm changed the title External links (GO-provided widgets or public interfaces) go to the Noctua curation system External links go to the Noctua curation system Nov 17, 2022
@kltm kltm changed the title External links go to the Noctua curation system External links should to new AmiGO GO-CAM pages Dec 7, 2022
@kltm kltm changed the title External links should to new AmiGO GO-CAM pages External links should go to new AmiGO GO-CAM pages Dec 15, 2022
@kltm
Copy link
Member Author

kltm commented Jul 31, 2023

In discussion with @vanaukenk and @ukemi , @kltm will

Otherwise, we'll take this as bugs and and fix as we find them as part of ongoing maintenance.

@vanaukenk
Copy link

See also: https://agr-jira.atlassian.net/browse/SCRUM-3157

@kltm
Copy link
Member Author

kltm commented Aug 1, 2023

I'm having a little trouble building the code on prod. Likely caused by an older node/npm; will be digging into it.

@kltm
Copy link
Member Author

kltm commented Aug 1, 2023

After initially running into this error after a wipe and build

[13:22:04] 'compile_js_dev' errored after 35 ms
[13:22:04] TypeError: Cannot read property 'value' of undefined
    at /home/bbop/local/src/git/amigo/gulpfile.js:322:45
    at new Promise (<anonymous>)
    at _client_compile_task (/home/bbop/local/src/git/amigo/gulpfile.js:297:12)
    at /home/bbop/local/src/git/amigo/gulpfile.js:345:20
    at Function._.map._.collect (/home/bbop/local/src/git/amigo/node_modules/underscore/underscore.js:172:24)
    at compile_js_dev (/home/bbop/local/src/git/amigo/gulpfile.js:344:12)
    at bound (domain.js:301:14)
    at runBound (domain.js:314:12)
    at asyncRunner (/home/bbop/local/src/git/amigo/node_modules/async-done/index.js:55:18)
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
[13:22:04] 'install' errored after 5.46 s

I was able to proceed with a second run of the command. All further wipe and build have not recreated this error, so there is some state I missed or the error is non-deterministic. Either way, pushing forward.

@kltm
Copy link
Member Author

kltm commented Aug 1, 2023

I jumped the gun on putting this out to production: we will need to have the updated code in the merged GO API out first.

@tmushayahama
Copy link

tmushayahama commented Aug 2, 2023

@kltm just from top of my head, bbop gulp doesn't work for node more than 10

@kltm
Copy link
Member Author

kltm commented Aug 2, 2023

Fortunately, it seems to be a non-deterministic issue. The patch-up that @pkalita-lbl did allows us to compile on some of the older versions, including production. The issues we have now are with me jumping the gun on the API, not that we've switched to HTTPS.

@kltm
Copy link
Member Author

kltm commented Sep 26, 2023

@kltm
Copy link
Member Author

kltm commented Sep 26, 2023

This now seems to function as expected.

@kltm kltm closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants