-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Barista dependencies in the GO-CAM API #6
Comments
After a little discussion, I think we will likely go for the rendered JSON route as a short-term solution (and allowing us to get to the AmiGO widgets faster), while keeping the Solr-ization on the books when we start bringing in the GO-CAM API to the GO API. |
@dustine32 Following up from the software meeting, scanning through the code, these seem to be the only instances of contact: Line 283 in 965cba7
/gocam/:id/activities usesLine 302 in 965cba7
/gocam/:id/enriched usesLine 334 in 965cba7
To my eye, these all seem to be identical and seem to bypass any kind of middleware, making them easy to change. I believe simply routing these to a static location will solve any problems we're having. Can you think of any reason this might not work? @balhoff What would be the best way to approach getting the currently returned raw JSON form out of minerva (or the noctua-models repo)? I'm assuming we don't currently have a command or CLI for this, but I'm wondering how hard it might be to add or if there might be other approaches? |
@kltm Thanks, I never realized the barista URLs were repeated like this!
Nope, can't think of any reason changing to a static JSON endpoint wouldn't work. I'm all for this. |
@balhoff (Bringing this up to a top-level comment for reference) |
So basically the format returned to Noctua when you request a whole model? I think it would be pretty easy to add a dump CLI command for that. |
Okay, with Minerva and initial pipeline work out of the way (geneontology/minerva#500), this becomes a deployment and API issue.
|
@dustine32 For when you're back around, I believe that URLs like this now work (although not automated yet): |
|
Will add the above command to |
…SON GO-CAM products after main release; for geneontology/api-gorest-2021#6
Now testing in |
@dustine32 Okay, it looks like the regular SOP running of |
@kltm Thank you! We can test this with dev instances of |
I wouldn't argue with however you think the best way to test might be. I'm most worried about something getting messed up with mimetypes or the like. |
the go-fastapi does not have any dependencies on barista, so removing this from that project for now. please of course add back if there are endpoints that do use barista that need to be migrated to the new API in support of the UI. It makes sense to me to have a step in the pipeline (python scripts potentially instead of API calls with a barista backend) that produces necessary files as artifacts without the API dependency. |
@sierra-moxon Clarifying initial comment (#6 (comment)), this is no longer in the merged API? |
@sierra-moxon just confirming that the merged GO-CAM API has no barsita connections, correct? |
Right; just Golr and RDF endpoint. |
@sierra-moxon Great--binned! |
This got accidentally closed in the shuffle. |
This is a dependency for geneontology/wc-gocam-viz#25 |
Keeping open until public deployment and they're gone gone. (The reason we often have a |
@sierra-moxon lapped me on this :) |
Recently, it seems that barista is having trouble, possibly related to increased use or volume and possibly related to its use as an upstream API (a la
api-gorest-2021/app.js
Line 283 in 3f2e995
We'd like to take a look at other ways of supplying this JSON data to the API in the short run. Ideas include
The text was updated successfully, but these errors were encountered: