Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thermostat.js #209

Closed
wants to merge 1 commit into from
Closed

Update thermostat.js #209

wants to merge 1 commit into from

Conversation

mtanana
Copy link

@mtanana mtanana commented Aug 19, 2015

Fixed some Fahrenheit issues on the thermostat. (Someone using Celsius might want to check this one out)

Fixed some Fahrenheit issues
@mtanana
Copy link
Author

mtanana commented Aug 20, 2015

Actually- don't accept this yet. I think the module has changed since the release I was working on.

@mtanana
Copy link
Author

mtanana commented Aug 20, 2015

ok- Checked and it should be fine with the newer release

@mtanana
Copy link
Author

mtanana commented Aug 20, 2015

I'm also working on fixing a bug in the status change for some thermostat messages. There is a cast class exception for the byte -> enum in the ZWave MIG. I think I have it figured out....

@genemars
Copy link
Member

please if you're willing to work on ZWaveLib use the new repository as HG will be updated soon to use the new library.
https://github.com/genielabs/zwave-lib-dotnet
Much more easy to debug and work on zwave from its own project :)
I will wait some more before merging this, in case you've got some updates.

@mtanana
Copy link
Author

mtanana commented Aug 22, 2015

Ohh- didn’t see that you were revamping. Yeah- you can kick out this request and I’ll check out the new repository and put in a request there after I make sure it is compliant with the newer stuff.

From: Gene [mailto:notifications@github.com]
Sent: Saturday, August 22, 2015 9:34 AM
To: genielabs/HomeGenie
Cc: mtanana
Subject: Re: [HomeGenie] Update thermostat.js (#209)

please if you're willing to work on ZWaveLib use the new repository as HG will be updated soon to use the new library.
https://github.com/genielabs/zwave-lib-dotnet
Much more easy to debug and work on zwave from its own project :)
I will wait some more before merging this, in case you've got some updates.


Reply to this email directly or view it on GitHub #209 (comment) . https://github.com/notifications/beacon/AEmnkJ8V8VMoENEaly8TbdwS7EdLiAIIks5oqI38gaJpZM4Fumbv.gif

@genemars genemars closed this Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants