Fix some PhpStorm inspections

composer.json

@@ -4,6 +4,7 @@
     "license": "MIT",
     "require": {
         "php": "^7.0",
+        "ext-simplexml": "*",
         "globalcitizen/php-iban": "^2.6",
         "moneyphp/money": "^3"
     },

src/Camt052/Decoder/V01/Message.php

@@ -3,10 +3,7 @@
 namespace Genkgo\Camt\Camt052\Decoder\V01;
 
 use Genkgo\Camt\Camt052\Decoder\Message as BaseMessageDecoder;
-use Genkgo\Camt\Camt052\DTO as Camt052DTO;
-use Genkgo\Camt\DTO;
 use \SimpleXMLElement;
-use \DateTimeImmutable;
 
 class Message extends BaseMessageDecoder
 {

src/Camt052/Decoder/V02/Message.php

@@ -3,10 +3,7 @@
 namespace Genkgo\Camt\Camt052\Decoder\V02;
 
 use Genkgo\Camt\Camt052\Decoder\Message as BaseMessageDecoder;
-use Genkgo\Camt\Camt052\DTO as Camt052DTO;
-use Genkgo\Camt\DTO;
 use \SimpleXMLElement;
-use \DateTimeImmutable;
 
 class Message extends BaseMessageDecoder
 {

src/DTO/Charges.php

@@ -1,13 +1,14 @@
 <?php
 namespace Genkgo\Camt\DTO;
 
+use BadMethodCallException;
 use Money\Money;
 
 class Charges
 {
     /** @var Money */
     private $totalChargesAndTaxAmount;
-    
+
     /** @var ChargesRecord[] */
     private $records = [];
 

src/DTO/ChargesRecord.php

@@ -5,15 +5,15 @@
 
 class ChargesRecord
 {
-  
+
     /** @var Money */
     private $amount;
 
     /**
      * @var bool
      */
     private $chargesIncluded­Indicator = false;
-    
+
     /**
      * @var string
      */
@@ -35,33 +35,33 @@ public function setAmount(Money $money)
     {
         $this->amount = $money;
     }
-    
+
     /**
-     * @return ChargesIncluded­Indicator
+     * @return bool
      */
     public function getChargesIncluded­Indicator()
     {
         return $this->chargesIncluded­Indicator;
     }
 
     /**
-     * @param $chargesIncluded­Indicator
+     * @param bool $chargesIncluded­Indicator
      */
     public function setChargesIncluded­Indicator($chargesIncluded­Indicator)
     {
         $this->chargesIncluded­Indicator = $chargesIncluded­Indicator;
     }
 
     /**
-     * @return Identification
+     * @return string
      */
     public function getIdentification()
     {
         return $this->identification;
     }
 
     /**
-     * @param $identification
+     * @param string $identification
      */
     public function setIdentification($identification)
     {

src/DTO/ContactDetails.php

@@ -46,7 +46,7 @@ public function getNamePrefix()
     {
         return $this->namePrefix;
     }
-    
+
     /**
      * @param string $namePrefix
      */
@@ -62,7 +62,7 @@ public function getName()
     {
         return $this->name;
     }
-    
+
     /**
      * @param string $name
      */
@@ -78,9 +78,9 @@ public function getPhoneNumber()
     {
         return $this->phoneNumber;
     }
-    
+
     /**
-     * @param string $name
+     * @param string $phoneNumber
      */
     public function setPhoneNumber($phoneNumber)
     {
@@ -94,9 +94,9 @@ public function getMobileNumber()
     {
         return $this->mobileNumber;
     }
-    
+
     /**
-     * @param string $name
+     * @param string $mobileNumber
      */
     public function setMobileNumber($mobileNumber)
     {
@@ -110,9 +110,9 @@ public function getFaxNumber()
     {
         return $this->faxNumber;
     }
-    
+
     /**
-     * @param string $name
+     * @param string $faxNumber
      */
     public function setFaxNumber($faxNumber)
     {
@@ -126,9 +126,9 @@ public function getEmailAddress()
     {
         return $this->emailAddress;
     }
-    
+
     /**
-     * @param string $name
+     * @param string $emailAddress
      */
     public function setEmailAddress($emailAddress)
     {
@@ -142,9 +142,9 @@ public function getOther()
     {
         return $this->other;
     }
-    
+
     /**
-     * @param string $name
+     * @param string $other
      */
     public function setOther($other)
     {

src/DTO/OrganisationIdentification.php

@@ -76,7 +76,7 @@ public function getBic()
     {
         return $this->bic;
     }
-    
+
     /**
      * @param string $bic
      */
@@ -93,7 +93,7 @@ public function getIbei()
     {
         return $this->ibei;
     }
-    
+
     /**
      * @param string $ibei
      */
@@ -110,7 +110,7 @@ public function getBei()
     {
         return $this->bei;
     }
-    
+
     /**
      * @param string $bei
      */
@@ -127,7 +127,7 @@ public function getEangln()
     {
         return $this->eangln;
     }
-    
+
     /**
      * @param string $eangln
      */
@@ -144,7 +144,7 @@ public function getChipsUniversalId()
     {
         return $this->chipsUniversalId;
     }
-    
+
     /**
      * @param string $chipsUniversalId
      */
@@ -161,7 +161,7 @@ public function getDuns()
     {
         return $this->duns;
     }
-    
+
     /**
      * @param string $duns
      */
@@ -178,7 +178,7 @@ public function getBankPartyId()
     {
         return $this->bankPartyId;
     }
-    
+
     /**
      * @param string $bankPartyId
      */
@@ -195,7 +195,7 @@ public function getTaxId()
     {
         return $this->taxId;
     }
-    
+
     /**
      * @param string $taxId
      */
@@ -212,9 +212,9 @@ public function getOtherId()
     {
         return $this->otherId;
     }
-    
+
     /**
-     * @param string $otherID
+     * @param string $otherId
      */
     public function setOtherId($otherId)
     {
@@ -229,7 +229,7 @@ public function getOtherIssuer()
     {
         return $this->otherIssuer;
     }
-    
+
     /**
      * @param string $otherIssuer
      */
@@ -245,7 +245,7 @@ public function getOtherSchemeName()
     {
         return $this->otherSchemeName;
     }
-    
+
     /**
      * @param string $otherSchemeName
      */
@@ -261,7 +261,7 @@ public function getOtherType()
     {
         return $this->otherType;
     }
-    
+
     /**
      * @param string $otherType
      */
@@ -277,7 +277,7 @@ public function getIssuer()
     {
         return $this->issuer;
     }
-    
+
     /**
      * @param string $issuer
      */

src/DTO/ProprietaryAccount.php

@@ -2,8 +2,6 @@
 
 namespace Genkgo\Camt\DTO;
 
-use Genkgo\Camt\DTO\Account;
-
 /**
  * Class ProprietaryAccount
  * @package Genkgo\Camt

src/DTO/Record.php

@@ -108,7 +108,7 @@ public function getPagination()
     {
         return $this->pagination;
     }
-    
+
     /**
      * @param Pagination $pagination
      */
@@ -124,7 +124,7 @@ public function getElectronicSequenceNumber()
     {
         return $this->electronicSequenceNumber;
     }
-    
+
     /**
      * @param string $electronicSequenceNumber
      */
@@ -140,7 +140,7 @@ public function getLegalSequenceNumber()
     {
         return $this->legalSequenceNumber;
     }
-    
+
     /**
      * @param string $legalSequenceNumber
      */
@@ -150,15 +150,15 @@ public function setLegalSequenceNumber($legalSequenceNumber)
     }
 
     /**
-     * @param string $copyDuplicateIndicator
+     * @return string
      */
     public function getCopyDuplicateIndicator()
     {
         return $this->copyDuplicateIndicator;
     }
-    
+
     /**
-     * @return string
+     * @param string $copyDuplicateIndicator
      */
     public function setCopyDuplicateIndicator($copyDuplicateIndicator)
     {
@@ -172,7 +172,7 @@ public function getFromDate()
     {
         return $this->fromDate;
     }
-    
+
     /**
      * @param DateTimeImmutable $fromDate
      */
@@ -188,7 +188,7 @@ public function getToDate()
     {
         return $this->toDate;
     }
-    
+
     /**
      * @param DateTimeImmutable $toDate
      */

src/DTO/RemittanceInformation.php

@@ -81,7 +81,7 @@ public function setMessage($message)
      */
     public function addStructuredBlock(StructuredRemittanceInformation $structuredRemittanceInformation)
     {
-        return $this->structuredBlocks[] = $structuredRemittanceInformation;
+        $this->structuredBlocks[] = $structuredRemittanceInformation;
     }
 
     /**
@@ -109,7 +109,7 @@ public function getStructuredBlock()
      */
     public function addUnstructuredBlock(UnstructuredRemittanceInformation $unstructuredRemittanceInformation)
     {
-        return $this->unstructuredBlocks[] = $unstructuredRemittanceInformation;
+        $this->unstructuredBlocks[] = $unstructuredRemittanceInformation;
     }
 
     /**