Skip to content

Commit

Permalink
Bug 59 (#60)
Browse files Browse the repository at this point in the history
* bug 59 is invalid, fixes #59

* fix lint, add some convenience scripts

* use php 7.3.11 in appveyor
  • Loading branch information
frederikbosch committed Oct 28, 2019
1 parent a2e3ee6 commit f0be0a0
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 6 deletions.
6 changes: 2 additions & 4 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ clone_folder: c:\projects\php-project-workspace
environment:
matrix:
- dependencies: lowest
php_ver_target: 7.1.12
php_ver_target: 7.3.11
- dependencies: highest
php_ver_target: 7.1.12
- dependencies: highest
php_ver_target: 7.2
php_ver_target: 7.3.11

## Cancel all if one fails
matrix:
Expand Down
11 changes: 11 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,16 @@
"psr-4": {
"Genkgo\\TestMail\\": ["test"]
}
},
"scripts": {
"lint": [
"./vendor/bin/php-cs-fixer fix --verbose --config .php_cs.dist ./src ./test"
],
"test": [
"./vendor/bin/phpunit -c phpunit.xml",
"./vendor/bin/php-cs-fixer fix --verbose --dry-run --config .php_cs.dist ./src ./test",
"./vendor/bin/phpstan analyse -l max src",
"./vendor/bin/phpstan analyse -l max -c .phpstan.test.neon test"
]
}
}
10 changes: 10 additions & 0 deletions test/Stub/AlternativeText/bug_59.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>Title</title>
</head>
<body>
<p>zażółć gęślą jaźń</p>
</body>
</html>
1 change: 1 addition & 0 deletions test/Stub/AlternativeText/bug_59.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
zażółć gęślą jaźń
4 changes: 2 additions & 2 deletions test/Unit/AddressListTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ public function it_is_immutable()
$addressList,
$addressList->withAddress(
new Address(new EmailAddress('me1@example.com'), 'name')
)
)
);

$this->assertNotSame(
$addressList,
$addressList->withoutAddress(
new Address(new EmailAddress('me1@example.com'), 'name')
)
)
);
}

Expand Down
1 change: 1 addition & 0 deletions test/Unit/AlternativeTextTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public function provideHtmlFiles()
return [
['simple.html', 'simple.crlf.txt'],
['error.html', 'error.txt'],
['bug_59.html', 'bug_59.txt'],
];
}
}

0 comments on commit f0be0a0

Please sign in to comment.