Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues when loading all namespaces #1

Closed
vemv opened this issue Dec 8, 2020 · 3 comments
Closed

Some issues when loading all namespaces #1

vemv opened this issue Dec 8, 2020 · 3 comments

Comments

@vemv
Copy link

vemv commented Dec 8, 2020

Hi, lovely project!

I encountered a couple issues when firing up a repl and loading all namespaces (I have a custom setup which does that):

  • merely requireing sound.patch plays+loops the associated song. It's nice to hear it but it gets old quickly. Probably it'd be better if the ns didn't have this compile-time side-effect.
  • requiring intro spits the following stacktrace:
error {
 :cause javafx.event.EventHandler
 :via
 [{:type clojure.lang.Compiler$CompilerException
   :message Syntax error compiling at (cljfx/coerce.clj:1:1).
   :data #:clojure.error{:phase :compile-syntax-check, :line 1, :column 1, :source cljfx/coerce.clj}
   :at [clojure.lang.Compiler load Compiler.java 7648]}
  {:type java.lang.ClassNotFoundException
   :message javafx.event.EventHandler
   :at [java.net.URLClassLoader findClass URLClassLoader.java 382]}]

...I use AdoptOpenJDK. IIRC one needs Azul's or Oracle's JDK?

Thanks - V

@genmeblog
Copy link
Owner

intro is a file working with a https://github.com/scicloj/notespace/. Forget about it for a while. However it should work with OpenJDK15.

@genmeblog
Copy link
Owner

To start/stop song please call sound.core/toggle-playing. Treat this code as a demo 🙂

@vemv
Copy link
Author

vemv commented Dec 8, 2020

Thanks!

Nice pointer on JDK15, I didn't know it was a thing.

The thing with sound.patch and intro is that they can be automatically required by the repl or IDE. I think cider-refresh is a well-known example of auto-requiring solutions.

If it was possible to make ns loading less side-effectful that would be appreciated, else no issue!

@vemv vemv closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants