Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacVim-Yosemite-Python should link with system ruby too #1

Closed
CarterLi opened this issue Feb 1, 2015 · 7 comments
Closed

MacVim-Yosemite-Python should link with system ruby too #1

CarterLi opened this issue Feb 1, 2015 · 7 comments

Comments

@CarterLi
Copy link

CarterLi commented Feb 1, 2015

I tried MacVim-Yosemite-Python.tar.gz. It didn't work because:

% mvim
dyld: Library not loaded: /usr/local/lib/libruby.2.1.0.dylib
  Referenced from: /Applications/MacVim.app/Contents/MacOS/Vim
  Reason: image not found
[1]    2069 trace trap (core dumped)  mvim

Why do a version which targets system python requires homebrew ruby?

I tried MacVim-Homebrew-Python-2.7.8.tar.gz with homebrew python installed. It didn't work too for the same reason.

OS: OSX 10.10.2

@CarterLi
Copy link
Author

CarterLi commented Feb 1, 2015

I did try brew install ruby, but ruby-2.2.0 was installed instead of ruby-2.1.0. Thus didn't help.
MacVim-Basic.tar.gz works though

@genoma
Copy link
Owner

genoma commented Feb 1, 2015

Yes you are right, the correct behaviour should be linking the default Ruby Yosemite version when i build MacVim with Yosemite Python.

I did try brew install ruby, but ruby-2.2.0 was installed instead of ruby-2.1.0. Thus didn't help.
MacVim-Basic.tar.gz works though

Thats because the latest build has been compiled when Ruby "brewed" version was 2.1.0 and i didn't noticed any problem because for the past few months i've used mainly Vim through terminal instead of MacVim.

The problem was a garbled Ruby installation on my Mac, i've fixed the problem in the latest release... hopefully.

I will try to fix both the issues today building an updated set of MacVim binaries.

@genoma
Copy link
Owner

genoma commented Feb 1, 2015

The latest release should have the correct Ruby version linked in both binaries (Yosemite vanilla and Homebrew).

@CarterLi
Copy link
Author

CarterLi commented Feb 4, 2015

Tested and worked fine.
Thinks for this good project & quick fix

@CarterLi CarterLi closed this as completed Feb 4, 2015
@CarterLi
Copy link
Author

CarterLi commented Feb 4, 2015

Just a suggestion:
Can we provide another version which copies those homebrew dylibs into MacVim.app to avoid the dependency hell?

@genoma
Copy link
Owner

genoma commented Feb 4, 2015

This goes beyond my programming knowledge i fear and i'd like to keep this version as close as possible to the original MacVim (which should change project maintainer soon). That's because it will be a lot easier to merge the original MacVim into this one and vice versa.

This fork has been made for my obsession to keep updated MacVim as i keep my Vim build with the multiple weekly patches developed by Bram and the Vim community, i've only replicated the way Björn has used Git to merge Vim development with MacVim resolving a couple of merge conflict.

Lastly, i've been awfully busy for the past few months and the build error was completely my fault (a wrongly linked Python version with Homebrew and i didn't pay attention to what version was linked). I've changed the way i build the releases and it should be easier to spot an error in linked libraries.

Anyway thanks for spotting this error and feel free to report any other build issue in future.

@CarterLi
Copy link
Author

CarterLi commented Feb 5, 2015

This goes beyond my programming knowledge i fear and i'd like to keep this version as close as possible to the original MacVim

Oh yes. Then another suggestion: Is it ok to link dylibs with /usr/local/lib/libruby.dylib instead of version specified /usr/local/lib/libruby.2.1.0.dylib? I assume that it should be ABI-compatible between small bugfix-only releases...

the original MacVim (which should change project maintainer soon)

Glad to see it! There are many awesome PRs opening. I expect they get merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants