Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it #30

Closed
2 tasks done
sheridancbio opened this issue Jul 30, 2016 · 2 comments
Closed
2 tasks done

Comments

@sheridancbio
Copy link
Collaborator

sheridancbio commented Jul 30, 2016

If we are switching to using a direct DB interaction through a java repository, then this class will be mostly deleted.

Otherwise, responsibilities should be grouped and broken out into other classes. One example might be to separate the parsing of blast xml, and separate the generation of insert statements.

Other improvements:

  • "choose" argument into parse2sql should be renamed so that it is clear what choice is being made. Also "1" and "0" as choices are unclear. Maybe use an enum with named values ... or define static final int class members at least.
  • parseblastresults : we have alternatives SmallMem and Single, but maybe there is no use for Single? If SmallMem will always work, drop Single from code.
@juexinwang
Copy link
Collaborator

Yes, SmallMem and Single may be dropped. But it is efficient and quick for it did not divide the original size of the input

@sheridancbio sheridancbio changed the title PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it Pri3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it Aug 4, 2016
@juexinwang
Copy link
Collaborator

Done

@sheridancbio sheridancbio changed the title Pri3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it Rev3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it Aug 9, 2016
@sheridancbio sheridancbio changed the title Rev3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants