You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we are switching to using a direct DB interaction through a java repository, then this class will be mostly deleted.
Otherwise, responsibilities should be grouped and broken out into other classes. One example might be to separate the parsing of blast xml, and separate the generation of insert statements.
Other improvements:
"choose" argument into parse2sql should be renamed so that it is clear what choice is being made. Also "1" and "0" as choices are unclear. Maybe use an enum with named values ... or define static final int class members at least.
parseblastresults : we have alternatives SmallMem and Single, but maybe there is no use for Single? If SmallMem will always work, drop Single from code.
The text was updated successfully, but these errors were encountered:
Yes, SmallMem and Single may be dropped. But it is efficient and quick for it did not divide the original size of the input
sheridancbio
changed the title
PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it
Pri3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it
Aug 4, 2016
sheridancbio
changed the title
Pri3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it
Rev3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it
Aug 9, 2016
sheridancbio
changed the title
Rev3 : PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it
PdbScriptsPipelineMakeSQL.java should be improved if we are keeping it
Aug 12, 2016
If we are switching to using a direct DB interaction through a java repository, then this class will be mostly deleted.
Otherwise, responsibilities should be grouped and broken out into other classes. One example might be to separate the parsing of blast xml, and separate the generation of insert statements.
Other improvements:
The text was updated successfully, but these errors were encountered: