Fix bug of "server crashed when client is killed" #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on closed channel" In old implementation, if we use channel to pass proxy event (e.g. establishing, register, unregister event), server may get panic "send on closed channel". In this commit, all channel usage for proxy event passing purpose are removed, and replaced with direct function calls. As an example, in v0.5.0-beta, we use channel to passed register event after remote host dailing is successful. But the websocket connection between server and client can get closed due to some reason, which can make register channel closed. Then the register event would be send to a closed channel and raise a panic error. fix #26, re #19
genshen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixed the bug mentioned in issue #26 .