Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon-big to thoma #167

Closed
ChrisMGeo opened this issue Sep 5, 2022 · 2 comments · Fixed by #169
Closed

Add icon-big to thoma #167

ChrisMGeo opened this issue Sep 5, 2022 · 2 comments · Fixed by #169

Comments

@ChrisMGeo
Copy link
Contributor

https://api.genshin.dev/characters/thoma/list doesn't show icon-big and https://api.genshin.dev/characters/thoma/icon-big doesn't exist.

@GerGerApex1
Copy link
Contributor

It's missing some images that's why :(. You can make a pull request to add it.

@ChrisMGeo
Copy link
Contributor Author

ChrisMGeo commented Sep 5, 2022

Um, I'm pretty new to how any of these projects and apis work, but I was also using the https://github.com/frzyc/genshin-optimizer project as a reference for my use case, and they have a bunch of character assets, but I'm not sure if you're able to use their assets, but this link is for the thoma icon https://github.com/frzyc/genshin-optimizer/blob/master/src/Data/Characters/Thoma/Icon.png I think this is the big icon too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants