-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump stack to latest #1137
bump stack to latest #1137
Conversation
Chiming in, as indicated in IRC. I did a Regardless, my advice is to order your commits as follows:
There should be no inter-commit inconsistency with this sequence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment on masks. Thank you!
profiles/package.mask
Outdated
>=dev-haskell/hspec-discover-2.7.2 | ||
>=dev-haskell/hspec-core-2.7.2 | ||
>=dev-haskell/hspec-2.7.2 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above unmasks do not seem to relate to the stack bump. Could you please explain this one to me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, these must have been why I thought I needed #1118...I'll need to recreate things, see why I thought this was needed.
If this results in no inconsistency then...why was the pantry ever masked to begin with? |
The ghc and cabal version bumps are due to the latest hackport Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
The patch disables two tests that attempt to access the network. Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@gmail.com>
@ezzieyguywuf iirc it was masked to avoid having to have |
Leaving this as [draft] until #1118 is merged, as it depends on some of those
changes.
@trofi, similar to some of the conversations we had in #1118, how would you go
about ordering/squashing these commits?
I want/need to drop the old version, since it has a dependency on a masked
pandoc
. However, after dropping the old version, we're left with only the9999
version in the repository until the next commit which adds2.5.1.1
.Should I just squash these two commits together?