-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-libs/mesa-9999: Add iris and vulkan-overlay-layer support #11167
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @FireBurn media-libs/mesa: @gentoo/x11 Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
I'm not sure where the other video cards are defined to add in iris, should I just add it to the local metadata? |
profiles/desc/video_cards.desc |
Can you please split up the commits? One should add iris, one should add vulkan-overlay, and one should add the llvm:9. |
Allow mesa-9999 to compile with llvm:9 Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
This adds the vulkan-overlay-layer to the mesa-9999 ebuild It can be enabled with: VK_INSTANCE_LAYERS=VK_LAYER_MESA_overlay <program> More help on how to use it can be found with: VK_LAYER_MESA_OVERLAY_STATS=help Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
This allows the i965 alternative Gallium Iris driver to be built Intel Gen8 / Broadwell or newer is required to use the Iris driver Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
Pull request CI reportReport generated at: 2019-03-01 14:41 UTC No issues found |
Thanks. Merged. |
This allows the i965 alternative Gallium Iris driver to be built Intel Gen8 / Broadwell or newer is required to use the Iris driver Closes: #11167 Signed-off-by: Mike Lothian <mike@fireburn.co.uk> Signed-off-by: Matt Turner <mattst88@gentoo.org>
@@ -23,6 +23,7 @@ | |||
<flag name="valgrind">Compile in valgrind memory hints</flag> | |||
<flag name="vdpau">Enable the VDPAU acceleration interface for the Gallium3D Video Layer.</flag> | |||
<flag name="vulkan">Enable Vulkan drivers</flag> | |||
<flag name="vulkan-overlay">Enable vulkan-overlay-layer for vulkan stats"</flag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray "
character at the end of description.
Also it would be nice if description briefly informed what vulkan-overlay-layer actually is, for whom it is useful etc.
(Based on other articles in internet, I conclude that it is useful only for developers of applications/drivers...)
Please use word statistics
, not informal stats
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's useful for anyone that wants to know the FPS of their vulkan app
I'll get the description updated
…On Tue, 5 Mar 2019, 19:08 Arfrever, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In media-libs/mesa/metadata.xml
<#11167 (comment)>:
> @@ -23,6 +23,7 @@
<flag name="valgrind">Compile in valgrind memory hints</flag>
<flag name="vdpau">Enable the VDPAU acceleration interface for the Gallium3D Video Layer.</flag>
<flag name="vulkan">Enable Vulkan drivers</flag>
+ <flag name="vulkan-overlay">Enable vulkan-overlay-layer for vulkan stats"</flag>
Stray " character at the end of description.
Also it would be nice if description briefly informed what
vulkan-overlay-layer actually is, for whom it is useful etc.
(Based on other articles in internet, I conclude that it is useful only
for developers of applications/drivers...)
Please use word statistics, not informal
<https://en.wiktionary.org/wiki/stats> stats.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11167 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFR87qEQpfE42PvWlKP5xMGge3qLs9zks5vTsCkgaJpZM4bTFqp>
.
|
This alows the i965 alternative iris to be built and the
vulkan-overlay-layer which is similar to gallium hud
Also allow mesa-9999 to compile with llvm:9
Signed-off-by: Mike Lothian mike@fireburn.co.uk