Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-python/PyQt5: bump to 5.12.1 #11415

Closed
wants to merge 2 commits into from
Closed

dev-python/PyQt5: bump to 5.12.1 #11415

wants to merge 2 commits into from

Conversation

steils
Copy link
Member

@steils steils commented Mar 19, 2019

Closes: https://bugs.gentoo.org/680968
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin stefan.strogin@gmail.com

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @steils
Areas affected: ebuilds
Packages affected: dev-python/PyQt5

dev-python/PyQt5: @gentoo/qt

Linked bugs

Bugs linked: 680968

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 19, 2019
@a17r a17r requested a review from Pesa March 19, 2019 21:21
@steils steils changed the title dev-python/PyQt5: bump to 5.12 dev-python/PyQt5: bump to 5.12.1 Mar 20, 2019
Pesa
Pesa previously requested changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@Pesa Pesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of bumping to 5.12 if 5.12.1 is already out?

Moreover, you can drop sourceforge from SRC_URI, https://www.riverbankcomputing.com/pipermail/pyqt/2019-February/041278.html

@Pesa
Copy link
Contributor

Pesa commented Mar 20, 2019

Ok, you literally just pushed 5.12.1 :) I'll take a look asap

@steils steils mentioned this pull request Mar 21, 2019
Closed
@steils
dev-python/PyQt5: bump to 5.12.1
580f1c0 
Closes: https://bugs.gentoo.org/680968
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
@steils
dev-python/PyQt5: fix SRC_URI
2b55df5 
Sourceforge mirror is no longer used by the upstream.
Change SRC_URI to riverbankcomputing.com.

Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-03-21 11:18 UTC
Newest commit scanned: 2b55df5
Status: ✅ good

No issues found

@Pesa Pesa dismissed their stale review March 21, 2019 18:44

Thanks, I'll squash the commits and push

@steils steils deleted the PyQt5 branch March 21, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pesa Pesa Pesa left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@steils @gentoo-bot @Pesa @gentoo-repo-qa-bot