dev-python/PyQtWebEngine: new package #11432
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentSubmitter: @steils dev-python/PyQtWebEngine: @gentoo/proxy-maint (new package) Linked bugsBugs linked: 679202 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
steils
force-pushed
the
PyQtWebEngine
branch
7 times, most recently
from
e359695
to
3bc2120
Compare
|
Rebased onto the latest master with PyQt-5.12.1 merged, so now CI does not think the ebuild is broken. |
| RDEPEND="${PYTHON_DEPS} | ||
| >=dev-python/PyQt5-5.12.1[${PYTHON_USEDEP},widgets] | ||
| >=dev-python/PyQt5-sip-4.19.14:=[${PYTHON_USEDEP}] | ||
| >=dev-qt/qtwebengine-5.12[widgets]" |
There was a problem hiding this comment.
are you sure about this >=5.12 dep?
There was a problem hiding this comment.
No, I am not sure. But I did not test it with Qt-5.{10,11}. Should it be tested before commiting this ebuild?
PyQtWebEngine is a set of Python bindings for Qt WebEngine framework. Before PyQt5-5.12 these bingings were a part of PyQt5. Now it is a separate package. Packages that depended on dev-python/PyQt5[webengine] now must depend on dev-python/PyQtWebEngine. Closes: https://bugs.gentoo.org/679202 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
Pull request CI reportReport generated at: 2019-03-30 23:35 UTC No issues found |
|
|
||
| src_prepare() { | ||
| default | ||
| python_copy_sources |
There was a problem hiding this comment.
configuration() does an out-of-source build, so why are you copying the sources here?
| IUSE="debug" | ||
|
|
||
| RDEPEND="${PYTHON_DEPS} | ||
| >=dev-python/PyQt5-5.12.1[${PYTHON_USEDEP},widgets] |
There was a problem hiding this comment.
When webengine was part of PyQt5, other modules were needed, namely network, printsupport, and webchannel. Are those not required anymore?
|
I've merged this with a few adjustments. Thanks! |
PyQtWebEngine is a set of Python bindings for Qt WebEngine framework.
Before PyQt5-5.12 these bingings were a part of PyQt5. Now it is a
separate package.
Packages that depended on dev-python/PyQt5[webengine] now must depend on
dev-python/PyQtWebEngine.
Closes: https://bugs.gentoo.org/679202
Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Stefan Strogin stefan.strogin@gmail.com