dev-libs/bglibs: EAPI7, update ebuild #11794

mm1ke · 2019-04-22T18:43:56Z

Hi,

This PR updates bglibs for EAPI7, adds some missing die and removes the usage of dohtml.
Please review.
Also added sys-devel/libtool dependency in order to close bug #380649

Signed-off-by: Michael Mair-Keimberger m.mairkeimberger@gmail.com

gentoo-bot · 2019-04-22T18:52:13Z

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: dev-libs/bglibs

dev-libs/bglibs: @robbat2

Linked bugs

Bugs linked: 380649

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

SoapGentoo · 2019-04-23T08:53:06Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+
+	dodoc ANNOUNCEMENT NEWS README ChangeLog TODO VERSION
+	docinto html
+	dodoc doc/html/*


dodoc -r doc/html/. (avoid globbing)

SoapGentoo · 2019-04-23T08:53:12Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+	docinto html
+	dodoc doc/html/*
+	docinto latex
+	dodoc doc/latex/*


SoapGentoo · 2019-04-23T08:53:47Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+	dosym ../libbg-sysdeps.so.1.1.1 /usr/$(get_libdir)/bglibs/libbg-sysdeps.so.1.1.1
+
+	rm "${D}"/usr/$(get_libdir)/bglibs/libbg.la || die
+	rm "${D}"/usr/$(get_libdir)/bglibs/libbg-sysdeps.la || die


${ED} instead of ${D}

SoapGentoo · 2019-04-23T08:54:04Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+
+	#install .so in LDPATH
+	mv "${D}"/usr/$(get_libdir)/bglibs/libbg.so.1.1.1 "${D}"/usr/$(get_libdir)/ || die
+	mv "${D}"/usr/$(get_libdir)/bglibs/libbg-sysdeps.so.1.1.1 "${D}"/usr/$(get_libdir)/ || die


SoapGentoo · 2019-04-23T08:54:36Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+
+	#make backwards compatible symlinks
+	dosym /usr/$(get_libdir)/bglibs /usr/$(get_libdir)/bglibs/lib
+	[ "$(get_libdir)" != "lib" ] && dosym /usr/$(get_libdir)/bglibs /usr/$(get_libdir)/bglibs/$(get_libdir)


[[ $(get_libdir) != lib ]] && ...
The double brackets are safer and recommended in the Handbook

Also, can you try and make the symlink relative?

SoapGentoo · 2019-04-23T08:55:44Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+		"${S}"/Makefile || die
+	sed -i \
+		-e '/selftests/d' \
+		"${S}"/TARGETS || die


drop the "${S}"/

SoapGentoo · 2019-04-23T08:56:25Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

@@ -0,0 +1,80 @@
+# Copyright 1999-2019 Gentoo Authors


Thanks @mm1ke , this package sorely needed it. Instead of bumping the current version, could you try adding the latest upstream version instead?

Hmm, i can do it on my todo list. I saw there is a newer version of that package, but to be honest i don't use any of it's customers so i didn't bother looking further into it..

SoapGentoo · 2019-04-23T08:56:53Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+}
+
+src_compile() {
+	echo "${D}/usr/bin" > conf-bin || die


SoapGentoo · 2019-04-23T08:57:07Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+	#make backwards compatible symlinks
+	dosym /usr/$(get_libdir)/bglibs /usr/$(get_libdir)/bglibs/lib
+	[ "$(get_libdir)" != "lib" ] && dosym /usr/$(get_libdir)/bglibs /usr/$(get_libdir)/bglibs/$(get_libdir)
+	dosym /usr/include/bglibs /usr/$(get_libdir)/bglibs/include


relative symlink pls

mm1ke · 2019-04-23T17:04:53Z

@SoapGentoo
I hope i didn't miss anything :) The package still builds fine at least.

mm1ke · 2019-05-05T11:35:35Z

@SoapGentoo
I've rebased this PR. A version bump was added in the meanwhile. Don't know if my PR is still needed, but since it's a major(?) version bump, it might be good to keep the older one too? (and thus bump it to EAPI7)

robbat2 · 2019-05-06T05:48:01Z

@steils Can you eyeball and check this for updates?

steils

Thanks Michael. I think this PR is still needed, as bglibs-2.04 is masked for a little while.

dev-libs/bglibs/bglibs-1.106-r2.ebuild

steils · 2019-05-06T06:21:17Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+	docinto html
+	dodoc -r doc/html/.
+	docinto latex
+	dodoc -r doc/latex/.


Installing *.tex files looks strange for me. I would suggest to compile a pdf and install it when USE=doc is enabled (e.g. like in bglibs-2.04.ebuild).

Changed this too..
Again, basically took over from the bglibs-2.04.ebuild

steils · 2019-05-06T20:17:21Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+	rm "${ED}"/usr/$(get_libdir)/bglibs/libbg-sysdeps.la || die
+
+	dodoc ANNOUNCEMENT NEWS README ChangeLog TODO VERSION
+	docinto html


A nitpicking: now refman.pdf is installed to doc/html/ :)
(You do not need docinto html here, just:

dodoc -r doc/html/ if use doc; then dodoc doc/latex/refman.pdf fi

You're right, nice catch.. fixed :)

steils · 2019-05-06T20:24:30Z

dev-libs/bglibs/bglibs-1.106-r2.ebuild

+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~mips ~ppc ~ppc64 ~sparc ~x86"
+IUSE="doc"
+
+DEPEND="sys-devel/libtool"


Are you sure this is DEPEND, not BDEPEND?

You're right again, I've put it into BDEPEND

Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com> Closes: https://bugs.gentoo.org/380649

mm1ke · 2019-05-11T15:23:49Z

Ping, any chance we can merge this?

gentoo-repo-qa-bot · 2019-05-11T16:00:02Z

Pull request CI report

Report generated at: 2019-05-11 16:00 UTC
Newest commit scanned: 4983732
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/9711084/output.html#media-libs/mesa

steils · 2019-05-17T15:38:33Z

@mm1ke Maybe you would like to proxy-maintain bglibs (and any of its revdeps)? robbat2 says he doesn't use them and doesn't want to maintain them anymore.

mm1ke · 2019-05-18T16:50:51Z

@steils sorry, not really. I also don't use it actually. Only bumped it to get rid of EAPI2 ebuilds.

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 22, 2019

mm1ke force-pushed the bgli-k2e3N3OQ branch from 7a60593 to 46a959e Compare April 22, 2019 18:48

mm1ke changed the title ~~dev-libs/bglibs: EAPI7, update ebuild~~ [please reassign] dev-libs/bglibs: EAPI7, update ebuild Apr 22, 2019

gentoo-bot changed the title ~~[please reassign] dev-libs/bglibs: EAPI7, update ebuild~~ dev-libs/bglibs: EAPI7, update ebuild Apr 22, 2019

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 22, 2019

SoapGentoo suggested changes Apr 23, 2019

View reviewed changes

mm1ke force-pushed the bgli-k2e3N3OQ branch from 46a959e to 3bc1f58 Compare April 23, 2019 16:57

mm1ke force-pushed the bgli-k2e3N3OQ branch from 3bc1f58 to f08bd2d Compare May 5, 2019 11:32

steils reviewed May 6, 2019

View reviewed changes

mm1ke force-pushed the bgli-k2e3N3OQ branch from f08bd2d to a7f9716 Compare May 6, 2019 17:35

steils reviewed May 6, 2019

View reviewed changes

mm1ke force-pushed the bgli-k2e3N3OQ branch from a7f9716 to 0eab979 Compare May 7, 2019 17:23

steils approved these changes May 7, 2019

View reviewed changes

dev-libs/bglibs: EAPI7, update ebuild

4983732

Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com> Closes: https://bugs.gentoo.org/380649

mm1ke force-pushed the bgli-k2e3N3OQ branch from 0eab979 to 4983732 Compare May 11, 2019 15:23

gentoo-bot closed this in 43fa553 May 17, 2019

mm1ke deleted the bgli-k2e3N3OQ branch September 22, 2019 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-libs/bglibs: EAPI7, update ebuild #11794

dev-libs/bglibs: EAPI7, update ebuild #11794

mm1ke commented Apr 22, 2019 •

edited

gentoo-bot commented Apr 22, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

mm1ke Apr 23, 2019

SoapGentoo Apr 23, 2019

SoapGentoo Apr 23, 2019

mm1ke commented Apr 23, 2019

mm1ke commented May 5, 2019

robbat2 commented May 6, 2019

steils left a comment

steils May 6, 2019

mm1ke May 6, 2019

steils May 6, 2019

mm1ke May 7, 2019

steils May 6, 2019

mm1ke May 7, 2019

mm1ke commented May 11, 2019

gentoo-repo-qa-bot commented May 11, 2019

steils commented May 17, 2019

mm1ke commented May 18, 2019

dev-libs/bglibs: EAPI7, update ebuild #11794

dev-libs/bglibs: EAPI7, update ebuild #11794

Conversation

mm1ke commented Apr 22, 2019 • edited

gentoo-bot commented Apr 22, 2019

Copyright policy change

Pull Request assignment

Linked bugs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mm1ke commented Apr 23, 2019

mm1ke commented May 5, 2019

robbat2 commented May 6, 2019

steils left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mm1ke commented May 11, 2019

gentoo-repo-qa-bot commented May 11, 2019

Pull request CI report

steils commented May 17, 2019

mm1ke commented May 18, 2019

mm1ke commented Apr 22, 2019 •

edited