-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take over (proxy) maintenance of x11-terms/aterm, make it build with glibc-2.30 #15345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
STREAMS were never supported in Linux, and have been removed from glibc-2.30. This causes aterm to no longer build. The included patch fixes the build by making the code follow the old paths, on the assumption that the ioctls never did anything to begin with. Practical testing with this patch has not revealed any obvious issues. Bug: https://bugs.gentoo.org/691756 Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
It now builds with glibc-2.30, so no reason to remove. Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Pull Request assignmentSubmitter: @imirkin x11-terms/aterm: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 691756 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
There is at least one affected package with no maintainer. Review it if you can.
assigned
PR successfully assigned to the package maintainer(s).
bug linked
Bug/Closes found in footer, and cross-linked with the PR.
labels
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assigned
PR successfully assigned to the package maintainer(s).
bug linked
Bug/Closes found in footer, and cross-linked with the PR.
maintainer-needed
There is at least one affected package with no maintainer. Review it if you can.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first proxy maintenance submission, so please let me know if I've missed any steps.