gui-apps/waybar: update to latest version 0.9.3 #17099

JonasToth · 2020-08-12T14:34:53Z

The 'date' library is voted into C++20 and Howard Hinnants
implementation serves as a free standing library and foundation for the
standardized library.

Additionally, the package waybar, that requires date, is bumped to 0.9.3.

Bug: https://bugs.gentoo.org/712236
Package-Manager: Portage-3.0.2, Repoman-2.3.23

gentoo-bot · 2020-08-12T14:36:12Z

Pull Request assignment

Submitter: @JonasToth
Areas affected: ebuilds
Packages affected: dev-libs/date

dev-libs/date: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 712236

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2020-08-12T15:51:35Z

Pull request CI report

Report generated at: 2020-08-12 15:51 UTC
Newest commit scanned: 9d641f0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7c9e09097e/output.html

gentoo-repo-qa-bot · 2020-08-12T16:11:31Z

Pull request CI report

Report generated at: 2020-08-12 16:11 UTC
Newest commit scanned: 622a0be
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4c9960893a/output.html

dev-libs/date/date-3.0.0.ebuild

dev-libs/date/date-9999.ebuild

gui-apps/waybar/waybar-0.9.3.ebuild

gentoo-repo-qa-bot · 2020-08-12T17:26:35Z

Pull request CI report

Report generated at: 2020-08-12 17:26 UTC
Newest commit scanned: 01084b8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b37f991560/output.html

dev-libs/date/date-3.0.0.ebuild

dev-libs/date/files/date-3.0.0-c-locale-export.patch

gui-apps/waybar/waybar-0.9.3.ebuild

gentoo-repo-qa-bot · 2020-09-05T11:36:51Z

Pull request CI report

Report generated at: 2020-09-05 11:36 UTC
Newest commit scanned: 5f781fa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e77d9e3272/output.html

gentoo-repo-qa-bot · 2020-09-05T14:15:45Z

Pull request CI report

Report generated at: 2020-09-05 14:15 UTC
Newest commit scanned: 65b32d1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4b2f79db73/output.html

thesamesam · 2020-09-09T02:54:53Z

Do tests pass for you on dev-libs/date? They fail here.

build.log
LastTest.log

JonasToth · 2020-09-09T10:58:43Z

Do tests pass for you on dev-libs/date? They fail here.

build.log
LastTest.log

The library testing requires additional steps for testing and a different build configuration. The tests work with "normal" git clone and checking, but not within emerge.

Reference on how to configure:

Currently figuring out how to make that work in the ebuild! :)

gentoo-repo-qa-bot · 2020-09-09T11:05:56Z

Pull request CI report

Report generated at: 2020-09-09 11:05 UTC
Newest commit scanned: 103e879
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e8a91fe947/output.html

dev-libs/date/date-3.0.0.ebuild

gentoo-repo-qa-bot · 2020-09-09T12:35:45Z

Pull request CI report

Report generated at: 2020-09-09 12:35 UTC
Newest commit scanned: 29f2764
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ccff05c562/output.html

The 'date' library is voted into C++20 and Howard Hinnants implementation serves as a free standing library and foundation for the standardized library. Bug: https://bugs.gentoo.org/712236 Package-Manager: Portage-3.0.2, Repoman-2.3.23 Signed-off-by: Jonas Toth <gentoo@jonas-toth.eu>

gentoo-repo-qa-bot · 2020-09-09T14:35:47Z

Pull request CI report

Report generated at: 2020-09-09 14:35 UTC
Newest commit scanned: 316549b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/52843107ec/output.html

This version bump added a new dependency on 'dev-libs/date'. Closes: https://bugs.gentoo.org/714834 Closes: https://bugs.gentoo.org/712236 Package-Manager: Portage-3.0.2, Repoman-2.3.23 Signed-off-by: Jonas Toth <gentoo@jonas-toth.eu>

gentoo-repo-qa-bot · 2020-09-09T14:55:53Z

Pull request CI report

Report generated at: 2020-09-09 14:55 UTC
Newest commit scanned: 32be2f1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2eb14beb23/output.html

thesamesam

Good work! I made some minor changes in follow-up commits (see my comments and look at the actual commits).

I'd like to praise your initiative in particular here - you've gone ahead and reported issues upstream, and worked with them to sort our test failures. Look forward to your next PR!

thesamesam · 2020-09-13T05:43:01Z

dev-libs/date/date-3.0.0.ebuild

+
+src_test() {
+	cd "${BUILD_DIR}" || die
+	ninja testit


|| die on external commands

thesamesam · 2020-09-13T06:02:30Z

gui-apps/waybar/waybar-0.9.3.ebuild

+	"
+DEPEND="
+	dev-cpp/gtkmm:3.0
+	dev-libs/jsoncpp:=


I think we're missing a dep on x11-libs/gtk+:3[wayland]. I had a compile error about gdk/gdkwayland.h not being found without it.

I've added it because it's such a simple job, but be on the look out for others.

thesamesam · 2020-09-13T06:02:46Z

gui-apps/waybar/waybar-0.9.3.ebuild

+	dev-libs/libsigc++:2
+	>=dev-libs/libfmt-5.3.0:=
+	>=dev-libs/spdlog-1.3.1:=
+	dev-libs/date


I added a subslot to date and subscribed to it here with := to be rebuilt if its ABI changes.

thesamesam · 2020-09-13T06:03:25Z

dev-libs/date/date-3.0.0.ebuild

+	# The behaviour seems very strange, but does not appear with a
+	# "valid" build type.
+	# Upstream bug: https://github.com/HowardHinnant/date/issues/604
+	mv "test/clock_cast_test/local_t.pass.cpp" "test/clock_cast_test/local_t.disabled" || ewarn "Can not deactivate test case, test failure expected"


This is definitely the right approach. You could do this in an "if use test;" conditional, but it's not needed.

It may be worth it to avoid confusing users if they're not running tests though?

JonasToth · 2020-09-13T11:46:06Z

@thesamesam Thank you very much for the review, the additional fixes and your time! :)

JonasToth force-pushed the dev-libs/date branch 2 times, most recently from 3ca089b to 9d641f0 Compare August 12, 2020 15:10

JonasToth changed the title ~~dev-libs/date: add new 'date' C++ library~~ gui-apps/waybar: update to latest version 0.9.3 Aug 12, 2020

juippis removed the no signoff One or more commits do not indicate GCO sign-off. label Aug 12, 2020

juippis reviewed Aug 12, 2020

View reviewed changes

JonasToth force-pushed the dev-libs/date branch 2 times, most recently from 3cf402e to 01084b8 Compare August 12, 2020 17:08

thesamesam reviewed Sep 4, 2020

View reviewed changes

JonasToth force-pushed the dev-libs/date branch from 01084b8 to 5f781fa Compare September 5, 2020 11:19

JonasToth force-pushed the dev-libs/date branch from 5f781fa to f3cfc63 Compare September 5, 2020 12:50

JonasToth requested review from thesamesam and juippis September 5, 2020 13:01

JonasToth force-pushed the dev-libs/date branch from f3cfc63 to 65b32d1 Compare September 5, 2020 13:27

JonasToth force-pushed the dev-libs/date branch from 65b32d1 to 103e879 Compare September 9, 2020 10:49

00-matt reviewed Sep 9, 2020

View reviewed changes

dev-libs/date/date-3.0.0.ebuild Outdated Show resolved Hide resolved

JonasToth force-pushed the dev-libs/date branch from 29f2764 to 316549b Compare September 9, 2020 14:17

gui-apps/waybar: update to version 0.9.3

32be2f1

This version bump added a new dependency on 'dev-libs/date'. Closes: https://bugs.gentoo.org/714834 Closes: https://bugs.gentoo.org/712236 Package-Manager: Portage-3.0.2, Repoman-2.3.23 Signed-off-by: Jonas Toth <gentoo@jonas-toth.eu>

JonasToth force-pushed the dev-libs/date branch from 316549b to 32be2f1 Compare September 9, 2020 14:37

gentoo-bot closed this in 221743f Sep 13, 2020

thesamesam approved these changes Sep 13, 2020

View reviewed changes

JonasToth deleted the dev-libs/date branch September 13, 2020 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gui-apps/waybar: update to latest version 0.9.3 #17099

gui-apps/waybar: update to latest version 0.9.3 #17099

JonasToth commented Aug 12, 2020 •

edited

gentoo-bot commented Aug 12, 2020

gentoo-repo-qa-bot commented Aug 12, 2020

gentoo-repo-qa-bot commented Aug 12, 2020

gentoo-repo-qa-bot commented Aug 12, 2020

gentoo-repo-qa-bot commented Sep 5, 2020

gentoo-repo-qa-bot commented Sep 5, 2020

thesamesam commented Sep 9, 2020

JonasToth commented Sep 9, 2020

gentoo-repo-qa-bot commented Sep 9, 2020

gentoo-repo-qa-bot commented Sep 9, 2020

gentoo-repo-qa-bot commented Sep 9, 2020

gentoo-repo-qa-bot commented Sep 9, 2020

thesamesam left a comment

thesamesam Sep 13, 2020

thesamesam Sep 13, 2020

thesamesam Sep 13, 2020

thesamesam Sep 13, 2020

JonasToth commented Sep 13, 2020

gui-apps/waybar: update to latest version 0.9.3 #17099

gui-apps/waybar: update to latest version 0.9.3 #17099

Conversation

JonasToth commented Aug 12, 2020 • edited

gentoo-bot commented Aug 12, 2020

Pull Request assignment

Linked bugs

New packages

Missing GCO sign-off

gentoo-repo-qa-bot commented Aug 12, 2020

Pull request CI report

gentoo-repo-qa-bot commented Aug 12, 2020

Pull request CI report

gentoo-repo-qa-bot commented Aug 12, 2020

Pull request CI report

gentoo-repo-qa-bot commented Sep 5, 2020

Pull request CI report

gentoo-repo-qa-bot commented Sep 5, 2020

Pull request CI report

thesamesam commented Sep 9, 2020

JonasToth commented Sep 9, 2020

gentoo-repo-qa-bot commented Sep 9, 2020

Pull request CI report

gentoo-repo-qa-bot commented Sep 9, 2020

Pull request CI report

gentoo-repo-qa-bot commented Sep 9, 2020

Pull request CI report

gentoo-repo-qa-bot commented Sep 9, 2020

Pull request CI report

thesamesam left a comment

Choose a reason for hiding this comment

thesamesam Sep 13, 2020

Choose a reason for hiding this comment

thesamesam Sep 13, 2020

Choose a reason for hiding this comment

thesamesam Sep 13, 2020

Choose a reason for hiding this comment

thesamesam Sep 13, 2020

Choose a reason for hiding this comment

JonasToth commented Sep 13, 2020

JonasToth commented Aug 12, 2020 •

edited