Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-crypt/tpm2-tools: Don't let configure call git, add missing dependency, fix libressl support #18721

Closed
wants to merge 6 commits into from

Conversation

salahcoronya
Copy link
Contributor

configure.ac has the follow line at the top:

AC_INIT([tpm2-tools],
[m4_esyscmd_s([git describe --tags --always --dirty])])

This causes "git" to be invoked when "configure" is run, it is used to embed the version number into the apps. Rather than depend on git, use "sed" in src_prepare to remove the 2nd part and replace it with ${PV}. Also, a missing dependency against sys-devel/autoconf-archive is added.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @salahcoronya
Areas affected: ebuilds
Packages affected: app-crypt/tpm2-tools

app-crypt/tpm2-tools: @salahcoronya, @gentoo/proxy-maint

Linked bugs

Bugs linked: 760567


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 19, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-19 03:24 UTC
Newest commit scanned: 260c29e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d9e5803ac1/output.html

Closes: https://bugs.gentoo.org/760567
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
Closes: https://bugs.gentoo.org/760567
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
@salahcoronya salahcoronya changed the title app-crypt/tpm2-tools: Don't let configure call git, add missing dependency app-crypt/tpm2-tools: Don't let configure call git, add missing dependency, fix libressl support Dec 30, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-30 23:29 UTC
Newest commit scanned: 3935467
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f770275ee7/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Gentoo is getting rid of libressl, but I guess this ships other fixes too.

@salahcoronya salahcoronya deleted the tpm2-tools branch January 21, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants