Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-crpyt/tpm2-tss: Enable libressl support #18876

Closed
wants to merge 4 commits into from
Closed

app-crpyt/tpm2-tss: Enable libressl support #18876

wants to merge 4 commits into from

Conversation

salahcoronya
Copy link
Contributor

libressl support was removed form the this package previously because libressl did not support some functions needed: tpm2-software/tpm2-tss#1235 . Now, however, this no longer seems to be a problem, and it compiles just fine with the current stable.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Dec 30, 2020
@salahcoronya salahcoronya changed the title app-crpyt/tpm2-tss: Enable libressl support app-crpyt/tpm2-tss: Enable libressl support [please reassign] Dec 30, 2020
@gentoo-bot gentoo-bot changed the title app-crpyt/tpm2-tss: Enable libressl support [please reassign] app-crpyt/tpm2-tss: Enable libressl support Dec 30, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @salahcoronya
Areas affected: ebuilds
Packages affected: app-crypt/tpm2-tss

app-crypt/tpm2-tss: @salahcoronya, @gentoo/proxy-maint

Linked bugs

Bugs linked: 762445

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Dec 30, 2020
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-30 02:59 UTC
Newest commit scanned: 6b9731e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9d219e6385/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-30 03:15 UTC
Newest commit scanned: 02378e8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fa68e0c178/output.html

@PPed72
Copy link
Contributor

PPed72 commented Dec 30, 2020

Tests do not compile (at least for 2.4.5-r1):
/bin/sh ./libtool --tag=CC --mode=link x86_64-pc-linux-gnu-gcc -I./src -I./include/tss2 -I./test/fuzz/tcti -I./src/tss2-mu -I./src/tss2-sys -I./src/tss2-esys -I./src/tss2-fapi -Wno-unused-parameter -Wno-missing-field-initializers -O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=4 -fno-lto -lcrypto -Wl,--wrap=Tss2_TctiLdr_Initialize -Wl,--wrap=Tss2_TctiLdr_Finalize -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common -flto=4 -fno-lto -o test/unit/esys-nulltcti test/unit/esys_nulltcti-esys-nulltcti.o src/tss2-esys/test_unit_esys_nulltcti-esys_context.o src/tss2-esys/test_unit_esys_nulltcti-esys_iutil.o src/tss2-esys/test_unit_esys_nulltcti-esys_crypto.o src/tss2-esys/test_unit_esys_nulltcti-esys_crypto_ossl.o -lcmocka src/tss2-mu/libtss2-mu.la src/tss2-tcti/libtss2-tctildr.la src/tss2-tcti/libtss2-tcti-device.la src/tss2-sys/libtss2-sys.la src/tss2-esys/libtss2-esys.la src/tss2-rc/libtss2-rc.la src/tss2-fapi/libtss2-fapi.la -lcrypto libutil.la -ldl
src/tss2-esys/.libs/libtss2-esys.so: error: undefined reference to 'RAND_OpenSSL'
src/tss2-esys/.libs/libtss2-esys.so: error: undefined reference to 'EC_POINT_get_affine_coordinates'
src/tss2-esys/.libs/libtss2-esys.so: error: undefined reference to 'EC_POINT_set_affine_coordinates'
collect2: error: ld returned 1 exit status
distcc[1981] ERROR: compile (null) on localhost failed
make[1]: *** [Makefile:12278: test/unit/tctildr-dl] Error 1
make[1]: *** Waiting for unfinished jobs....

@PPed72
Copy link
Contributor

PPed72 commented Dec 30, 2020

Same for 3.0.3-r1...

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-30 21:29 UTC
Newest commit scanned: 92b7ae3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/00000e4a66/output.html

@salahcoronya
app-crypt/tpm2-tss: Add libressl support
a496b6d 
Closes: https://bugs.gentoo.org/762445
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
@salahcoronya
app-crypt/tpm2-tss: Add libressl support
9ab594b 
Closes: https://bugs.gentoo.org/762445
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
@salahcoronya
app-crypt/tpm2-tss: Remove old
bc7d4e7 
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
@salahcoronya
app-crypt/tpm2-tss: Remove old
d8d6b9b 
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
@salahcoronya
Copy link
Contributor Author

Ok, after more compile testing I finally got that it compiles the tests, as well as tpm2-tools. tpm2-tools needs a patch which can be found in a different PR of mine: #18721 . Of course this may be pointless given the current discussion on the mailing list: https://archives.gentoo.org/gentoo-dev/message/9a92320c599e63c8c18b2ed29050f22f

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-12-30 23:39 UTC
Newest commit scanned: d8d6b9b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/903ada67a8/output.html

juippis
juippis reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think we want to introduce libressl support anymore. Fixing it is different thing.

@salahcoronya
Copy link
Contributor Author

Yeah, I'll go ahead and close this and mark the corresponding bug WONTFIX, but include the patches in the bug so if its desired to submit them upstream or in an overlay they will be available.

@salahcoronya salahcoronya deleted the tpm2-tss branch January 21, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@salahcoronya @gentoo-bot @gentoo-repo-qa-bot @PPed72 @juippis