net-print/gutenprint: bump to 5.3.4 #20715

ghost · 2021-05-07T08:56:48Z

This release drops 2 patches, these named files/5.3.3-*

Closes: https://bugs.gentoo.org/674078
^^ does not appear on 5.3.4 with -j64 ^^
Closes: https://bugs.gentoo.org/788880

Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Marco Scardovi marco@scardovi.com

gentoo-repo-qa-bot · 2021-05-07T09:09:05Z

Pull request CI report

Report generated at: 2021-05-07 09:09 UTC
Newest commit scanned: 179d81a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ea515e25f8/output.html

net-print/gutenprint/gutenprint-5.3.4.ebuild

ghost · 2021-05-07T12:04:48Z

@juippis thanks for your suggestions :) fixed

juippis · 2021-05-07T12:11:50Z

/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-115850.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120410.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120618.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120551.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120804.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120732.log:./configure: line 12515: dlopen: command not found

gentoo-repo-qa-bot · 2021-05-07T12:14:03Z

Pull request CI report

Report generated at: 2021-05-07 12:14 UTC
Newest commit scanned: dc5fa9f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/83a11a2bed/output.html

ghost · 2021-05-07T12:14:29Z

/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-115850.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120410.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120618.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120551.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120804.log:./configure: line 12515: dlopen: command not found
/var/tmp/portage/vbslogs/build/net-print/gutenprint-5.3.4:20210507-120732.log:./configure: line 12515: dlopen: command not found

EDIT

I see it as well during checking phase, but package build correctly

gentoo-repo-qa-bot · 2021-05-07T14:09:08Z

Pull request CI report

Report generated at: 2021-05-07 14:09 UTC
Newest commit scanned: eb9e567
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a5eebb24b7/output.html

juippis

I can't merge since I'm not part of the team. I assume you have some sort of deal with someone from that project? If not, please open a bug and link this PR to that bug, then ping me 2-4 weeks after opening the bug and I can merge.
https://devmanual.gentoo.org/general-concepts/package-maintainers/index.html#maintainer-authority

net-print/gutenprint/gutenprint-5.3.4.ebuild

ghost · 2021-05-08T09:00:54Z

I can't merge since I'm not part of the team. I assume you have some sort of deal with someone from that project? If not, please open a bug and link this PR to that bug, then ping me 2-4 weeks after opening the bug and I can merge.
https://devmanual.gentoo.org/general-concepts/package-maintainers/index.html#maintainer-authority

I had left a message to @mattst88 on gentoo-dev but not sure if he see it

gentoo-repo-qa-bot · 2021-05-08T09:19:18Z

Pull request CI report

Report generated at: 2021-05-08 09:19 UTC
Newest commit scanned: ba2d69f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e2f7f15347/output.html

This release drops 2 patches, these named files/5.3.3-* Closes: https://bugs.gentoo.org/674078 ^^ does not appear on 5.3.4 with -j64 ^^ Closes: https://bugs.gentoo.org/788880 Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>

gentoo-repo-qa-bot · 2021-05-08T09:29:17Z

Pull request CI report

Report generated at: 2021-05-08 09:29 UTC
Newest commit scanned: 05203f6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8740e355eb/output.html

gentoo-bot · 2021-05-08T09:32:06Z

Pull Request assignment

Submitter: @scardracs
Areas affected: ebuilds
Packages affected: net-print/gutenprint

net-print/gutenprint: @gentoo/printing

Linked bugs

Bugs linked: 788880, 674078

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-05-08T09:49:31Z

Pull request CI report

Report generated at: 2021-05-08 09:49 UTC
Newest commit scanned: dae59aa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f9e64439ab/output.html

gentoo-repo-qa-bot · 2021-06-08T17:34:13Z

Pull request CI report

Report generated at: 2021-06-08 17:34 UTC
Newest commit scanned: ba7eb4a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5dc01b107f/output.html

juippis

If I emerge this with
USE flags: 'cups -gimp gtk nls ppds readline static-libs'
it ends up in an error:

rmdir: failed to remove '/var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/share': Directory not empty
make[5]: [Makefile:2211: install-data-hook] Error 1 (ignored)
rmdir `dirname /var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups`
rmdir `dirname /var/tmp/portage/net-print/gutenprint-5.3.4/image/etc/cups`
libtool: install: /usr/lib/portage/python3.9/ebuild-helpers/xattr/install -c gutenprint.5.3 /var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/driver
rmdir: failed to remove '/var/tmp/portage/net-print/gutenprint-5.3.4/image/etc': Directory not empty
make[5]: [Makefile:2213: install-data-hook] Error 1 (ignored)
make[5]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src/cups'
/usr/bin/install: cannot create regular file '/var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/driver': No such file or directory
install-xattr: failed to stat /var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/driver: No such file or directory
make[4]: *** [Makefile:971: install-cupsexec_driverPROGRAMS] Error 1
make[4]: *** Waiting for unfinished jobs....
libtool:   error: '/var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/filter' is not a directory
make[4]: *** [Makefile:1020: install-cupsexec_filterPROGRAMS] Error 1
make[4]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src/cups'
make[3]: *** [Makefile:1930: install-am] Error 2
make[3]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src/cups'
make[2]: *** [Makefile:481: install-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src'
make[1]: *** [Makefile:597: install-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4'
make: *** [Makefile:901: install] Error 2
 * ERROR: net-print/gutenprint-5.3.4::gentoo failed (install phase):
 *   emake failed
 *

Can you reproduce?

net-print/gutenprint/gutenprint-5.3.4.ebuild

ghost · 2021-06-09T08:16:46Z

If I emerge this with
USE flags: 'cups -gimp gtk nls ppds readline static-libs'
it ends up in an error:

rmdir: failed to remove '/var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/share': Directory not empty
make[5]: [Makefile:2211: install-data-hook] Error 1 (ignored)
rmdir `dirname /var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups`
rmdir `dirname /var/tmp/portage/net-print/gutenprint-5.3.4/image/etc/cups`
libtool: install: /usr/lib/portage/python3.9/ebuild-helpers/xattr/install -c gutenprint.5.3 /var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/driver
rmdir: failed to remove '/var/tmp/portage/net-print/gutenprint-5.3.4/image/etc': Directory not empty
make[5]: [Makefile:2213: install-data-hook] Error 1 (ignored)
make[5]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src/cups'
/usr/bin/install: cannot create regular file '/var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/driver': No such file or directory
install-xattr: failed to stat /var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/driver: No such file or directory
make[4]: *** [Makefile:971: install-cupsexec_driverPROGRAMS] Error 1
make[4]: *** Waiting for unfinished jobs....
libtool:   error: '/var/tmp/portage/net-print/gutenprint-5.3.4/image/usr/libexec/cups/filter' is not a directory
make[4]: *** [Makefile:1020: install-cupsexec_filterPROGRAMS] Error 1
make[4]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src/cups'
make[3]: *** [Makefile:1930: install-am] Error 2
make[3]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src/cups'
make[2]: *** [Makefile:481: install-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4/src'
make[1]: *** [Makefile:597: install-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-print/gutenprint-5.3.4/work/gutenprint-5.3.4'
make: *** [Makefile:901: install] Error 2
 * ERROR: net-print/gutenprint-5.3.4::gentoo failed (install phase):
 *   emake failed
 *

Can you reproduce?

I can't reproduce it

Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>

gentoo-repo-qa-bot · 2021-06-09T08:36:17Z

Pull request CI report

Report generated at: 2021-06-09 08:36 UTC
Newest commit scanned: 8c04d89
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f95c1ee7e5/output.html

juippis · 2021-06-10T06:04:34Z

net-print/gutenprint/gutenprint-5.3.4.ebuild

+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86"
+
+IUSE="cups gimp gtk nls readline ppds static-libs"
+RESTRICT="test"


Why has this been done?

That's an old thing: I haven't touched it because I don't know why it is here

That's why when updating ebuilds such as this, always try to remove this restriction and test the ebuild. If it doesn't work, add a comment above the RESTRICT what exactly fails, and preferably either a link to a gentoo bug, or upstream issue about it. Test phase is pretty much the only reliable way for us to be sure the program works like upstream intends to.

juippis · 2021-06-10T06:04:47Z

net-print/gutenprint/gutenprint-5.3.4.ebuild

+
+src_configure() {
+	local myeconfargs=(
+		--enable-test


... yet this is enabled? What's the interaction here?

juippis · 2021-06-10T06:05:47Z

net-print/gutenprint/gutenprint-5.3.4.ebuild

+BDEPEND="
+	${RDEPEND}
+	nls? ( virtual/libintl )


Should this be DEPEND instead? Is virtual/libintl needed in DEPEND too?
BDEPEND="${RDEPEND}" is almost always wrong though.

Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>

gentoo-repo-qa-bot · 2021-06-10T08:26:14Z

Pull request CI report

Report generated at: 2021-06-10 08:26 UTC
Newest commit scanned: 916fc5a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b1a67c5583/output.html

juippis · 2021-06-10T10:50:03Z

net-print/gutenprint/gutenprint-5.3.4.ebuild

+RDEPEND="
+	dev-lang/perl
+	cups? ( >=net-print/cups-1.1.14 )
+	gimp? (
+		media-gfx/gimp:0/2
+		x11-libs/gtk+:2
+	)
+	gtk? ( x11-libs/gtk+:2 )
+	readline? ( sys-libs/readline:0= )


These are most likely needed in DEPEND too, I'll add it after merging.

juippis · 2021-06-10T10:51:18Z

net-print/gutenprint/gutenprint-5.3.4.ebuild

+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86"
+
+IUSE="cups gimp gtk nls readline ppds static-libs"
+RESTRICT="test"


That's why when updating ebuilds such as this, always try to remove this restriction and test the ebuild. If it doesn't work, add a comment above the RESTRICT what exactly fails, and preferably either a link to a gentoo bug, or upstream issue about it. Test phase is pretty much the only reliable way for us to be sure the program works like upstream intends to.

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 7, 2021

juippis reviewed May 7, 2021

View reviewed changes

ghost requested a review from juippis May 7, 2021 14:02

juippis approved these changes May 8, 2021

View reviewed changes

net-print/gutenprint/gutenprint-5.3.4.ebuild Outdated Show resolved Hide resolved

ghost changed the title ~~net-print/gutenprint: bump to 5.3.4~~ net-print/gutenprint: bump to 5.3.4 [please reassing] May 8, 2021

ghost changed the title ~~net-print/gutenprint: bump to 5.3.4 [please reassing]~~ net-print/gutenprint: bump to 5.3.4 [please reassign] May 8, 2021

gentoo-bot changed the title ~~net-print/gutenprint: bump to 5.3.4 [please reassign]~~ net-print/gutenprint: bump to 5.3.4 May 8, 2021

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 8, 2021

ghost changed the title ~~net-print/gutenprint: bump to 5.3.4~~ net-print/gutenprint: bump to 5.3.4 [please reassing] May 8, 2021

ghost changed the title ~~net-print/gutenprint: bump to 5.3.4 [please reassing]~~ net-print/gutenprint: bump to 5.3.4 [please reassign] May 8, 2021

gentoo-bot changed the title ~~net-print/gutenprint: bump to 5.3.4 [please reassign]~~ net-print/gutenprint: bump to 5.3.4 May 8, 2021

ghost closed this May 12, 2021

ghost deleted the gutenprint branch May 12, 2021 13:37

ghost restored the gutenprint branch May 12, 2021 13:38

ghost reopened this May 12, 2021

juippis reviewed Jun 9, 2021

View reviewed changes

net-print/gutenprint/gutenprint-5.3.4.ebuild Outdated Show resolved Hide resolved

net-print/gutenprint: mv nls to BDEPEND

8c04d89

Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>

juippis reviewed Jun 10, 2021

View reviewed changes

net-print/gutenprint: remove duplicated bdepend

916fc5a

Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Marco Scardovi <marco@scardovi.com>

juippis approved these changes Jun 10, 2021

View reviewed changes

gentoo-bot closed this in 61cd037 Jun 10, 2021

ghost deleted the gutenprint branch June 10, 2021 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net-print/gutenprint: bump to 5.3.4 #20715

net-print/gutenprint: bump to 5.3.4 #20715

ghost commented May 7, 2021 •

edited by ghost

Loading

gentoo-repo-qa-bot commented May 7, 2021

ghost commented May 7, 2021

juippis commented May 7, 2021

gentoo-repo-qa-bot commented May 7, 2021

ghost commented May 7, 2021 •

edited by ghost

Loading

gentoo-repo-qa-bot commented May 7, 2021

juippis left a comment

ghost commented May 8, 2021

gentoo-repo-qa-bot commented May 8, 2021

gentoo-repo-qa-bot commented May 8, 2021

gentoo-bot commented May 8, 2021

gentoo-repo-qa-bot commented May 8, 2021

gentoo-repo-qa-bot commented Jun 8, 2021

juippis left a comment

ghost commented Jun 9, 2021

gentoo-repo-qa-bot commented Jun 9, 2021

juippis Jun 10, 2021

ghost Jun 10, 2021

juippis Jun 10, 2021

juippis Jun 10, 2021

juippis Jun 10, 2021

gentoo-repo-qa-bot commented Jun 10, 2021

juippis Jun 10, 2021

juippis Jun 10, 2021

net-print/gutenprint: bump to 5.3.4 #20715

net-print/gutenprint: bump to 5.3.4 #20715

Conversation

ghost commented May 7, 2021 • edited by ghost Loading

gentoo-repo-qa-bot commented May 7, 2021

Pull request CI report

ghost commented May 7, 2021

juippis commented May 7, 2021

gentoo-repo-qa-bot commented May 7, 2021

Pull request CI report

ghost commented May 7, 2021 • edited by ghost Loading

gentoo-repo-qa-bot commented May 7, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

ghost commented May 8, 2021

gentoo-repo-qa-bot commented May 8, 2021

Pull request CI report

gentoo-repo-qa-bot commented May 8, 2021

Pull request CI report

gentoo-bot commented May 8, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented May 8, 2021

Pull request CI report

gentoo-repo-qa-bot commented Jun 8, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

ghost commented Jun 9, 2021

gentoo-repo-qa-bot commented Jun 9, 2021

Pull request CI report

juippis Jun 10, 2021

Choose a reason for hiding this comment

ghost Jun 10, 2021

Choose a reason for hiding this comment

juippis Jun 10, 2021

Choose a reason for hiding this comment

juippis Jun 10, 2021

Choose a reason for hiding this comment

juippis Jun 10, 2021

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Jun 10, 2021

Pull request CI report

juippis Jun 10, 2021

Choose a reason for hiding this comment

juippis Jun 10, 2021

Choose a reason for hiding this comment

ghost commented May 7, 2021 •

edited by ghost

Loading

ghost commented May 7, 2021 •

edited by ghost

Loading