dev-java/pdfbox: additional TEST_EXCLUDES for jdk-17 #21564

vaukai · 2021-07-08T08:13:30Z

No description provided.

gentoo-bot · 2021-07-08T08:16:12Z

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds, other files
Packages affected: dev-java/bcmail, dev-java/bcpg, dev-java/bcpkix, dev-java/bcprov, dev-java/bcutil...

dev-java/bcmail: @gentoo/java
dev-java/bcpg: @gentoo/java
dev-java/bcpkix: @gentoo/java
dev-java/bcprov: @gentoo/java
dev-java/bcutil: @gentoo/proxy-maint (new package)
dev-java/fontbox: @gentoo/java
dev-java/jai-imageio-core: @gentoo/proxy-maint (new package)
dev-java/jai-imageio-jpeg2000: @gentoo/proxy-maint (new package)
dev-java/jakarta-activation: @gentoo/proxy-maint (new package)
dev-java/java-diff-utils: @gentoo/proxy-maint (new package)
dev-java/jbig2-imageio: @gentoo/proxy-maint (new package)
dev-java/pdfbox: @gentoo/java

Linked bugs

Bugs linked: 797634, 736633, 738836, 640118, 760729

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-07-09T20:14:27Z

Pull request CI report

Report generated at: 2021-07-09 20:14 UTC
Newest commit scanned: bc618d3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b61b706ac2/output.html

vaukai · 2021-07-22T18:23:53Z

All tests pass for:

dev-java/fontbox: bump to 2.0.24
dev-java/jbig2-imageio: new package
dev-java/jai-imageio-core: new package
dev-java/jai-imageio-jpeg2000: new package

Has no tests

dev-java/java-diff-utils: new package

Still to resolve: (Tests run: 600, Failures: 17)

dev-java/pdfbox: bump to 2.0.24 - CVE-2021-31812

gentoo-repo-qa-bot · 2021-07-22T18:35:34Z

Pull request CI report

Report generated at: 2021-07-22 18:35 UTC
Newest commit scanned: 4b8ba5c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ecf9b8f5d4/output.html

fordfrog · 2021-07-23T05:51:31Z

@vaukai thanks for the summary, that was really helpful. merged everything except pdfbox. thanks!

gentoo-repo-qa-bot · 2021-07-23T06:09:39Z

Pull request CI report

Report generated at: 2021-07-23 06:09 UTC
Newest commit scanned: df7a0bc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e619616750/output.html

gentoo-repo-qa-bot · 2021-07-23T19:04:39Z

Pull request CI report

Report generated at: 2021-07-23 19:04 UTC
Newest commit scanned: 60d91ec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/caf727c6d5/output.html

gentoo-repo-qa-bot · 2021-07-23T20:34:40Z

Pull request CI report

Report generated at: 2021-07-23 20:34 UTC
Newest commit scanned: 3b58fc5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8357a0e07e/output.html

gentoo-repo-qa-bot · 2021-07-24T08:59:47Z

Pull request CI report

Report generated at: 2021-07-24 08:59 UTC
Newest commit scanned: d339b32
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/58fc687d51/output.html

vaukai · 2021-07-24T16:58:55Z

JAVA_TEST_EXCLUDES=(
    # excluded according to upstream
    # https://github.com/apache/pdfbox/blob/8876e8e1a0adbf619cef4638cc3cea073e3ca484/pdfbox/pom.xml#L123
    "org.apache.pdfbox.rendering.TestPDFToImage"

    # junit.framework.AssertionFailedError: Cannot instantiate test case: testIsSetDirect (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testAccept (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testGetCOSObject (java.lang.InstantiationException
    "org.apache.pdfbox.cos.TestCOSBase"

    # junit.framework.AssertionFailedError: Cannot instantiate test case: testFloatValue (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testGet (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testInvalidNumber (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testLongValue (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testIntValue (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testLargeNumber (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testDoubleValue (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testIsSetDirect (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testAccept (java.lang.InstantiationException
    # junit.framework.AssertionFailedError: Cannot instantiate test case: testGetCOSObject (java.lang.InstantiationException
    "org.apache.pdfbox.cos.TestCOSNumber"   # Tests run: 10,  Failures: 10

    # following tests need network access, can pass when run by regular user
    "org.apache.pdfbox.pdmodel.font.PDFontTest" # Tests run: 9,  Failures: 2
    "org.apache.pdfbox.pdmodel.interactive.form.PDAcroFormFlattenTest"  # Tests run: 11,  Failures: 11
    "org.apache.pdfbox.pdmodel.interactive.form.PDAcroFormFromAnnotsTest"   # Tests run: 7,  Failures: 7
    "org.apache.pdfbox.pdmodel.interactive.form.PDAcroFormGenerateAppearancesTest"  # Tests run: 3,  Failures: 3
    "org.apache.pdfbox.pdmodel.interactive.form.PDAcroFormTest" # Tests run: 11,  Failures: 4
    "org.apache.pdfbox.pdmodel.interactive.form.PDFieldTreeTest"    # Tests run: 1,  Failures: 1
    "org.apache.pdfbox.pdmodel.interactive.form.TestRadioButtons"   # Tests run: 9,  Failures: 8
)

Edit:
For the missing launcher it seems to need pdfbox-tools, WIP, needs picocli.

gentoo-repo-qa-bot · 2021-07-24T17:09:44Z

Pull request CI report

Report generated at: 2021-07-24 17:09 UTC
Newest commit scanned: 410b5c4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d1162c646f/output.html

gentoo-repo-qa-bot · 2021-07-24T19:39:45Z

Pull request CI report

Report generated at: 2021-07-24 19:39 UTC
Newest commit scanned: 02369e6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6155767865/output.html

vaukai · 2021-07-25T15:59:23Z

pdfbox-debugger added which is needed for pdfbox-tools

vaukai · 2021-08-02T13:21:29Z

Some network tests enabled (would 31 of 584 tests justify this setting?)

PROPERTIES="test_network"
RESTRICT="test"

gentoo-repo-qa-bot · 2021-08-02T13:24:48Z

Pull request CI report

Report generated at: 2021-08-02 13:24 UTC
Newest commit scanned: b8cf747
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/dd08cb1a91/output.html

vaukai · 2021-08-02T17:42:42Z

@vaukai dev-java/picocli merged, thanks! wrt pdfbox, i'd like to review the failing tests before merge.

After setting PROPERTIES="test_network" the only test failures left are

public void testPDFBox3826() throws IOException, URISyntaxException

from "org.apache.pdfbox.pdmodel.font.PDFontTest"
and those strange 10 failures from

"org.apache.pdfbox.cos.TestCOSBase"
"org.apache.pdfbox.cos.TestCOSNumber"

gentoo-repo-qa-bot · 2021-08-02T17:54:42Z

Pull request CI report

Report generated at: 2021-08-02 17:54 UTC
Newest commit scanned: bb3b9c7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/68fb8b8845/output.html

gentoo-repo-qa-bot · 2021-10-30T19:02:03Z

Pull request CI report

Report generated at: 2021-10-30 19:02 UTC
Newest commit scanned: 39d2164
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/eaf56be5ca/output.html

gentoo-repo-qa-bot · 2021-10-30T19:17:09Z

Pull request CI report

Report generated at: 2021-10-30 19:17 UTC
Newest commit scanned: 85d8fd0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/09907ddff6/output.html

fordfrog · 2021-10-31T06:23:25Z

dev-java/pdfbox/pdfbox-2.0.24.ebuild

+		"target/imgs" || die
+
+	java-pkg-simple_src_test
+	rm -r target/test-classes || die # avaoid to run previous tests again


a typo in the comment

fordfrog · 2021-10-31T06:24:00Z

dev-java/pdfbox/files/2.0.24-tests-ignore.patch

+      * @throws IOException
+      * @throws URISyntaxException
+      */
+    @Ignore


please add a comment why it needs to be ignored

gentoo-repo-qa-bot · 2021-10-31T08:27:01Z

Pull request CI report

Report generated at: 2021-10-31 08:27 UTC
Newest commit scanned: b1cf18d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1f726fe3c7/output.html

gentoo-repo-qa-bot · 2021-11-09T18:52:18Z

Pull request CI report

Report generated at: 2021-11-09 18:52 UTC
Newest commit scanned: dd51f9a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ec370207ea/output.html

vaukai · 2021-11-14T10:38:09Z

Excluding one more test only for jdk-17 where it seems to want a newer mockito.

Time: 54.081
There was 1 failure:
1) testIsEmbeddingPermittedMultipleVersions(org.apache.pdfbox.pdmodel.font.TestFontEmbedding)
java.lang.ExceptionInInitializerError
        at org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167)
        at org.mockito.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
        at org.mockito.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:217)
        at org.mockito.cglib.core.KeyFactory$Generator.create(KeyFactory.java:145)
        at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:117)
        at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:109)
        at org.mockito.cglib.core.KeyFactory.create(KeyFactory.java:105)
        at org.mockito.cglib.proxy.Enhancer.<clinit>(Enhancer.java:71)
        at org.mockito.internal.creation.jmock.ClassImposterizer.createProxyClass(ClassImposterizer.java:85)
        at org.mockito.internal.creation.jmock.ClassImposterizer.imposterise(ClassImposterizer.java:62)
        at org.mockito.internal.creation.jmock.ClassImposterizer.imposterise(ClassImposterizer.java:56)
        at org.mockito.internal.creation.CglibMockMaker.createMock(CglibMockMaker.java:23)
        at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:26)
        at org.mockito.internal.MockitoCore.mock(MockitoCore.java:51)
        at org.mockito.Mockito.mock(Mockito.java:1243)
        at org.mockito.Mockito.mock(Mockito.java:1120)
        at org.apache.pdfbox.pdmodel.font.TestFontEmbedding.testIsEmbeddingPermittedMultipleVersions(TestFontEmbedding.java:350)
        ... 25 trimmed
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @4dc690>
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
        at java.base/java.lang.reflect.Method.checkCanSetAccessible(Method.java:199)
        at java.base/java.lang.reflect.Method.setAccessible(Method.java:193)
        at org.mockito.cglib.core.ReflectUtils$2.run(ReflectUtils.java:57)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
        at org.mockito.cglib.core.ReflectUtils.<clinit>(ReflectUtils.java:47)
        ... 43 more

FAILURES!!!
Tests run: 586,  Failures: 1

gentoo-repo-qa-bot · 2021-11-14T10:47:19Z

Pull request CI report

Report generated at: 2021-11-14 10:47 UTC
Newest commit scanned: 15a8514
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0acdda0d3d/output.html

gentoo-repo-qa-bot · 2021-11-14T11:25:14Z

Pull request CI report

Report generated at: 2021-11-14 11:25 UTC
Newest commit scanned: d65da9f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c48e681c39/output.html

fordfrog · 2021-11-15T07:20:00Z

what is the status here?

vaukai · 2021-11-15T08:00:55Z

what is the status here?

From my point of view it's ready to merge except you find additional test failures that didn't occur here.

The JAVA_TEST_EXCLUDES are either excluded upstream
or just warnings like »1) warning(junit.framework.TestSuite$1)«
The test marked @ignore via patch I'd like to keep for later (no other idea how to deal with it).

fordfrog · 2021-11-16T08:09:26Z

dev-java/pdfbox/pdfbox-2.0.24.ebuild

+IUSE="+tools"
+
+PROPERTIES="test_network"
+RESTRICT="test"


shouldn't this be dropped? i got the impression that the tests are working as you either fixed the tests or excluded them. or did i get it wrong?

Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>

gentoo-repo-qa-bot · 2021-11-16T09:55:32Z

Pull request CI report

Report generated at: 2021-11-16 09:55 UTC
Newest commit scanned: 22ee8d6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c08da78b1c/output.html

fordfrog · 2021-11-16T11:38:50Z

@vaukai thanks! :-)

gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. security PR that needs to be merged promptly as it addresses security issues labels Jul 8, 2021

vaukai force-pushed the pdfbox branch from 358a53c to bc618d3 Compare July 9, 2021 19:56

vaukai changed the title ~~dev-java/fontbox: bump to 2.0.24 | dev-java/pdfbox: bump to 2.0.24~~ dev-java/fontbox: bump to 2.0.24 | dev-java/pdfbox: bump to 2.0.24 | BC_SLOT="1.45" removal Jul 21, 2021

vaukai marked this pull request as draft July 21, 2021 15:22

vaukai force-pushed the pdfbox branch from bc618d3 to 4b8ba5c Compare July 22, 2021 18:23

vaukai force-pushed the pdfbox branch from 4b8ba5c to df7a0bc Compare July 23, 2021 05:56

vaukai changed the title ~~dev-java/fontbox: bump to 2.0.24 | dev-java/pdfbox: bump to 2.0.24 | BC_SLOT="1.45" removal~~ dev-java/pdfbox: bump to 2.0.24 | BC_SLOT="1.45" removal Jul 23, 2021

vaukai force-pushed the pdfbox branch from df7a0bc to 60d91ec Compare July 23, 2021 18:54

vaukai force-pushed the pdfbox branch from 60d91ec to 3b58fc5 Compare July 23, 2021 20:23

vaukai force-pushed the pdfbox branch from 3b58fc5 to d339b32 Compare July 24, 2021 08:43

vaukai force-pushed the pdfbox branch from d339b32 to 410b5c4 Compare July 24, 2021 16:58

vaukai marked this pull request as ready for review July 24, 2021 17:01

vaukai force-pushed the pdfbox branch from 410b5c4 to 02369e6 Compare July 24, 2021 18:46

vaukai force-pushed the pdfbox branch from 02369e6 to 8a57794 Compare July 25, 2021 15:51

vaukai force-pushed the pdfbox branch from 33ec55f to b8cf747 Compare August 2, 2021 13:15

vaukai force-pushed the pdfbox branch from b8cf747 to bb3b9c7 Compare August 2, 2021 17:26

vaukai force-pushed the pdfbox branch from 39d2164 to 85d8fd0 Compare October 30, 2021 18:53

fordfrog reviewed Oct 31, 2021

View reviewed changes

vaukai force-pushed the pdfbox branch from 85d8fd0 to b1cf18d Compare October 31, 2021 08:14

vaukai force-pushed the pdfbox branch from b1cf18d to dd51f9a Compare November 9, 2021 18:37

vaukai force-pushed the pdfbox branch from 37dc7bf to 15a8514 Compare November 14, 2021 10:31

vaukai force-pushed the pdfbox branch from 15a8514 to d65da9f Compare November 14, 2021 11:10

fordfrog reviewed Nov 16, 2021

View reviewed changes

dev-java/pdfbox: additional TEST_EXCLUDES for jdk-17

22ee8d6

Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>

vaukai force-pushed the pdfbox branch from d65da9f to 22ee8d6 Compare November 16, 2021 09:42

vaukai changed the title ~~dev-java/pdfbox: bump to 2.0.24 | BC_SLOT="1.45" removal~~ dev-java/pdfbox: additional TEST_EXCLUDES for jdk-17 Nov 16, 2021

gentoo-bot closed this in 9b09e62 Nov 16, 2021

vaukai deleted the pdfbox branch November 16, 2021 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-java/pdfbox: additional TEST_EXCLUDES for jdk-17 #21564

dev-java/pdfbox: additional TEST_EXCLUDES for jdk-17 #21564

vaukai commented Jul 8, 2021

gentoo-bot commented Jul 8, 2021

gentoo-repo-qa-bot commented Jul 9, 2021

vaukai commented Jul 22, 2021

gentoo-repo-qa-bot commented Jul 22, 2021

fordfrog commented Jul 23, 2021

gentoo-repo-qa-bot commented Jul 23, 2021

gentoo-repo-qa-bot commented Jul 23, 2021

gentoo-repo-qa-bot commented Jul 23, 2021

gentoo-repo-qa-bot commented Jul 24, 2021

vaukai commented Jul 24, 2021 •

edited

Loading

gentoo-repo-qa-bot commented Jul 24, 2021

gentoo-repo-qa-bot commented Jul 24, 2021

vaukai commented Jul 25, 2021

vaukai commented Aug 2, 2021

gentoo-repo-qa-bot commented Aug 2, 2021

vaukai commented Aug 2, 2021

gentoo-repo-qa-bot commented Aug 2, 2021

gentoo-repo-qa-bot commented Oct 30, 2021

gentoo-repo-qa-bot commented Oct 30, 2021

fordfrog Oct 31, 2021

fordfrog Oct 31, 2021

gentoo-repo-qa-bot commented Oct 31, 2021

gentoo-repo-qa-bot commented Nov 9, 2021

vaukai commented Nov 14, 2021

gentoo-repo-qa-bot commented Nov 14, 2021

gentoo-repo-qa-bot commented Nov 14, 2021

fordfrog commented Nov 15, 2021

vaukai commented Nov 15, 2021

fordfrog Nov 16, 2021

gentoo-repo-qa-bot commented Nov 16, 2021

fordfrog commented Nov 16, 2021

dev-java/pdfbox: additional TEST_EXCLUDES for jdk-17 #21564

dev-java/pdfbox: additional TEST_EXCLUDES for jdk-17 #21564

Conversation

vaukai commented Jul 8, 2021

gentoo-bot commented Jul 8, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jul 9, 2021

Pull request CI report

vaukai commented Jul 22, 2021

gentoo-repo-qa-bot commented Jul 22, 2021

Pull request CI report

fordfrog commented Jul 23, 2021

gentoo-repo-qa-bot commented Jul 23, 2021

Pull request CI report

gentoo-repo-qa-bot commented Jul 23, 2021

Pull request CI report

gentoo-repo-qa-bot commented Jul 23, 2021

Pull request CI report

gentoo-repo-qa-bot commented Jul 24, 2021

Pull request CI report

vaukai commented Jul 24, 2021 • edited Loading

gentoo-repo-qa-bot commented Jul 24, 2021

Pull request CI report

gentoo-repo-qa-bot commented Jul 24, 2021

Pull request CI report

vaukai commented Jul 25, 2021

vaukai commented Aug 2, 2021

gentoo-repo-qa-bot commented Aug 2, 2021

Pull request CI report

vaukai commented Aug 2, 2021

gentoo-repo-qa-bot commented Aug 2, 2021

Pull request CI report

gentoo-repo-qa-bot commented Oct 30, 2021

Pull request CI report

gentoo-repo-qa-bot commented Oct 30, 2021

Pull request CI report

fordfrog Oct 31, 2021

Choose a reason for hiding this comment

fordfrog Oct 31, 2021

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Oct 31, 2021

Pull request CI report

gentoo-repo-qa-bot commented Nov 9, 2021

Pull request CI report

vaukai commented Nov 14, 2021

gentoo-repo-qa-bot commented Nov 14, 2021

Pull request CI report

gentoo-repo-qa-bot commented Nov 14, 2021

Pull request CI report

fordfrog commented Nov 15, 2021

vaukai commented Nov 15, 2021

fordfrog Nov 16, 2021

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Nov 16, 2021

Pull request CI report

fordfrog commented Nov 16, 2021

vaukai commented Jul 24, 2021 •

edited

Loading