games-engines/openmw: version 0.47 #22579
Conversation
Pull Request assignmentSubmitter: @DarthGandalf games-engines/openmw: @DarthGandalf, @gentoo/proxy-maint, @gentoo/games Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2021-10-14 20:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| BDEPEND=" | ||
| virtual/pkgconfig | ||
| doc? ( | ||
| app-doc/doxygen[doc] |
There was a problem hiding this comment.
Just noticed this (was in 0.46 too), does it really need doxygen's docs to create docs?
Was this meant to be [dot]?
Which it does seem to use:
Running dot for graph 20846/20907
Technically [doc] pulls graphviz as well but not the right way to get it.
| } | ||
|
|
||
| src_configure() { | ||
| use devtools && ! use qt5 && \ |
There was a problem hiding this comment.
fwiw don't need \ after &&, lets you continue on next line either way
Although in bash scripts, to make the condition clearer I sometime do
condition && condition-with-like-really-long-line-oh-god \
&& next-thing
But that may feel more unnatural in an ebuild
| -DDESIRED_QT_VERSION=5 | ||
| -DBULLET_USE_DOUBLES=ON |
There was a problem hiding this comment.
What's up with these two? Regardless of USE=qt5 I always get:
* One or more CMake variables were not used by the project:
* BULLET_USE_DOUBLES
* DESIRED_QT_VERSION
Considering bullet_use is a newly added option in the ebuild I would've expected it to do something, not that I looked more closely at this.
There was a problem hiding this comment.
Looks like openmw removed ability to use single-precision bullet.
For a while the warning about qt was shown depending on the combination of use flags, so I was ignoring it. But now it's not used anymore at all.
Removed both.
| pkg_postrm() { | ||
| xdg_icon_cache_update | ||
| } |
There was a problem hiding this comment.
migrate to xdg.eclass and remove this?
There was a problem hiding this comment.
Done. Some people want me to move from xdg to xdg-utils, then some want me to move from xdg-utils to xdg, then it repeats :(
There was a problem hiding this comment.
The one case where it make sense to use xdg-utils directly for cache generation is if you want to make the desktop-file-utils and shared-mime-info IDEPEND optional (perhaps it's what happened?), but here it's pulling a lot of gui stuff regardless of USE (about only servers would be missing these IDEPEND) and no real reason to avoid the simplification.
I did hope EAPI-8 would just have dropped these dependencies though, it's kinda designed to work without and cache can be delayed until the dependencies get installed. EAPI-8 did drop exporting src_prepare though (may have run in cases where had to inherit xdg cmake rather than cmake xdg but that's no longer necessary).
| find "${CMAKE_BUILD_DIR}"/docs/Doxygen/html \ | ||
| -name '*.md5' -type f -delete || die | ||
| HTML_DOCS=( "${CMAKE_BUILD_DIR}"/docs/Doxygen/html/. ) |
There was a problem hiding this comment.
CMAKE_BUILD_DIR was only valid in cmake-utils, not present in cmake.eclass
Guess this been broken for a while.
find: ‘/docs/Doxygen/html’: No such file or directory
Wonder how I missed that before, pretty sure I'd have tested USE=doc, hrm... maybe got distracted.
There was a problem hiding this comment.
Yeah, I tested USE=doc before, but not for a while
| directly).\n" | ||
|
|
||
| if ! use qt5; then | ||
| local DOC_CONTENTS+="\n\n |
There was a problem hiding this comment.
Don't need local twice, it's already declared above.
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
Pull request CI reportReport generated at: 2021-10-16 11:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Alexey Sokolov alexey+gentoo@asokolov.org