Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extundelete/extundelete: support clang in extundelete/extundelete-0.2.4-r1 #24658

Closed

Conversation

dpronin
Copy link
Contributor

@dpronin dpronin commented Mar 19, 2022

patched src/extundelete.cc so that clang is not swearing on
implicit narrowing

Signed-off-by: Denis Pronin dannftk@yandex.ru

patched src/extundelete.cc so that clang is not swearing on
implicit narrowing

Signed-off-by: Denis Pronin <dannftk@yandex.ru>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @dpronin
Areas affected: ebuilds
Packages affected: sys-fs/extundelete

sys-fs/extundelete: @gentoo/base-system

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 19, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-03-19 10:56 UTC
Newest commit scanned: 3ce4c56
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c39378b493/output.html

@dpronin dpronin changed the title support clang in extundelete/extundelete-0.2.4-r1 extundelete/extundelete: support clang in extundelete/extundelete-0.2.4-r1 Mar 19, 2022
@dpronin
Copy link
Contributor Author

dpronin commented Apr 3, 2022

ping

@thesamesam
Copy link
Member

Please use pkgdev commit to get commit message format in future. I'll merge now, cheers!

priv->ret_ino = new_ino;
priv->curr_name = curr_part;
- struct dir_context ctx = {search_flags, DIRENT_FLAG_INCLUDE_REMOVED,
+ struct dir_context ctx = {static_cast<unsigned int>(search_flags), DIRENT_FLAG_INCLUDE_REMOVED,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's go for the version in https://bugs.gentoo.org/732284.

Please also use Closes: tags in commits.

Thank you!

@gentoo-bot gentoo-bot closed this in 6b1800e Apr 5, 2022
@dpronin dpronin deleted the sys-fs/extundelete/support-clang branch April 8, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants