x11-terms/gnome-terminal: fix missing W_EXITCODE define in gnome-terminal when building on musl #25872
Conversation
listout
changed the title
Pull Request assignmentSubmitter: @listout x11-terms/gnome-terminal: @gentoo/gnome Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
|
This is my first commit as a Google Summer of Code student this year. |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2022-06-13 12:16 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
listout
force-pushed
the
wexitcode_missing_gterm
branch
from
5a81f84
to
e22ce44
Compare
Pull request CI reportReport generated at: 2022-06-13 12:56 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
listout
force-pushed
the
wexitcode_missing_gterm
branch
2 times, most recently
from
7627a4e
to
af07264
Compare
Pull request CI reportReport generated at: 2022-06-13 13:26 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
listout
changed the title
| @@ -47,6 +47,9 @@ DOC_CONTENTS="To get previous working directory inherited in new opened tab, or | |||
| . /etc/profile.d/vte-2.91.sh" | |||
|
|
|||
| src_prepare() { | |||
|
|
|||
listout
force-pushed
the
wexitcode_missing_gterm
branch
2 times, most recently
from
6768907
to
c29f84c
Compare
|
@thesamesam Thanks for the feedback, made changes as asked. |
Pull request CI reportReport generated at: 2022-06-24 13:54 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-06-24 14:05 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
x11-terms/gnome-terminal/files/gnome-terminal-3.44.1-fix-missing-wexitcode.patch
Show resolved
Hide resolved
|
Will do
…On Mon, Jun 27, 2022, 1:49 AM Sam James ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
x11-terms/gnome-terminal/files/gnome-terminal-3.44.1-fix-missing-wexitcode.patch
<#25872 (comment)>:
> @@ -0,0 +1,14 @@
+--- a/src/terminal.cc
Plesse put the commentary from the commit message at the top of the patch
too, so that it's there without having to dive in commit logs.
—
Reply to this email directly, view it on GitHub
<#25872 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP4726UOX3TCHB74WMXUWETVRC3N3ANCNFSM5YT7JETQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
https://gitlab.gnome.org/GNOME/vte/-/issues/72 Someone already tried to upstream a similar patch to gnome vte that would fix this but was rejected by maintainer. More info can be found on the link above. W_EXITCODE is missing in musl thus causing gnome-terminal build to fail. This patch checks if W_EXITCODE is not defined and then defines it. Signed-off-by: brahmajit das <brahmajit.xyz@gmail.com>
listout
force-pushed
the
wexitcode_missing_gterm
branch
from
c29f84c
to
9d7814c
Compare
Pull request CI reportReport generated at: 2022-06-27 05:19 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
This should fix W_EXITCODE gnome-terminal failing to build on musl with error
'W_EXITCODE' was not declared in this scopeIdea taken from alpine linux patch found here