Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/hip: add missing BDEPEND for USE=profile #26090

Closed
wants to merge 1 commit into from

Conversation

littlewu2508
Copy link
Contributor

Also fix ld warnings by patch out unecessary ldflag added by hipcc.pl

Reference: justxi/rocm#8 (comment)
Signed-off-by: Yiyang Wu xgreenlandforwyy@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @littlewu2508
Areas affected: ebuilds
Packages affected: dev-util/hip

dev-util/hip: @gentoo/sci, @candrews, @justxi

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 27, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-27 13:29 UTC
Newest commit scanned: a22ec65
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a73f3c468d/output.html

Also fix ld warnings by patch out unecessary ldflag added by hipcc.pl

Closes: https://bugs.gentoo.org/843263
Reference: justxi/rocm#8 (comment)
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-27 13:54 UTC
Newest commit scanned: d5682a1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0884b56b1a/output.html

@heroxbd heroxbd self-requested a review June 27, 2022 14:15
@@ -65,11 +78,13 @@ src_prepare() {
sed -e "/LIBRARY DESTINATION/s:lib:$(get_libdir):" -i src/CMakeLists.txt || die

cd ${HIP_S} || die
eapply "${FILESDIR}/${PN}-5.0.2-correct-ldflag.patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it into PATCHES please.

Copy link
Contributor Author

@littlewu2508 littlewu2508 Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not a patch applied in ${S}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@gentoo-bot gentoo-bot closed this in 7dac65e Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants