-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-util/hip: add missing BDEPEND for USE=profile #26090
Conversation
Pull Request assignmentSubmitter: @littlewu2508 dev-util/hip: @gentoo/sci, @candrews, @justxi Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-06-27 13:29 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Also fix ld warnings by patch out unecessary ldflag added by hipcc.pl Closes: https://bugs.gentoo.org/843263 Reference: justxi/rocm#8 (comment) Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
a22ec65
to
d5682a1
Compare
Pull request CI reportReport generated at: 2022-06-27 13:54 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@@ -65,11 +78,13 @@ src_prepare() { | |||
sed -e "/LIBRARY DESTINATION/s:lib:$(get_libdir):" -i src/CMakeLists.txt || die | |||
|
|||
cd ${HIP_S} || die | |||
eapply "${FILESDIR}/${PN}-5.0.2-correct-ldflag.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put it into PATCHES
please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not a patch applied in ${S}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Also fix ld warnings by patch out unecessary ldflag added by hipcc.pl
Reference: justxi/rocm#8 (comment)
Signed-off-by: Yiyang Wu xgreenlandforwyy@gmail.com