net-nntp/sabnzbd: Fix starting when default Python is not 2.x and more #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoapGentoo
suggested changes
Nov 21, 2016
There was a problem hiding this comment.
@kempniu could you squash your commits into one? Have alook at https://wiki.gentoo.org/wiki/Gentoo_Github#Rebasing_commits
| @@ -88,7 +88,8 @@ src_install() { | |||
| insopts -m 0755 | |||
| doins SABnzbd.py | |||
|
|
|||
| python_optimize "${D}usr/share/${PN}" | |||
| python_fix_shebang "${ED}usr/share/${PN}" | |||
| python_optimize "${ED}usr/share/${PN}" | |||
There was a problem hiding this comment.
Please use "${ED%/}/usr/share/${PN}" instead as that will work with slashes possibly removed in some future EAPI.
|
As a maintainer, the separate commits per logical change are much appreciated and easier to review. This PR separated commits nicely as there were 4 distinct changes. Now, had I not already merged, squashing the prefix change mentioned above into the first prefix related commit would have been justified. I'll add it tomorrow when I'm near a box with keys again. |
gentoo-bot
pushed a commit
that referenced
this pull request
Nov 22, 2016
Per #2874 (review) Package-Manager: portage-2.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two issues that popped up after the recent changes to SABnzbd+ ebuilds, adds support for Gentoo Prefix and removes a superfluous post-install message (I suggested this as a bonus to #2861, feel free to ignore this commit if you are against the change it suggests).
/cc @jsbronder (maintainer)