Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/ctl: add 1.5.2_p20221224 #28906

Closed
wants to merge 1 commit into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Dec 31, 2022

Upstream has updated to be compatible to Imath / OpenEXR-3, but no new version released yet, so we use the commit id to fetch the correct version.

Bug: ampas/CTL#100
Closes: https://bugs.gentoo.org/878247
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

See also PR #28278

Upstream has updated to be compatible to Imath / OpenEXR-3, but no new
version released yet, so we use the commit id to fetch the correct version.

Bug: ampas/CTL#100
Closes: https://bugs.gentoo.org/878247
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: media-libs/ctl

media-libs/ctl: @gentoo/video

Linked bugs

Bugs linked: 878247


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Dec 31, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-31 12:08 UTC
Newest commit scanned: e299ae2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a89f907d25/output.html

@ajakk
Copy link
Member

ajakk commented Dec 31, 2022

Asking only because i have little familiarity with this package, but are these safe changes? I think it looks fine otherwise.

 * CMP: =media-libs/ctl-1.5.2-r4 with media-libs/ctl-1.5.2_p20221224/image
 *  FILES:-usr/lib64/CTL/change_saturation.ctl
 *  FILES:-usr/lib64/CTL/transform_DPX_EXR.ctl
 *  FILES:-usr/lib64/CTL/transform_EXR_DPX.ctl
 *  FILES:-usr/lib64/CTL/utilities.ctl
 *  FILES:-usr/lib64/cmake/CTL/CTLConfig.cmake
 *  FILES:-usr/lib64/cmake/CTL/CTLConfigVersion.cmake
 *  FILES:-usr/lib64/cmake/CTL/CTLLibraryDepends.cmake
 *  FILES:-usr/lib64/libctldpx.so
 *  FILES:-usr/lib64/pkgconfig/CTL.pc
 *  FILES:-usr/lib64/pkgconfig/OpenEXR_CTL.pc
 *  FILES:+usr/share/CTL/change_saturation.ctl
 *  FILES:+usr/share/CTL/transform_DPX_EXR.ctl
 *  FILES:+usr/share/CTL/transform_EXR_DPX.ctl
 *  FILES:+usr/share/CTL/utilities.ctl
 *  SONAME:-libctldpx.so(64)
 * ------> FILES(+4,-10) SONAME(-1)

@waebbl
Copy link
Contributor Author

waebbl commented Jan 1, 2023

I already reported some of these changes upstream in the linked issue.

  • The *.ctl files are small source code snippets in the Color Transformation Language, used by the library or consumers. As text files, I think they belong more into DATADIR than in LIBDIR and changed the installation location. Upstream currently has a bug with their installation and installs them into /CTL. I can relocate them into LIBDIR if this directory is more correct.
  • CMake config files and pkg-config files are currently not installed by the package and I've reported this upstream. As we currently don't have consumers in the tree, and I'm hoping they get re-installed in a future patch, this is a safe change for now from my POV.
  • The installed library is a patch from us. The library is by default a static library and not installed and only used for some of the packages tools, so this change is safe as well.

@gentoo-bot gentoo-bot closed this in c6eaff4 Jan 1, 2023
@waebbl waebbl deleted the ctl-exr-update branch January 2, 2023 07:08
@waebbl
Copy link
Contributor Author

waebbl commented Jan 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants