Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/tre: enable py3.11, cleanups #29072

Closed
wants to merge 1 commit into from
Closed

dev-libs/tre: enable py3.11, cleanups #29072

wants to merge 1 commit into from

Conversation

joecool1029
Copy link
Contributor

Cleaned up, enabled py3.11. I think it won't depend on python anymore with -python.

Signed-off-by: Joe Kappus joe@wt.gd

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 12, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-12 02:43 UTC
Newest commit scanned: cdcab41
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3ddc1c0108/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-12 07:18 UTC
Newest commit scanned: e44d3ed
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/11f91f5e8d/output.html

@joecool1029 joecool1029 changed the title dev-libs/tre: enable py3.11, cleanups dev-libs/tre: enable py3.11, cleanups [please reassign] Jan 14, 2023
@gentoo-bot gentoo-bot changed the title dev-libs/tre: enable py3.11, cleanups [please reassign] dev-libs/tre: enable py3.11, cleanups Jan 14, 2023
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @joecool1029
Areas affected: ebuilds
Packages affected: dev-libs/tre

dev-libs/tre: @gentoo/shell-tools

Linked bugs

Bugs linked: 843455

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 14, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-14 00:33 UTC
Newest commit scanned: ce87fbb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fbb766506c/output.html

@thesamesam
Copy link
Member

You seem to have both deleted the warning and dropped the blockers re agrep? It should've just been keeping the blockers?

@joecool1029
Copy link
Contributor Author

You seem to have both deleted the warning and dropped the blockers re agrep? It should've just been keeping the blockers?

It would have made sense to keep the blockers if the blockers were actually in ::gentoo, but they aren't anymore. If someone installs something else providing agrep from an overlay then collision detection will pick it up and they will file a bug or take the agrep useflag off this package.

@thesamesam
Copy link
Member

thesamesam commented Jan 15, 2023 •
edited
Loading

dev-ruby/amatch is still in Gentoo, glimpse was removed only recently, and I think agrep was removed only recently too. We keep blockers for 2 years at least or they disrupt upgrades (cause an abort).

pkgcheck warns when a blocker is due to be dropped.

@joecool1029
dev-libs/tre: enable py3.11, cleanups
fa49f46 
Cleaned up, enabled py3.11, PEP517.

Closes: https://bugs.gentoo.org/843455

Signed-off-by: Joe Kappus <joe@wt.gd>
@joecool1029
Copy link
Contributor Author

dev-ruby/amatch is still in Gentoo, glimpse was removed only recently, and I think agrep was removed only recently too. We keep blockers for 2 years at least or they disrupt upgrades (cause an abort).

I stand corrected, I'll update the URL for dev-ruby/amatch.

pkgcheck warns when a blocker is due to be dropped.

It gave me deprecated warnings so I dropped them out before. Readded now.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-15 04:38 UTC
Newest commit scanned: fa49f46
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8855e08956/output.html

@thesamesam
Copy link
Member

dev-ruby/amatch is still in Gentoo, glimpse was removed only recently, and I think agrep was removed only recently too. We keep blockers for 2 years at least or they disrupt upgrades (cause an abort).

I stand corrected, I'll update the URL for dev-ruby/amatch.

pkgcheck warns when a blocker is due to be dropped.

It gave me deprecated warnings so I dropped them out before. Readded now.

Ah, this might be because of the age of your clone. It's not smart enough if it's a fresh clone sometimes.

Thanks!

@joecool1029 joecool1029 deleted the drtre branch January 15, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joecool1029 @gentoo-repo-qa-bot @gentoo-bot @thesamesam