Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bunch of fixes for dev-util/hip #29255

Closed
wants to merge 9 commits into from
Closed

A bunch of fixes for dev-util/hip #29255

wants to merge 9 commits into from

Conversation

littlewu2508
Copy link
Contributor

@littlewu2508 littlewu2508 commented Jan 25, 2023 •
edited

These commits includes:

  1. Many QA fixes for dev-util/hip-5.3.3 found in bugs.gentoo.org
  2. Double prefix fixes in dev-util/hip-5.1.3 and dev-util/hip-5.3.3
  3. Clean up sed commands for dev-util/hip-5.3.3
  4. Backport a fix in upstream that make hip dynamically find clang include and rt location at runtime. Meaning that there's no need to rebuild dev-util/hip-5.3.3 after bumping clang minor versions.
  5. Remove problematic profile USE flag.
  6. Add myself as maintainer

@littlewu2508
dev-util/hip: Avoid double prefix problems
91d333e 
hprefixify on hip-config.cmake and hipcc.pl is not working well.
Disable auto hprefixify and adjust manual modification instead.

Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@littlewu2508
dev-util/hip: disable non-FHS install
4ab1602 
Closes: https://bugs.gentoo.org/887379
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@littlewu2508
dev-util/hip: remove unnecessary sed commands
7adc4dd 
Note: this turns __HIP_ENABLE_PCH to ON (it's turned off originally due
to build failure back in version 4.0.0, but now the issue disappears)

Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@littlewu2508
dev-util/hip: bump patch "remove-cmake-doxygen-commands"
d453a28 
Closes: https://bugs.gentoo.org/887375
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @littlewu2508
Areas affected: ebuilds
Packages affected: dev-util/hip

dev-util/hip: @gentoo/sci, @candrews, @justxi

Linked bugs

Bugs linked: 887379, 887383, 887375

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 25, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-25 04:48 UTC
Newest commit scanned: f61ca7b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0119f3676f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-25 06:58 UTC
Newest commit scanned: fd82928
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f113656490/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-25 09:33 UTC
Newest commit scanned: 5b8ad8a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8b49a3fd31/output.html

@littlewu2508
dev-util/hip: Backport fixes for clang directories search
c2052c3 
Closes: https://bugs.gentoo.org/891013
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@littlewu2508
dev-util/hip: remove profile USE
4a4ddf7 
No use case currently. Upstream does not ship this by default, too.

Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@littlewu2508
dev-util/hip: remove -Werror added by src/CMakeLists.txt
9d5a828 
Closes: https://bugs.gentoo.org/887383
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@littlewu2508
dev-util/hip: ignore QA FLAG check for libhiprtc-builtins
f69599b 
Closes: https://bugs.gentoo.org/836271
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-27 09:33 UTC
Newest commit scanned: f69599b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/18784a9dbc/output.html

@littlewu2508
dev-util/hip: add myself as maintainer
991baf0 
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-01-27 15:48 UTC
Newest commit scanned: 991baf0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/364fbc43d6/output.html

heroxbd
heroxbd reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@heroxbd heroxbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream does not ship this by default, too.

Upstream does not ship this by default, either.

@heroxbd
Copy link
Contributor

heroxbd commented Jan 31, 2023

Landed.

@heroxbd heroxbd closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heroxbd heroxbd heroxbd left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@littlewu2508 @gentoo-bot @gentoo-repo-qa-bot @heroxbd