-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-admin/webapp-config: EAPI 7 -> 8, PEP517 #30041
Conversation
|
||
LICENSE="GPL-2" | ||
SLOT="0" | ||
IUSE="+portage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we have this USE flag
portage? ( sys-apps/portage[${PYTHON_USEDEP}] )" | ||
|
||
python_prepare_all() { | ||
# make the source from svn mirror the one in the tarball |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did not install without this block. I compared the git with the tarball and it seems it has a copy of itself in a directory named webapp-config
. Doing this fixed the problem.
distutils-r1_python_install_all | ||
|
||
# distutils-r1 installs the scripts in /usr/bin in PEP517 mode | ||
mv "${ED}"/usr/bin "${ED}"/usr/sbin || die "Cannot rename scripts directory to /usr/sbin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked in distutils-r1.eclass
, scripts are always installed into /usr/bin
, but webapp.eclass
needs them in /usr/sbin
. I hope this hack is acceptable.
PYTHON_COMPAT=( python3_{9..11} ) | ||
|
||
inherit distutils-r1 prefix | ||
|
||
if [[ ${PV} = 9999* ]] | ||
then | ||
EGIT_REPO_URI="https://anongit.gentoo.org/proj/${PN}.git" | ||
EGIT_REPO_URI="https://gitweb.gentoo.org/proj/${PN}.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like anongit no longer works, gitweb works.
Pull request CI reportReport generated at: 2023-03-10 11:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Bump to EAPI 8 Switch to PEP517 build mode Fix SRC_URI (upload tarball from cache to devspace) Sync (and fix) live Closes: https://bugs.gentoo.org/711750 Closes: gentoo#30041 Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>
a5ac19d
to
3a43db0
Compare
Pull request CI reportReport generated at: 2023-03-10 11:43 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Bump to EAPI 8 Switch to PEP517 build mode Fix SRC_URI (upload tarball from cache to devspace) Sync (and fix) live Closes: https://bugs.gentoo.org/711750 Closes: https://bugs.gentoo.org/909862 Closes: gentoo#30041 Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>
3a43db0
to
1930aba
Compare
Bump to EAPI 8 Switch to PEP517 build mode Fix SRC_URI (upload tarball from cache to devspace) Sync (and fix) live Closes: https://bugs.gentoo.org/711750 Closes: https://bugs.gentoo.org/909862 Closes: gentoo#30041 Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>
1930aba
to
d71124f
Compare
Pull request CI reportReport generated at: 2023-07-08 07:25 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull Request assignmentSubmitter: @ceamac app-admin/webapp-config: @gentoo/web-apps Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2023-07-08 07:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Bump to EAPI 8
Switch to PEP517 build mode
Fix SRC_URI (upload tarball from cache to devspace)
Sync (and fix) live