Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-ruby/async-io: fix 1.34.3 tests #30552

Closed
wants to merge 1 commit into from
Closed

dev-ruby/async-io: fix 1.34.3 tests #30552

wants to merge 1 commit into from

Conversation

peeweep
Copy link
Contributor

@peeweep peeweep commented Apr 11, 2023

@peeweep
dev-ruby/async-io: fix 1.34.3 tests
5ba198c 
Bug: https://bugs.gentoo.org/904159
Signed-off-by: jinqiang zhang <peeweep@0x0.ee>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @peeweep
Areas affected: ebuilds
Packages affected: dev-ruby/async-io

dev-ruby/async-io: @gentoo/ruby

Linked bugs

Bugs linked: 904159

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 11, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-04-11 10:18 UTC
Newest commit scanned: 5ba198c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/752e2d14d5/output.html

jsmolic
jsmolic reviewed Apr 11, 2023
View reviewed changes
dev-ruby/async-io/files/async-io-1.34.3-tests.patch
@@ -0,0 +1,22 @@
From fe6f1972c74ec0c5107e127cdb299f41b798e3dd Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add bug reference here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit link too please (please always do both)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this up to get this in. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this up to get this in. Thanks!

I just got back, thank you for doing it for me!

@peeweep peeweep deleted the async-io-1.34.3-tests branch April 12, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

@jsmolic jsmolic jsmolic left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@peeweep @gentoo-bot @gentoo-repo-qa-bot @thesamesam @jsmolic