Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-ruby/async-io: fix 1.34.3 tests #30552

Closed
wants to merge 1 commit into from
+26 −0
Closed

dev-ruby/async-io: fix 1.34.3 tests #30552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions dev-ruby/async-io/async-io-1.34.3-r1.ebuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ ruby_add_bdepend "test? (
dev-ruby/rack-test
)"

PATCHES=(
"${FILESDIR}"/${P}-tests.patch
)

all_ruby_prepare() {
sed -i -E 's/require_relative "(.+)"/require File.expand_path("\1")/g' "${RUBY_FAKEGEM_GEMSPEC}" || die

Expand Down
22 changes: 22 additions & 0 deletions dev-ruby/async-io/files/async-io-1.34.3-tests.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
From fe6f1972c74ec0c5107e127cdb299f41b798e3dd Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add bug reference here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit link too please (please always do both)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this up to get this in. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this up to get this in. Thanks!

I just got back, thank you for doing it for me!

From: Samuel Williams <samuel.williams@oriontransfer.co.nz>
Date: Sat, 18 Mar 2023 17:55:54 +1300
Subject: [PATCH] Don't depend on status name.

---
spec/async/io/notification_spec.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/async/io/notification_spec.rb b/spec/async/io/notification_spec.rb
index 2c36c7c..2389ab6 100644
--- a/spec/async/io/notification_spec.rb
+++ b/spec/async/io/notification_spec.rb
@@ -39,7 +39,7 @@
signalling_task.wait
waiting_task.wait

- expect(waiting_task.status).to be :complete
+ expect(waiting_task).to be_complete

subject.close
end