Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-misc/anki: add 23.12.1 #31122

Closed
wants to merge 4 commits into from
Closed

Conversation

antecrescent
Copy link
Contributor

@antecrescent antecrescent commented May 22, 2023

I took great inspiration from NixOS' Anki package. I'd be happy about some feedback!
Should I copy the gl-fixup patch from NixOS? I've had no problems with the GL library so far.
I'll gladly co-maintain this package if need be.

TODO:

  • bzip2_sys appears to compile the library statically, why?
    The crate was dropped with version 2.1.66.
  • Is dev-libs/openssl needed?
    The OpenSSL library is linked against _rsbridge.so only when testing, otherwise it uses Rustls.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @antecrescent
Areas affected: ebuilds
Packages affected: app-misc/anki

app-misc/anki: patrick

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 782373, 896566


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 22, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-05-22 04:03 UTC
Newest commit scanned: 1f82720
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/43c019879a/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-05-22 04:18 UTC
Newest commit scanned: bd039c0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/917c63ed75/output.html

@antecrescent antecrescent changed the title app-misc/anki: add 2.1.63; drop 2.1.15-r1 app-misc/anki: add 2.1.64; drop 2.1.15-r1 May 24, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-05-24 21:49 UTC
Newest commit scanned: 0d8b4bb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8fdf854d79/output.html

@antecrescent antecrescent changed the title app-misc/anki: add 2.1.64; drop 2.1.15-r1 app-misc/anki: add 2.1.65; drop 2.1.15-r1 Jun 7, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-06-07 20:49 UTC
Newest commit scanned: eb62697
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/771b5a7cbe/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-06-12 08:41 UTC
Newest commit scanned: 6dcc86d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a3ec027d66/output.html

@thesamesam thesamesam self-requested a review June 13, 2023 21:27
@antecrescent antecrescent changed the title app-misc/anki: add 2.1.65; drop 2.1.15-r1 app-misc/anki: add 2.1.65 Jun 18, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-06-18 21:00 UTC
Newest commit scanned: 88b2a31
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/435b0cc5e0/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-03 01:55 UTC
Newest commit scanned: 24cb2b0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/123d67ef86/output.html

@antecrescent antecrescent changed the title app-misc/anki: add 2.1.65 app-misc/anki: add 2.1.66 Aug 27, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-27 19:51 UTC
Newest commit scanned: 8e635ae
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0f21027f35/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-27 20:45 UTC
Newest commit scanned: 0d4505e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9cf3df82fa/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-27 21:00 UTC
Newest commit scanned: 6671f25
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4c78a58f0c/output.html

pkg_setup() {
python-single-r1_pkg_setup
# The Python and Yarn environment variables prevent a download of the binaries
export PYTHON_BINARY=/bin/false YARN_BINARY=/bin/false \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to specify hard paths here? These assumptions might not be applicable in eprefix and so on.

Copy link
Contributor Author

@antecrescent antecrescent Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolute paths are required. I did not yet find out why, or how to change that.
The binaries provided by *_BINARY get used during compilation and need to be exported during src_{compile,test}. I'm not sure if that was evident.

According to @thesamesam, they need to be prefixed with ${BROOT}:

[01:01]    colores: I'm currently implementing changes for a review I got on PR 31122. Do I  need to worry about EPREFIX or ROOT when providing the absolute path to a binary? The binary is linked into the build
                    system during src_compile/test.
[01:01] @     sam_: is it linked into the final binary or no?
[01:01] @     sam_: (what is it for)
[01:06]    colores: Sorry, build *dir*. The the symlinked binaries (protoc, node, cargo_nextest) are used during compilation and do not get linked into the final binary.
[01:07] @     sam_: ah, BROOT indeed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to rely on PATH lookups for things like false, but not so much for things in BDEPEND.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in fa3d721

LICENSE="AGPL-3+ Apache-2.0 BSD CC-BY-3.0 GPL-3+ MIT"

SLOT="0"
KEYWORDS="~amd64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DroppedKeywords: version 2.1.66: x86

dropped on purpose?

Copy link
Contributor Author

@antecrescent antecrescent Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunately, I don't have a dedicated testing environment yet and I don't own an x86 machine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding you still keep keywords on upgrades even if you can't test it. You would only drop them if you had to add dependencies which weren't keyworded.

https://devmanual.gentoo.org/keywording/index.html#keywording-on-upgrades

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readded keyword ~x86 in 1dd818e

# PyQt6: Actually need bindings for QtGui with PyQt_OpenGL enabled,
# that is qtbase[opengl,gui] and PyQt6[gui], not PyQt6[gui,opengl].
# dev-qt/qtgui:5 enables opengl support by default.
# If !qt6 block PyQt6, because of the Qt6 detection mechanism
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would patching the detection be viable? The apparent automagic for detecting qt is quite unfortunate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should do it: fa3d721

eapply_user
}

src_compile() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add filter-lto, as you have to use the artisan build system from anki you miss out the cargo eclass doing it for you.

https://devmanual.gentoo.org/eclass-reference/flag-o-matic.eclass/index.html

/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.2.rcgu.o):(.data.rel.ro._ZN4ring2ec7suite_b3ops4p38410SCALAR_OPS17h26ec3b8cf0d0803dE+0x10): undefined reference to `GFp_p384_scalar_mul_mont' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.2.rcgu.o):(.data.rel.ro._ZN4ring2ec7suite_b3ops4p38415PRIVATE_KEY_OPS17h9ebb961007f4d3fdE+0x18): undefined reference to `GFp_nistz384_point_mul' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.3.rcgu.o): in function `ring::ec::curve25519::ed25519::signing::Ed25519KeyPair::from_seed_': ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair10from_seed_17hb60b36172201c437E+0x19b): undefined reference to `GFp_x25519_sc_mask' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair10from_seed_17hb60b36172201c437E+0x20f): undefined reference to `GFp_x25519_ge_scalarmult_base' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair10from_seed_17hb60b36172201c437E+0x319): undefined reference to `GFp_x25519_fe_invert' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair10from_seed_17hb60b36172201c437E+0x33f): undefined reference to `GFp_x25519_fe_mul_ttt' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair10from_seed_17hb60b36172201c437E+0x39c): undefined reference to `GFp_x25519_fe_tobytes' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair10from_seed_17hb60b36172201c437E+0x3a5): undefined reference to `GFp_x25519_fe_isnegative' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.3.rcgu.o): in function `ring::ec::curve25519::ed25519::signing::Ed25519KeyPair::sign': ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x236): undefined reference to `GFp_x25519_sc_reduce' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x2c2): undefined reference to `GFp_x25519_ge_scalarmult_base' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x3ad): undefined reference to `GFp_x25519_fe_invert' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x3d3): undefined reference to `GFp_x25519_fe_mul_ttt' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x426): undefined reference to `GFp_x25519_fe_tobytes' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x42f): undefined reference to `GFp_x25519_fe_isnegative' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x4e6): undefined reference to `GFp_x25519_sc_reduce' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255197ed255197signing14Ed25519KeyPair4sign17hda8ca089a4e9d2e3E+0x51c): undefined reference to `GFp_x25519_sc_muladd' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.3.rcgu.o): in function `ring::ec::curve25519::x25519::x25519_public_from_private': ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255196x2551926x25519_public_from_private17h5715fde4681f6da7E+0x3c): undefined reference to `GFp_x25519_sc_mask' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255196x2551926x25519_public_from_private17h5715fde4681f6da7E+0x5d): undefined reference to `GFp_x25519_public_from_private_generic_masked' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.3.rcgu.o): in function `ring::ec::curve25519::x25519::x25519_ecdh': ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255196x2551911x25519_ecdh17hccf9c85a12b6fbd4E+0x48): undefined reference to `GFp_x25519_sc_mask' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255196x2551911x25519_ecdh17hccf9c85a12b6fbd4E+0x78): undefined reference to `GFp_x25519_scalar_mult_generic_masked' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec10curve255196x2551911x25519_ecdh17hccf9c85a12b6fbd4E+0x95): undefined reference to `GFp_memcmp' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.3.rcgu.o): in function `ring::ec::suite_b::private_key::affine_from_jacobian': ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec7suite_b11private_key20affine_from_jacobian17h16920547b79b0a7dE+0x9f): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.3:(.text._ZN4ring2ec7suite_b11private_key20affine_from_jacobian17h16920547b79b0a7dE+0x37e): undefined reference to `LIMBS_equal' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.5.rcgu.o): in function `ring::aead::shift::shift_partial': ring.cfb003457870c859-cgu.5:(.text._ZN4ring4aead5shift13shift_partial17h787786a3d9c66e07E+0x8b): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.5:(.text._ZN4ring4aead5shift13shift_partial17h787786a3d9c66e07E+0xfe): undefined reference to `GFp_aes_nohw_encrypt' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.5.rcgu.o): in function `ring::ec::suite_b::public_key::parse_uncompressed_point': ring.cfb003457870c859-cgu.5:(.text._ZN4ring2ec7suite_b10public_key24parse_uncompressed_point17h8259afb095248e92E+0x1db): undefined reference to `LIMBS_equal' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libsct-9a9af616cab24234.rlib(sct-9a9af616cab24234.sct.82ad435d069ce946-cgu.6.rcgu.o): in function `spin::once::Once::call_once': sct.82ad435d069ce946-cgu.6:(.text._ZN4spin4once13Once$LT$T$GT$9call_once17h27141cb5c89d780cE+0x29): undefined reference to `GFp_cpuid_setup' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libwebpki-42967812a88c6661.rlib(webpki-42967812a88c6661.webpki.330b278cc997d350-cgu.14.rcgu.o): in function `spin::once::Once::call_once': webpki.330b278cc997d350-cgu.14:(.text._ZN4spin4once13Once$LT$T$GT$9call_once17h4c23d8dacba0f0fcE+0x29): undefined reference to `GFp_cpuid_setup' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.1.rcgu.o): in function `spin::once::Once::call_once': ring.cfb003457870c859-cgu.1:(.text._ZN4spin4once13Once$LT$T$GT$9call_once17hf4f1c09e07dfe557E+0x29): undefined reference to `GFp_cpuid_setup' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.1.rcgu.o): in function `ring::ec::curve25519::scalar::Scalar::from_bytes_checked': ring.cfb003457870c859-cgu.1:(.text._ZN4ring2ec10curve255196scalar6Scalar18from_bytes_checked17h31d6b2054805ae17E+0x1b2): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.1.rcgu.o): in function `::verify': ring.cfb003457870c859-cgu.1:(.text._ZN125_$LT$ring..ec..suite_b..ecdsa..verification..EcdsaVerificationAlgorithm$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17h7de699b8abef8550E+0x390): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.1.rcgu.o): in function `ring::rsa::verification::verify_rsa_': ring.cfb003457870c859-cgu.1:(.text._ZN4ring3rsa12verification11verify_rsa_17h2dce537057c9447fE+0xe7): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.10.rcgu.o): in function `ring::ec::suite_b::ops::p256::p256_point_mul_base_impl': ring.cfb003457870c859-cgu.10:(.text._ZN4ring2ec7suite_b3ops4p25624p256_point_mul_base_impl17hbf946801fd4a1ab5E.llvm.11779339087996081325+0x47): undefined reference to `GFp_nistz256_point_mul_base' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.10.rcgu.o): in function `ring::ec::suite_b::ops::p256::p256_scalar_inv_to_mont': ring.cfb003457870c859-cgu.10:(.text._ZN4ring2ec7suite_b3ops4p25623p256_scalar_inv_to_mont17h20b58461a6322b5cE+0x92): undefined reference to `GFp_p256_scalar_sqr_mont' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.10:(.text._ZN4ring2ec7suite_b3ops4p25623p256_scalar_inv_to_mont17h20b58461a6322b5cE+0x2c7): undefined reference to `GFp_p256_scalar_sqr_mont' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.10.rcgu.o):(.data.rel.ro._ZN4ring2ec7suite_b3ops4p25615PRIVATE_KEY_OPS17h797073f62439627fE+0x18): undefined reference to `GFp_nistz256_point_mul' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.11.rcgu.o): in function `ring::aead::open_within_::open_within': ring.cfb003457870c859-cgu.11:(.text._ZN4ring4aead12open_within_11open_within17h6ed1b17599367a46E+0x6d): undefined reference to `GFp_memcmp' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.11.rcgu.o): in function `ring::aead::gcm::Context::new': ring.cfb003457870c859-cgu.11:(.text._ZN4ring4aead3gcm7Context3new17h9b6f7ca764e3d1caE+0x4b): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN4ring4aead3gcm7Context3new17h9b6f7ca764e3d1caE+0x244): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.11.rcgu.o): in function `ring::aead::gcm::Context::update_block': ring.cfb003457870c859-cgu.11:(.text._ZN4ring4aead3gcm7Context12update_block17h8e6f8da6bfe038b5E+0x1d): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.11.rcgu.o): in function `::verify': ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x110): undefined reference to `GFp_x25519_ge_frombytes_vartime' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x13b): undefined reference to `GFp_x25519_fe_neg' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x1d3): undefined reference to `GFp_x25519_sc_reduce' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x242): undefined reference to `GFp_x25519_ge_double_scalarmult_vartime' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x37c): undefined reference to `GFp_x25519_fe_invert' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x3a2): undefined reference to `GFp_x25519_fe_mul_ttt' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x402): undefined reference to `GFp_x25519_fe_tobytes' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.11:(.text._ZN119_$LT$ring..ec..curve25519..ed25519..verification..EdDSAParameters$u20$as$u20$ring..signature..VerificationAlgorithm$GT$6verify17hc049afca0ea14e3dE+0x40b): undefined reference to `GFp_x25519_fe_isnegative' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.14.rcgu.o): in function `ring::limb::limbs_minimal_bits': ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb18limbs_minimal_bits17h9511fe8c977131b7E+0x81): undefined reference to `LIMB_shr' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.14.rcgu.o): in function `ring::limb::parse_big_endian_in_range_partially_reduced_and_pad_consttime': ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb61parse_big_endian_in_range_partially_reduced_and_pad_consttime17hb93ca815fbc367f0E+0x181): undefined reference to `LIMBS_reduce_once' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb61parse_big_endian_in_range_partially_reduced_and_pad_consttime17hb93ca815fbc367f0E+0x198): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.14.rcgu.o): in function `ring::limb::parse_big_endian_in_range_and_pad_consttime': ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb43parse_big_endian_in_range_and_pad_consttime17h5c63667b46ba9686E+0x181): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb43parse_big_endian_in_range_and_pad_consttime17h5c63667b46ba9686E+0x19d): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.14.rcgu.o): in function `ring::limb::fold_5_bit_windows': ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb18fold_5_bit_windows17hb18ce001c52c87a0E+0x68): undefined reference to `LIMBS_window5_split_window' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb18fold_5_bit_windows17hb18ce001c52c87a0E+0xf2): undefined reference to `LIMBS_window5_split_window' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.14:(.text._ZN4ring4limb18fold_5_bit_windows17hb18ce001c52c87a0E+0x168): undefined reference to `LIMBS_window5_unsplit_window' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.15.rcgu.o): in function `ring::aead::aes::Key::ctr32_encrypt_blocks': ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead3aes3Key20ctr32_encrypt_blocks17hfb9ed6e4594d742eE+0x34): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead3aes3Key20ctr32_encrypt_blocks17hfb9ed6e4594d742eE+0xe4): undefined reference to `GFp_aes_nohw_ctr32_encrypt_blocks' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.15.rcgu.o): in function `ring::aead::aes_gcm::init': ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm4init17haa92ff2a97277d4aE+0xaa): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm4init17haa92ff2a97277d4aE+0xf3): undefined reference to `GFp_aes_nohw_set_encrypt_key' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm4init17haa92ff2a97277d4aE+0x1af): undefined reference to `GFp_aes_nohw_encrypt' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.15.rcgu.o): in function `ring::aead::aes_gcm::aes_gcm_seal': ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_seal17h93c9d340a4b02883E+0x97): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_seal17h93c9d340a4b02883E+0x198): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_seal17h93c9d340a4b02883E+0x286): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_seal17h93c9d340a4b02883E+0x314): undefined reference to `GFp_aes_nohw_encrypt' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.15.rcgu.o): in function `ring::aead::aes_gcm::aes_gcm_open': ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_open17h6a35a02a02960244E+0xaa): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_open17h6a35a02a02960244E+0x16c): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_open17h6a35a02a02960244E+0x304): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring4aead7aes_gcm12aes_gcm_open17h6a35a02a02960244E+0x38a): undefined reference to `GFp_aes_nohw_encrypt' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.15.rcgu.o): in function `ring::ec::suite_b::ecdsa::signing::EcdsaKeyPair::sign': ring.cfb003457870c859-cgu.15:(.text._ZN4ring2ec7suite_b5ecdsa7signing12EcdsaKeyPair4sign17h2cf5ae9732099e87E+0x225): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring2ec7suite_b5ecdsa7signing12EcdsaKeyPair4sign17h2cf5ae9732099e87E+0x3ec): undefined reference to `LIMBS_reduce_once' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.15:(.text._ZN4ring2ec7suite_b5ecdsa7signing12EcdsaKeyPair4sign17h2cf5ae9732099e87E+0x526): undefined reference to `LIMBS_add_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.7.rcgu.o): in function `ring::rsa::signing::RsaKeyPair::from_der_reader': ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair15from_der_reader17h46c0a40f16120acbE+0x32e): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair15from_der_reader17h46c0a40f16120acbE+0x6cb): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair15from_der_reader17h46c0a40f16120acbE+0x8c5): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair15from_der_reader17h46c0a40f16120acbE+0x946): undefined reference to `LIMBS_are_even' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.7.rcgu.o): in function `ring::rsa::signing::PrivatePrime::new': ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing21PrivatePrime$LT$M$GT$3new17h8a15f690b5776377E+0x113): undefined reference to `LIMBS_are_even' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.7.rcgu.o): in function `ring::rsa::signing::RsaKeyPair::sign': ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair4sign17h15650b06b5d66594E+0x336): undefined reference to `GFp_bn_from_montgomery_in_place' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair4sign17h15650b06b5d66594E+0x507): undefined reference to `GFp_bn_from_montgomery_in_place' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair4sign17h15650b06b5d66594E+0x5fa): undefined reference to `LIMBS_sub_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair4sign17h15650b06b5d66594E+0x6d1): undefined reference to `LIMBS_add_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.7:(.text._ZN4ring3rsa7signing10RsaKeyPair4sign17h15650b06b5d66594E+0x8a2): undefined reference to `LIMBS_equal' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.8.rcgu.o): in function `ring::ec::suite_b::ops::PublicScalarOps::elem_less_than': ring.cfb003457870c859-cgu.8:(.text._ZN4ring2ec7suite_b3ops15PublicScalarOps14elem_less_than17h0be739cdb4204df2E+0x1d): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.9.rcgu.o): in function `ring::ec::suite_b::verify_jacobian_point_is_on_the_curve': ring.cfb003457870c859-cgu.9:(.text._ZN4ring2ec7suite_b37verify_jacobian_point_is_on_the_curve17hd786c4ea16efa43bE+0x8f): undefined reference to `LIMBS_are_zero' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.9:(.text._ZN4ring2ec7suite_b37verify_jacobian_point_is_on_the_curve17hd786c4ea16efa43bE+0x383): undefined reference to `LIMBS_equal' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(aesni-x86_64-elf.o): in function `GFp_aes_hw_ctr32_encrypt_blocks': /var/tmp/portage/app-misc/anki-2.1.66/work/cargo_home/gentoo/ring-0.16.20/pregenerated/aesni-x86_64-elf.S:363:(.text+0x4af): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(aesni-x86_64-elf.o): in function `GFp_aes_hw_set_encrypt_key': /var/tmp/portage/app-misc/anki-2.1.66/work/cargo_home/gentoo/ring-0.16.20/pregenerated/aesni-x86_64-elf.S:869:(.text+0xcf6): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(x86_64-mont-elf.o): in function `GFp_bn_mul_mont': /var/tmp/portage/app-misc/anki-2.1.66/work/cargo_home/gentoo/ring-0.16.20/pregenerated/x86_64-mont-elf.S:29:(.text+0x18): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(x86_64-mont-elf.o): in function `bn_sqr8x_mont': /var/tmp/portage/app-misc/anki-2.1.66/work/cargo_home/gentoo/ring-0.16.20/pregenerated/x86_64-mont-elf.S:790:(.text+0x8b6): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(x86_64-mont5-elf.o): in function `GFp_bn_mul_mont_gather5': /var/tmp/portage/app-misc/anki-2.1.66/work/cargo_home/gentoo/ring-0.16.20/pregenerated/x86_64-mont5-elf.S:27:(.text+0x12): undefined reference to `GFp_ia32cap_P' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(x86_64-mont5-elf.o):/var/tmp/portage/app-misc/anki-2.1.66/work/cargo_home/gentoo/ring-0.16.20/pregenerated/x86_64-mont5-elf.S:1098: more undefined references to `GFp_ia32cap_P' follow /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::BoxedLimbs::from_be_bytes_padded_less_than': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint19BoxedLimbs$LT$M$GT$30from_be_bytes_padded_less_than17h8a8791029e072ea8E.llvm.18308331699839165495+0x1b5): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::Modulus::from_be_bytes_with_bit_length': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$29from_be_bytes_with_bit_length17h6de5009f36faa186E+0x1f7): undefined reference to `LIMBS_are_even' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$29from_be_bytes_with_bit_length17h6de5009f36faa186E+0x21c): undefined reference to `LIMBS_less_than_limb' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$29from_be_bytes_with_bit_length17h6de5009f36faa186E+0x264): undefined reference to `GFp_bn_neg_inv_mod_r_u64' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$29from_be_bytes_with_bit_length17h6de5009f36faa186E+0x31a): undefined reference to `LIMBS_shl_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::Modulus::from_nonnegative_with_bit_length': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h5464e81f077ef76eE+0x78): undefined reference to `LIMBS_are_even' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h5464e81f077ef76eE+0x9c): undefined reference to `LIMBS_less_than_limb' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h5464e81f077ef76eE+0xed): undefined reference to `GFp_bn_neg_inv_mod_r_u64' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h5464e81f077ef76eE+0x153): undefined reference to `LIMB_shr' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h5464e81f077ef76eE+0x264): undefined reference to `LIMBS_shl_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::Modulus::from_nonnegative_with_bit_length': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h8ba1d31cffc89811E+0x78): undefined reference to `LIMBS_are_even' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h8ba1d31cffc89811E+0x9c): undefined reference to `LIMBS_less_than_limb' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h8ba1d31cffc89811E+0xed): undefined reference to `GFp_bn_neg_inv_mod_r_u64' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h8ba1d31cffc89811E+0x153): undefined reference to `LIMB_shr' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint16Modulus$LT$M$GT$32from_nonnegative_with_bit_length17h8ba1d31cffc89811E+0x264): undefined reference to `LIMBS_shl_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::Elem::from_be_bytes_padded': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint13Elem$LT$M$GT$20from_be_bytes_padded17h6fb10febb64def60E+0x1b5): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::Elem::into_modulus': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint13Elem$LT$M$GT$12into_modulus17h3af5b26783d23295E+0xec): undefined reference to `LIMBS_are_even' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint13Elem$LT$M$GT$12into_modulus17h3af5b26783d23295E+0x113): undefined reference to `LIMBS_less_than_limb' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint13Elem$LT$M$GT$12into_modulus17h3af5b26783d23295E+0x18e): undefined reference to `GFp_bn_neg_inv_mod_r_u64' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint13Elem$LT$M$GT$12into_modulus17h3af5b26783d23295E+0x203): undefined reference to `LIMB_shr' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint13Elem$LT$M$GT$12into_modulus17h3af5b26783d23295E+0x331): undefined reference to `LIMBS_shl_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::elem_reduced_once': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint17elem_reduced_once17hcc3feb5e6cd32169E+0xcc): undefined reference to `LIMBS_reduce_once' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::PrivateExponent::from_be_bytes_padded': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint24PrivateExponent$LT$M$GT$20from_be_bytes_padded17ha7bef0bfb8ea81a4E+0x1c0): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint24PrivateExponent$LT$M$GT$20from_be_bytes_padded17ha7bef0bfb8ea81a4E+0x203): undefined reference to `LIMBS_are_even' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::elem_inverse_consttime': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint22elem_inverse_consttime17hd3c3bd37fb09ce6fE+0x12c): undefined reference to `LIMBS_add_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint22elem_inverse_consttime17hd3c3bd37fb09ce6fE+0x1a8): undefined reference to `LIMBS_sub_mod' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::verify_inverses_consttime': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint25verify_inverses_consttime17h2095c6ebaf7861aaE+0x4c): undefined reference to `LIMBS_equal_limb' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::Nonnegative::from_be_bytes_with_bit_length': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint11Nonnegative29from_be_bytes_with_bit_length17h4ee9ff5112214373E+0x243): undefined reference to `LIMB_shr' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/libring-41f92c37849b128c.rlib(ring-41f92c37849b128c.ring.cfb003457870c859-cgu.0.rcgu.o): in function `ring::arithmetic::bigint::Nonnegative::to_elem': ring.cfb003457870c859-cgu.0:(.text._ZN4ring10arithmetic6bigint11Nonnegative7to_elem17hab002db6923d1f54E+0x2a): undefined reference to `LIMBS_less_than' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/app-misc/anki-2.1.66/work/anki-2.1.66/out/rust/release/deps/runner-444804a7cd3ceb85: hidden symbol `GFp_ia32cap_P' isn't defined /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status

= note: some extern functions couldn't be found; some native libraries may need to be installed or have their path specified
= note: use the -l flag to specify native libraries to link
= note: use the cargo:rustc-link-lib directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorustc-link-libkindname)

error: could not compile runner (bin "runner") due to previous error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in fa3d721. Also exported AR, CC, PKG_CONFIG (abd0f6b) like cargo eclass as some crates compile non-Rust code etc.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-29 10:00 UTC
Newest commit scanned: 5d20aaf
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/93db4399cc/output.html

@antecrescent
Copy link
Contributor Author

ping. I implemented the requested changes last week. Is there anything else I can do apart from squashing and rebasing?

@parona-source

This comment was marked as resolved.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-26 18:11 UTC
Newest commit scanned: 711afdb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/89ed619990/output.html

@thesamesam
Copy link
Member

Thanks for the ping earlier - I'm swamped atm, but I agree this needs doing. Can you remind me in about two weeks please? Do really appreciate the patience.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-11-27 18:41 UTC
Newest commit scanned: 2d97d79
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6543e26603/output.html

@antecrescent
Copy link
Contributor Author

Changes to last iteration:

  • Drop dependency on Python bindings for QtSvg, instead depend on QtSvg directly
  • Fix typo and do some stylistic changes in DOC_CONTENTS

@thesamesam Your reminder, as requested! Not sure if you read my dm on IRC last weekend, so I thought I'd ping you publicly just in case :P (Thanks a lot for reviewing this rather massive ebuild.)

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 13:47 UTC
Newest commit scanned: a9edef9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/835dc32e86/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-12-13 14:17 UTC
Newest commit scanned: ca4ac8f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/690958c661/output.html

PIPIPIG233666 added a commit to PIPIPIG233666/gentoo_pppig that referenced this pull request Jan 2, 2024
@PIPIPIG233666
Copy link

@antecrescent hey there, good work.
I didn't notice you had a source-built anki ebuild ready for review till I wrote my own based on the latest 23.12.1 release.
The patch is linked here
I have several notable differences:

  • configure
    • stop setting RELEASE for non debug/lto build, default should be 1 anyway
    • use local binary variables instead of masking them (kanged from archlinux aur)
  • compile
    • for minimal, only build with anki-sync-server as the target
    • use runner instead of ninja to build
    • build directly instead of the default wheels
  • install
    • install anki-sync-server direcly
    • fixup wrong symlink for _rsbridge (doesn't seem to be a problem for wheels build though)
    • only install necessary directories for python modules
  • postinstall
    • return 0 for minimal build

I am also thinking of adding a systemd/initrd file for the sync server.

app-misc/anki/anki-23.10.1.ebuild Outdated Show resolved Hide resolved
app-misc/anki/anki-23.10.1.ebuild Outdated Show resolved Hide resolved
app-misc/anki/anki-23.10.1.ebuild Outdated Show resolved Hide resolved
app-misc/anki/anki-23.10.1.ebuild Outdated Show resolved Hide resolved
app-misc/anki/metadata.xml Outdated Show resolved Hide resolved
Closes: https://bugs.gentoo.org/914774
Closes: https://bugs.gentoo.org/911923
Closes: https://bugs.gentoo.org/782373
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
@antecrescent
Copy link
Contributor Author

Changes to last iteration:

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-09 03:54 UTC
Newest commit scanned: 90530f3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a246071209/output.html

mkdir -p out/pyenv/bin || die
ln -s "${PYTHON}" out/pyenv/bin/"${EPYTHON}" || die
ln -s "${EPYTHON}" out/pyenv/bin/python || die
# TODO: ln -s "${BROOT}/usr/bin/protoc-gen-mypy" out/pyenv/bin || die
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atm, pseudo-venv.patch removes the code that generates stubs for Anki's protobuf files. I figured that might be ok for now, since it's "only" type hints that are missing.
I have an ebuild for mypy-protobuf on my disk but I struggle to set up the tests correctly, so I haven't published it yet.

@antecrescent
Copy link
Contributor Author

Thank you for the review and the suggestions!

The patch is linked here

Unfortunately, the link is broken. I assume you meant to link to your PR?

  • configure
    • stop setting RELEASE for non debug/lto build, default should be 1 anyway

https://github.com/ankitects/anki/blob/1a1d4d5419c6b57ef3baf99c9d2d9cf85d36ae0a/build/ninja_gen/src/build.rs#L357-L363
No, you get a debug build if RELEASE is not set.

  • use local binary variables instead of masking them (kanged from archlinux aur)

Can you explain what you mean by masking, please? Maybe it doesn't apply anymore since the 23.12.1 ebuild is quite different from the 23.10.1 one.

  • compile
    • for minimal, only build with anki-sync-server as the target

AFAIK cargo build --manifest-path rslib/sync = cargo build --package anki-sync-server but I agree that the latter variant is much less cryptic. I changed it :)

  • use runner instead of ninja to build

Done.

  • build directly instead of the default wheels

Why? Upstream recommends that you build and install the wheels into your local venv. Also, from what I understand, pip uses dist-info metadata from wheels to resolve dependencies (see: https://bugs.gentoo.org/920330).

  • install
    • install anki-sync-server direcly

If you install the GUI, the sync server is baked into the rsbridge backend. You can even call it directly, so anki-sync-server would be a duplicate. https://docs.ankiweb.net/sync-server.html#from-a-packaged-build

  • fixup wrong symlink for _rsbridge (doesn't seem to be a problem for wheels build though)

I don't know yet, what's going on here.

  • only install necessary directories for python modules

Looking at your ebuild, why did you choose not to install dist-info?

  • postinstall
    • return 0 for minimal build

I don't understand this.

I am also thinking of adding a systemd/initrd file for the sync server.

That's a good idea 👍

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-09 06:04 UTC
Newest commit scanned: 2c6c0bc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2db8305edb/output.html

@antecrescent antecrescent changed the title app-misc/anki: add 23.10.1 app-misc/anki: add 23.12.1 Jan 9, 2024
- Reword pseudo-venv.patch for clarity.

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-09 13:34 UTC
Newest commit scanned: 9a9a349
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c37aaf5a4f/output.html

Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-01-09 23:59 UTC
Newest commit scanned: 962ac46
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ceb942a17c/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
6 participants