sys-devel/llvm-common: add USE=emacs for llvm modes in utils/emacs #31635
Conversation
Pull Request assignmentSubmitter: @alfredfo sys-devel/llvm-common: @gentoo/llvm Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
|
@mgorny: Using What do you prefer? |
Pull request CI reportReport generated at: 2023-06-26 23:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@mgorny: Will fix all of this tomorrow, about to sleep now. Thanks for comments |
|
No hurry, thanks! Alternatively maybe inline these two files (but wrap them, I suppose you can do that) and use |
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
from
fa44fbb
to
64d8d6a
Compare
Pull request CI reportReport generated at: 2023-06-27 19:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
from
64d8d6a
to
83b1d2c
Compare
Pull request CI reportReport generated at: 2023-06-27 21:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Oh, and let's focus on 17.0.0.9999, get that one right and then get the newest 16.x to match. There's really no point in updating < 16, since llvm-common is well, common to all slots. |
|
@mgorny: Yes, I am waiting for it to be merged and then I'll update the PR. |
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
from
83b1d2c
to
6bb3886
Compare
Pull request CI reportReport generated at: 2023-07-13 01:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
2 times, most recently
from
82a4700
to
cb75155
Compare
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
from
cb75155
to
c6a95a4
Compare
Pull request CI reportReport generated at: 2023-07-31 12:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
from
c6a95a4
to
ce9a21f
Compare
Pull request CI reportReport generated at: 2023-07-31 13:00 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| elisp-compile "${S}" emacs/llvm-mode.el | ||
| elisp-compile "${S}" emacs/tablegen-mode.el |
There was a problem hiding this comment.
Sorry for noticing only now, but what is "${S}" doing here?
There was a problem hiding this comment.
Saw it somewhere else, just removing that works right?
There was a problem hiding this comment.
Yes, simply drop the "${S}".
You could also combine the two lines into one:
| elisp-compile "${S}" emacs/llvm-mode.el | |
| elisp-compile "${S}" emacs/tablegen-mode.el | |
| elisp-compile emacs/*.el |
and similarly in src_install:
elisp-install llvm emacs/*.{el,elc}
ce9a21f
to
eb59523
Compare
Pull request CI reportReport generated at: 2023-08-01 01:00 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@alfredfo Rebase? |
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
from
eb59523
to
0201f08
Compare
Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
alfredfo
force-pushed
the
gentoo-llvm-common-emacs
branch
from
0201f08
to
3ee80f2
Compare
Pull request CI reportReport generated at: 2023-10-08 21:20 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
llvm-mir-mode only available in master and llvm-17 snapshots. llvm/llvm-project@8cbf041
@thesamesam