elisp-common.eclass: New function elisp-make-site-file #31662
Conversation
gentoo-bot
added
assigned
|
Package with trivial site-init file done for names |
eclass/elisp.eclass
Outdated
| elisp-site-file-install "${FILESDIR}/${SITEFILE}" | ||
| else | ||
| elisp-make-site-file "${SITEFILE}" | ||
| fi |
There was a problem hiding this comment.
so it install the siftefile if it exists and it makes it if it does not? Where ins installation in 2nd case?
There was a problem hiding this comment.
I just dont understand why make-sitefile also installs it.
There was a problem hiding this comment.
elisp-make-site-file "${SITEFILE}" # => ${T}/${SITEFILE}
elisp-site-file-install "${T}/${SITEFILE}"There was a problem hiding this comment.
I just dont understand why make-sitefile also installs it.
What else would one do with it, if not install it? It's similar to make_desktop_entry() in desktop.eclass.
There was a problem hiding this comment.
We could of course go for a different name if elisp-make-site-file is misleading (then again, the name is similar to make_desktop_entry).
There was a problem hiding this comment.
I think make_desktop_entry makes more sense because we also have domenu. Because this eclass doe not have it I think it is fine.
Pull request CI reportReport generated at: 2023-06-28 19:50 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ulm
force-pushed
the
elisp-make-site-file
branch
from
947f6d1
to
cc1b648
Compare
Pull request CI reportReport generated at: 2023-06-28 20:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ulm
changed the title
gentoo-bot
changed the title
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2023-06-28 20:50 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-06-28 21:05 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ulm
force-pushed
the
elisp-make-site-file
branch
from
4e74a99
to
da67b3d
Compare
ulm
changed the title
gentoo-bot
changed the title
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2023-06-29 17:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2023-06-29 18:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ulm
changed the title
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @ulm dev-lang/teyjus: @markwright At least one of the listed packages is maintained entirely by non-GitHub developers! Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2023-07-01 07:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
This creates and installs a site-init file for the package. The default case will add the package's SITELISP subdirectory to Emacs' load-path. This allows to remove all trivial site-init files (consisting only of a load-path line).
More complicated cases can be handled by providing additional arguments, which are appended as lines to the site-init file.
Update elisp_src_install to call the new function when no explicit site-init file is found.