www-client/lynx: append -D_GNU_SOURCE to CPPFLAGS #34294
Conversation
Pull Request assignmentSubmitter: @csfore www-client/lynx: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 918985 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
|
As @thesamesam had to remind me a couple of times: this will change the generated code, so you should revbump the ebuild. |
Fixes implicit function declarations on glibc systems. Closes: https://bugs.gentoo.org/918985 Signed-off-by: Christopher Fore <csfore@posteo.net>
csfore
force-pushed
the
lynx-add-cflag
branch
from
ac130b9
to
d0526e7
Compare
|
Fixed! |
Pull request CI reportReport generated at: 2023-12-15 16:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| ) | ||
|
|
||
| src_configure() { | ||
| append-cppflags -D_GNU_SOURCE |
There was a problem hiding this comment.
- This needs a bug reference above it in a comment.
- This needs some rationale/justification. Why aren't we fixing the build system properly to do this for us? (A valid answer is: you think this might be fixed in git, but it's not yet in a release. I think that might be the case here from looking at it...)
|
|
||
| LICENSE="GPL-2" | ||
| SLOT="0" | ||
| KEYWORDS="~alpha amd64 arm arm64 hppa ~ia64 ~m68k ~mips ppc ppc64 ~riscv ~s390 sparc x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x64-solaris" |
|
I'm going to merge it w/ fixups as I want this in ASAP, as this one has been driving me mad. Thanks! |
Fixes implicit function declarations on glibc systems. [sam: Add note that it's (likely) a temporary fix until a new development release is made.] Closes: https://bugs.gentoo.org/918985 Signed-off-by: Christopher Fore <csfore@posteo.net> Closes: gentoo#34294 Signed-off-by: Sam James <sam@gentoo.org>
Fixes implicit function declarations on glibc systems.
Made sure to test compile on musl and it succeeded.
Closes: https://bugs.gentoo.org/918985