Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www-client/lynx: append -D_GNU_SOURCE to CPPFLAGS #34294

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
109 changes: 109 additions & 0 deletions www-client/lynx/lynx-2.9.0_pre12-r2.ebuild
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=8

VERIFY_SIG_OPENPGP_KEY_PATH=/usr/share/openpgp-keys/thomasdickey.asc
inherit verify-sig flag-o-matic

case ${PV} in
*_pre*) MY_P="${PN}${PV/_pre/dev.}" ;;
*_rc*) MY_P="${PN}${PV/_rc/pre.}" ;;
*_p*|*) MY_P="${PN}${PV/_p/rel.}" ;;
esac

DESCRIPTION="An excellent console-based web browser with ssl support"
HOMEPAGE="https://lynx.invisible-island.net/"
SRC_URI="https://invisible-mirror.net/archives/${PN}/tarballs/${MY_P}.tar.bz2"
SRC_URI+=" verify-sig? ( https://invisible-mirror.net/archives/${PN}/tarballs/${MY_P}.tar.bz2.asc )"
S="${WORKDIR}/${MY_P}"

LICENSE="GPL-2"
SLOT="0"
KEYWORDS="~alpha amd64 arm arm64 hppa ~ia64 ~m68k ~mips ppc ppc64 ~riscv ~s390 sparc x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x64-solaris"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ekeyword ~all

IUSE="brotli bzip2 cjk gnutls idn nls ssl"

RDEPEND="
sys-libs/ncurses:=[unicode(+)]
sys-libs/zlib
brotli? ( app-arch/brotli:= )
bzip2? ( app-arch/bzip2 )
idn? ( net-dns/libidn2:= )
nls? ( virtual/libintl )
ssl? (
!gnutls? (
dev-libs/openssl:=
)
gnutls? (
dev-libs/libgcrypt:=
>=net-libs/gnutls-2.6.4:=
)
)"
DEPEND="${RDEPEND}"
BDEPEND="
virtual/pkgconfig
nls? ( sys-devel/gettext )
verify-sig? ( sec-keys/openpgp-keys-thomasdickey )
"

PATCHES=(
"${FILESDIR}/${PN}-2.9.0_pre9-mint.patch"
"${FILESDIR}/${PN}-2.9.0_pre9-parallel.patch"
)

src_configure() {
append-cppflags -D_GNU_SOURCE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This needs a bug reference above it in a comment.
  2. This needs some rationale/justification. Why aren't we fixing the build system properly to do this for us? (A valid answer is: you think this might be fixed in git, but it's not yet in a release. I think that might be the case here from looking at it...)

local myconf=(
--enable-cgi-links
--enable-color-style
--enable-externs
--enable-file-upload
--enable-included-msgs
--enable-ipv6
--enable-nested-tables
--enable-nsl-fork
--enable-persistent-cookies
--enable-prettysrc
--enable-read-eta
--enable-scrollbar
--with-screen=ncursesw
--with-zlib
$(use_enable cjk)
$(use_enable idn idna)
$(use_enable nls)
$(use_with brotli)
$(use_with bzip2 bzlib)
)

if use ssl; then
myconf+=(
--with-$(usex gnutls gnutls ssl)="${EPREFIX}/usr"
)
fi

econf "${myconf[@]}"

# Compared to openssl gnutls-openssl API does not use
# default trust store: bug #604526.
sed -e \
"s|#define SSL_CERT_FILE NULL|#define SSL_CERT_FILE \"${EPREFIX}/etc/ssl/certs/ca-certificates.crt\"|" \
-i userdefs.h || die
}

src_compile() {
# generating translation files in parallel is currently broken
use nls && emake -C po -j1
emake
}

src_install() {
emake install DESTDIR="${D}"

sed -i "s|^HELPFILE.*$|HELPFILE:file://localhost/usr/share/doc/${PF}/lynx_help/lynx_help_main.html|" \
"${ED}"/etc/lynx.cfg || die "lynx.cfg not found"
sed -i '/^#CHARACTER_SET:/ c\CHARACTER_SET:utf-8' \
"${ED}"/etc/lynx.cfg || die "lynx.cfg not found"

dodoc CHANGES COPYHEADER PROBLEMS README
dodoc -r docs lynx_help
}