Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-extra/gnome-pomodoro: Add new package, version 0.24.1 #35543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattst88
Copy link
Contributor

Closes: https://bugs.gentoo.org/602712

cc: @gentoo/gnome — should I add you as a maintainer?

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mattst88
Areas affected: ebuilds
Packages affected: gnome-extra/gnome-pomodoro

gnome-extra/gnome-pomodoro: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 602712

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Feb 26, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-02-26 21:12 UTC
Newest commit scanned: 3e81bee
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/974fe01179/output.html

@pacho2
Copy link
Member

pacho2 commented Mar 3, 2024

OK from my part

Thanks for the work!

@logrusx
Copy link

logrusx commented Mar 6, 2024

As I commented in the bug, I think the ebuild should explicitly depend on gnome-shell >=45 as Gnome Pomodoro 0.24 and onward would not work on 44, which is still in tree.

@mattst88
Copy link
Contributor Author

mattst88 commented Mar 6, 2024

As I commented in the bug, I think the ebuild should explicitly depend on gnome-shell >=45 as Gnome Pomodoro 0.24 and onward would not work on 44, which is still in tree.

Thanks. I appreciate the review and the comment.

I don't think I'll make this change because gnome-shell-45.2 is stable and while 44.4 is in tree, it's unstable. Users would have to go well out of their way to use 44.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants