Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-embedded/esptool: fix missing RDEPEND #35626

Closed
wants to merge 2 commits into from
Closed

Conversation

stkw0
Copy link
Contributor

@stkw0 stkw0 commented Mar 5, 2024

This PR moves dev-python/intelhex from a conditional test dependency to an unconditional runtime dep due to the next error I found while using =dev-embedded/esptool-4.7.0:

  File "/usr/lib/python3.11/site-packages/esptool/__init__.py", line 41, in <module>
    from esptool.bin_image import intel_hex_to_bin
  File "/usr/lib/python3.11/site-packages/esptool/bin_image.py", line 16, in <module>
    from intelhex import IntelHex
ModuleNotFoundError: No module named 'intelhex'

Signed-off-by: David Roman <davidroman96@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @stkw0
Areas affected: ebuilds
Packages affected: dev-embedded/esptool

dev-embedded/esptool: @madmartin, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 5, 2024
@Flowdalic
Copy link
Member

Since 4.7.0 is unstable, could you also please drop 4.7.0?

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-05 11:22 UTC
Newest commit scanned: cbac7b2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5a422a7f1c/output.html

Signed-off-by: David Roman <davidroman96@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-05 11:57 UTC
Newest commit scanned: c30cac0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/382e7c3316/output.html

@madmartin
Copy link
Contributor

@stkw0 sorry for not detecting this RDEPEND
@Flowdalic from my point of view okay to merge

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, had this tab open in my browser for AGES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants