Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/fddl: disambiguate variable name from std::array #35966

Closed
wants to merge 1 commit into from
Closed

dev-libs/fddl: disambiguate variable name from std::array #35966

wants to merge 1 commit into from

Conversation

mehw
Copy link
Contributor

@mehw mehw commented Mar 28, 2024

Hello,

This is a trivial fix to disambiguate a variable named array from std::array in the file test/test_dynarray.cpp, letting dev-libs/fddl to compile fine.

Thanks.

$ diff fddl-20111124-r1.ebuild fddl-20111124-r2.ebuild 
1c1
< # Copyright 1999-2021 Gentoo Authors
---
> # Copyright 1999-2024 Gentoo Authors
14c14
< KEYWORDS="amd64 x86"
---
> KEYWORDS="~amd64 ~x86"
16a17,18
> 
> PATCHES=( "${FILESDIR}/${P}-disambiguate-variable-name.patch" )

@mehw
dev-libs/fddl: disambiguate variable name from std::array
68d2d5e 
Trivial fix to disambiguate variable named 'array' from 'std::array'.

Closes: https://bugs.gentoo.org/894632
Package-Manager: portage-3.0.63
Signed-off-by: Matthew White <mehw.is.me@inventati.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mehw
Areas affected: ebuilds
Packages affected: dev-libs/fddl

dev-libs/fddl: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 894632

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 28, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-03-28 16:30 UTC
Newest commit scanned: 68d2d5e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5ce8e23518/output.html

juippis
juippis approved these changes May 9, 2024
View reviewed changes
dev-libs/fddl/fddl-20111124-r2.ebuild
# Copyright 1999-2024 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8

dev-libs/fddl/fddl-20111124-r2.ebuild

EAPI=7

inherit cmake vcs-snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inherit cmake vcs-snapshot
inherit cmake

dev-libs/fddl/fddl-20111124-r2.ebuild
inherit cmake vcs-snapshot

DESCRIPTION="Free Decision Diagram Library"
HOMEPAGE="http://itval.sourceforge.net/ https://github.com/atomopawn/FDDL"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HOMEPAGE="http://itval.sourceforge.net/ https://github.com/atomopawn/FDDL"
HOMEPAGE="https://itval.sourceforge.net/"

Actually is this SF page relevant to FDDL either?

@gentoo-bot gentoo-bot closed this in 6e82a85 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehw @gentoo-bot @gentoo-repo-qa-bot @juippis