-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version of dev-python/grpcio, dev-python/grpcio-tools, dev-python/grpcio-testing to 1.64.1 #36612
base: master
Are you sure you want to change the base?
Conversation
be2b66e
to
8cff441
Compare
Pull request CI reportReport generated at: 2024-05-09 05:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-05-09 06:19 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@mgorny Hi, would you consider merging this pr and unmask dev-python/grpcio ? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
…bump version of grpcio Closes: https://bugs.gentoo.org/904945 Closes: https://bugs.gentoo.org/929457 Signed-off-by: Leo Q <leo.quote@hotmail.com>
@mgorny Thank you for your review. I have just provided ebuilds for Regarding the testing issue you mentioned, I have investigated and found that in the grpc project, tests are centralized in a single folder rather than being separated in individual clients. This means that in order to run tests in the ebuild, we would need to:
Considering the above points, I would recommend adding tests only to dev-python/grpcio to avoid duplicated code or work. If you are satisfied with this approach, I will proceed accordingly. Looking forward to your response. |
Pull Request assignmentSubmitter: @LeoQuote dev-python/grpcio: @gentoo/proxy-maint (maintainer needed) Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2024-06-07 12:11 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
fix https://bugs.gentoo.org/904945 https://bugs.gentoo.org/929457
Please check all the boxes that apply:
Signed-off-by
line to every commit in the pull request.pkgcheck scan --commits --net
to check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.