Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version of dev-python/grpcio, dev-python/grpcio-tools, dev-python/grpcio-testing to 1.64.1 #36612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump version of dev-python/grpcio, dev-python/grpcio-tools, dev-python/grpcio-testing to 1.64.1 #36612

wants to merge 1 commit into from
+113 −0

Conversation

LeoQuote
Copy link

@LeoQuote LeoQuote commented May 9, 2024

fix https://bugs.gentoo.org/904945 https://bugs.gentoo.org/929457

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@LeoQuote LeoQuote changed the title bump version of grpcio to 1.63.0 bump version of dev-python/grpcio to 1.63.0 May 9, 2024
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 9, 2024
@LeoQuote LeoQuote force-pushed the bump-grpc branch 2 times, most recently from be2b66e to 8cff441 Compare May 9, 2024 05:25
@LeoQuote LeoQuote changed the title bump version of dev-python/grpcio to 1.63.0 [please reassign]bump version of dev-python/grpcio to 1.63.0 May 9, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-09 05:35 UTC
Newest commit scanned: 124a072
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/50372bdcb5/output.html

@gentoo-bot gentoo-bot changed the title [please reassign]bump version of dev-python/grpcio to 1.63.0 bump version of dev-python/grpcio to 1.63.0 May 9, 2024
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. labels May 9, 2024
@LeoQuote LeoQuote changed the title bump version of dev-python/grpcio to 1.63.0 [please reassign]bump version of dev-python/grpcio to 1.63.0 May 9, 2024
@gentoo-bot gentoo-bot changed the title [please reassign]bump version of dev-python/grpcio to 1.63.0 bump version of dev-python/grpcio to 1.63.0 May 9, 2024
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 9, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-09 06:19 UTC
Newest commit scanned: 55224cf
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/92a17465e8/output.html

@LeoQuote
Copy link
Author

@mgorny Hi, would you consider merging this pr and unmask dev-python/grpcio ?

@mgorny
Copy link
Member

mgorny commented Jun 4, 2024

  1. This doesn't include all grpcio packages.
  2. It still doesn't include any tests.

mgorny
mgorny requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@LeoQuote LeoQuote marked this pull request as draft June 7, 2024 09:34
@LeoQuote
dev-python/grpcio, dev-python/grpcio-tools, dev-python/grpcio-tests: …
c882b13 
…bump version of grpcio

Closes: https://bugs.gentoo.org/904945
Closes: https://bugs.gentoo.org/929457

Signed-off-by: Leo Q <leo.quote@hotmail.com>
@LeoQuote LeoQuote marked this pull request as ready for review June 7, 2024 11:03
@LeoQuote LeoQuote changed the title bump version of dev-python/grpcio to 1.63.0 bump version of dev-python/grpcio to 1.64.1 Jun 7, 2024
@LeoQuote
Copy link
Author

LeoQuote commented Jun 7, 2024

@mgorny Thank you for your review. I have just provided ebuilds for dev-python/grpcio-tools and dev-python/grpcio-testing. Please take another look.

Regarding the testing issue you mentioned, I have investigated and found that in the grpc project, tests are centralized in a single folder rather than being separated in individual clients. This means that in order to run tests in the ebuild, we would need to:

  1. Clone the entire code repository instead of using the PyPI tarball.
  2. Install all dependencies required for testing.
  3. Follow the steps outlined in the contribution guide to run the tests.

Considering the above points, I would recommend adding tests only to dev-python/grpcio to avoid duplicated code or work. If you are satisfied with this approach, I will proceed accordingly. Looking forward to your response.

@LeoQuote LeoQuote requested a review from mgorny June 7, 2024 11:19
@LeoQuote LeoQuote changed the title bump version of dev-python/grpcio to 1.64.1 [please reassign]bump version of dev-python/grpcio, dev-python/grpcio-tools, dev-python/grpcio-testing to 1.64.1 Jun 7, 2024
@gentoo-bot gentoo-bot changed the title [please reassign]bump version of dev-python/grpcio, dev-python/grpcio-tools, dev-python/grpcio-testing to 1.64.1 bump version of dev-python/grpcio, dev-python/grpcio-tools, dev-python/grpcio-testing to 1.64.1 Jun 7, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @LeoQuote
Areas affected: ebuilds
Packages affected: dev-python/grpcio, dev-python/grpcio-testing, dev-python/grpcio-tools

dev-python/grpcio: @gentoo/proxy-maint (maintainer needed)
dev-python/grpcio-testing: @gentoo/proxy-maint (maintainer needed)
dev-python/grpcio-tools: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 904945, 929457

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 7, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-06-07 12:11 UTC
Newest commit scanned: c882b13
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/681798962b/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny Awaiting requested review from mgorny

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@LeoQuote @gentoo-repo-qa-bot @mgorny @gentoo-bot