-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-sound/teamspeak-server-bin: bump to version 3.1.1 and drop old versions #7307
Conversation
0ab0d7b
to
744063e
Compare
Pull Request assignment Areas affected: ebuilds, other files, profiles media-sound/teamspeak-server-bin: @ConiKost, @gentoo/proxy-maint Bugs linked: 648476 In order to force reassignment and/or bug reference scan, please append |
@@ -1,4 +1,4 @@ | |||
DIST teamspeak3-server_linux_amd64-3.0.13.6.tar.bz2 6492488 BLAKE2B 4cad8545968423c2e65853d73f99a46cbccce628982c0a4418eaf34802d6a171f7e89a4ffc2fbd9fd82afdd9ffcd58d214c894ad88862c2927f1aec72f2d3087 SHA512 95271e5a44c7a14b8fbe134b855973c1af53ac76e6ba01089116b1f63c03bae25f5abfd176f9e26207aa4da8501d646298128078ab5b475458a7ccaba2a48e9c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have gotten this Manifest update mixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will be fixed by next commit.
pkg_nofetch() { | ||
elog "Please download ${A}" | ||
elog "from ${HOMEPAGE}downloads and place this" | ||
elog "file in ${DISTDIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DISTDIR
is forbidden in pkg_nofetch
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixed this.
doins -r sql | ||
|
||
# Add ".ts3server_license_accepted", since LICENSE="teamspeak3" is set | ||
touch ${D}/${opt_dir}/.ts3server_license_accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"${D%/}"
; ||die
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
touch ${D}/${opt_dir}/.ts3server_license_accepted | ||
|
||
# Install documentation and tsdns. | ||
dodoc -r CHANGELOG doc/*.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why -r
? Is one of those files a directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any clue, as it was written before I got proxy-maintainer ;-) Anyway, I've done now a complete rewrite.
|
||
# Install documentation and tsdns. | ||
dodoc -r CHANGELOG doc/*.txt | ||
use doc && dodoc -r serverquerydocs doc/serverquery && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use if
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
use doc && dodoc -r serverquerydocs doc/serverquery && \ | ||
docompress -x /usr/share/doc/${PF}/serverquerydocs && \ | ||
docompress -x /usr/share/doc/${PF}/serverquery && \ | ||
dosym ../../../usr/share/doc/${PF}/serverquery ${opt_dir}/doc/serverquery && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a point in installing them to non-standard location if you need to symlink them back anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this was done before I got proxy-maintainer. I've now rewritten this part.
# Install the runtime FS layout. | ||
insinto /etc/teamspeak3-server | ||
doins "${FILESDIR}"/server.conf "${FILESDIR}"/ts3db_mariadb.ini | ||
keepdir /{etc,var/{lib,log}}/teamspeak3-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unreadable, please split it into the non-lazy variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -1,4 +1,4 @@ | |||
# Copyright 1999-2017 Gentoo Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The commit message summary line is too long.
- The license needs to be added before it is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the commit message summary line to long? It says here https://devmanual.gentoo.org/ebuild-maintenance/git/index.html 70-75 chars? It this wrong?
I've changed the commits now, that the license is added first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's outdated. The current standard is GLEP 66 which specifies 69 for summary line. Rule of thumb is, if GitHub cuts it, it's too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's fine for me.
@@ -12,7 +12,7 @@ SRC_URI=" | |||
x86? ( http://ftp.4players.de/pub/hosted/ts3/releases/${PV}/teamspeak3-server_linux_x86-${PV}.tar.bz2 )" | |||
|
|||
SLOT="0" | |||
LICENSE="teamspeak3 GPL-2" | |||
LICENSE="teamspeak3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is relevant in this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fixed.
profiles/license_groups
Outdated
@@ -71,7 +71,7 @@ BINARY-REDISTRIBUTABLE @FREE bh-luxi Broadcom Dina intel-ucode ipw2100-fw ipw220 | |||
|
|||
# License agreements that try to take away your rights. These are more | |||
# restrictive than "all-rights-reserved" or require explicit approval. | |||
EULA Adaptec-EULA AdobeFlash-11.x ArxFatalis-EULA-JoWooD baudline BCS bf1942-lnxded CAPYBARA-EULA Coherent-Graphics CROSSOVER-2 CYANA DOOM3 dotnet-eula ETQW FAH-EULA-2014 FraunhoferFDK GameFront Gameplay-Group-EULA genymotion GIMPS GOG-EULA google-chrome Google-TOS Intel-SDP Introversion LastPass LOKI-EULA LRCTF MakeMKV-EULA MARBLEBLAST Mendeley-terms MTA-0.5 NVIDIA-CODEC-SDK NVIDIA-CUDA Nero-AAC-EULA Nero-EULA-US OPERA-12 OPERA-2014 Oracle-BCLA-JavaSE PAPERS-PLEASE POMPOM postal2 Primate-Plunge PUEL Q3AEULA Q3AEULA-20000111 QUAKE4 Quartus-prime-megacore RAR RTCW RTCW-ETEULA RuneScape-EULA SJ-Labs spin-commercial spin-educational StarUML-EULA TeamViewer THINKTANKS UPEK-SDK-EULA ut2003 ut2003-demo Vivaldi worklog-assistant Xerox yangcli-pro zi-labone | |||
EULA Adaptec-EULA AdobeFlash-11.x ArxFatalis-EULA-JoWooD baudline BCS bf1942-lnxded CAPYBARA-EULA Coherent-Graphics CROSSOVER-2 CYANA DOOM3 dotnet-eula ETQW FAH-EULA-2014 FraunhoferFDK GameFront Gameplay-Group-EULA genymotion GIMPS GOG-EULA google-chrome Google-TOS Intel-SDP Introversion LastPass LOKI-EULA LRCTF MakeMKV-EULA MARBLEBLAST Mendeley-terms MTA-0.5 NVIDIA-CODEC-SDK NVIDIA-CUDA Nero-AAC-EULA Nero-EULA-US OPERA-12 OPERA-2014 Oracle-BCLA-JavaSE PAPERS-PLEASE POMPOM postal2 Primate-Plunge PUEL Q3AEULA Q3AEULA-20000111 QUAKE4 Quartus-prime-megacore RAR RTCW RTCW-ETEULA RuneScape-EULA SJ-Labs spin-commercial spin-educational StarUML-EULA teamspeak3 TeamViewer THINKTANKS UPEK-SDK-EULA ut2003 ut2003-demo Vivaldi worklog-assistant Xerox yangcli-pro zi-labone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to apply, please rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
7ef1d24
to
76ed76c
Compare
@mgorny: Thank you very much for your review. As I always wanted to clean up the eBuild, I've done now a complete rewrite, which should be much cleaner. |
@@ -1,443 +1,1141 @@ | |||
TeamSpeak 3.x - End User License Agreement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused why you're changing this file. Is this a license update or sth? I don't think we tend to edit licenses in place. Also, commit message summary line is too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a license update. Because the license, which is currently in portage, is pretty old. It's not even for the current version in portage valid. So it should be updated anyway. This license is shipped with the current release in portage and for the new release 3.1.1 in their tar-files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that addresses my concerns. Could you then make the commit message indicate it's an update? Also stating that the current license is not valid for current version would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
WorkingDirectory=/opt/teamspeak3-server | ||
ExecStartPre=/bin/rm -f /dev/shm/7gbhujb54g8z9hu43jre8 | ||
ExecStart=/opt/bin/ts3server inifile=/etc/teamspeak3-server/ts3server.ini | ||
ExecStop=/bin/kill -15 $MAINPID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to explicitly kill it like that? Doesn't systemd's default killing work for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked it now, works fine without it for me, so dropping it.
ExecStartPre=/bin/rm -f /dev/shm/7gbhujb54g8z9hu43jre8 | ||
ExecStart=/opt/bin/ts3server inifile=/etc/teamspeak3-server/ts3server.ini | ||
ExecStop=/bin/kill -15 $MAINPID | ||
StandardOutput=syslog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you forcing syslog? I think most systemd users would prefer it to respect their default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This are the systemd units, which are currently in portage. I've took a look into the docs, so I will remove it completly, to use the systemds default, whatever the user uses.
export LD_LIBRARY_PATH="${BASEDIR}${LD_LIBRARY_PATH:+:}${LD_LIBRARY_PATH}" | ||
|
||
# work around DT_RPATH (.) security issue by chdir'ing into expected $LD_LIBRARY_PATH | ||
cd "${BASEDIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about &&
here (and drop the empty line below), so that it doesn't try to exec
when cd
fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine for me. Will update this.
} | ||
|
||
src_install() { | ||
local TS3_DIR="teamspeak3-server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't. Those are single words, so you're saving little and the code below is much harder to read when you have to constantly substitute and verify there's no mixup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, as you wan't, I will change it. But personally I don't see any difference in being reading harder.
insinto "/etc/${TS3_DIR}" | ||
doins "${FILESDIR}/ts3db_mariadb.ini" | ||
|
||
insinto "/opt/${TS3_DIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another shared lib for doexe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, will be changed.
|
||
# Install optional docs | ||
if use doc; then | ||
local HTML_DOCS="doc/serverquery/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML_DOCS is supposed to be an array, and please use foo/.
instead of foo/*
to avoid unnecessary bash filename expansion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thanks. Will be fixed.
|
||
# Protect config | ||
if use mysql; then | ||
echo "CONFIG_PROTECT=\"/etc/${TS3_DIR}/ts3server.ini /etc/${TS3_DIR}/ts3server_mariadb.ini\"" > "${T}"/99${TS3_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|| die
, and likewise below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added.
else | ||
echo "CONFIG_PROTECT=\"/etc/${TS3_DIR}/ts3server.ini\"" > "${T}"/99${TS3_DIR} | ||
fi | ||
doenvd "${T}"/99${TS3_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed.
doenvd "${T}"/99${TS3_DIR} | ||
|
||
# Set permissions | ||
fowners -R ${TS3_UG}:${TS3_UG} "/etc/${TS3_DIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can pass multiple dirs to fowners
,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, will change it. I personally like to have each directory in one line.
0b6beec
to
c4ae969
Compare
@mgorny: Thanks, I've pushed a new version. |
KEYWORDS="~amd64 ~x86" | ||
IUSE="doc mysql tsdns" | ||
|
||
RDEPEND="mysql? ( dev-db/mariadb-connector-c )" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this used? I don't see mariadb driver in the archive. I honestly doubt it's going to try to load the system QtSql driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at libts3db_mariadb.so. "ldd" shows a dependency for dev-db/mariadb-connector-c aka libmariadb.so.2.
But: I see, that I am using dev-db/mariadb-connector-c-2.3.5 (libmariadb.so.2) from my local overlay. Gentoo only has dev-db/mariadb-connector-c-3.0.3 (libmariadb.so.3). That means, this version is too new. Teamspeak depends on libmariadb.so.2.
Basically this means, mariadb support never has worked in gentoo "upstream" with teamspeak3-server. Seems, that the package was, before I took this for proxy maintain, already wrong.
So I see this options:
- drop mariadb support
- Include dev-db/mariadb-connector-c-2.3.5 in portage. It's still maintained. I've created a PR: dev-db/mariadb-connector-c: add 2.3.5 version #7499 Feel free to close, if this is not an option.
- Teamspeak includes in the folder "redist" an libmariadb.so.2, but I am not happy to install a compiled lib..
What do you think? I've commited now a new version, which depens von 2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gentoo/mysql maintains mysql. I suppose they wouldn't mind adding a compat SLOT=2
or alike that just installs .so
files for binary packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's see what @gentoo/mysql says..
|
||
RESTRICT="fetch mirror strip" | ||
|
||
S="${WORKDIR}/teamspeak3-server_linux_${ARCH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARCH is not allowed in global scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it. Is this okay that way?
SRC_URI="amd64? ( http://ftp.4players.de/pub/hosted/ts3/releases/${PV}/teamspeak3-server_linux_amd64-${PV}.tar.bz2 ) | ||
x86? ( http://ftp.4players.de/pub/hosted/ts3/releases/${PV}/teamspeak3-server_linux_x86-${PV}.tar.bz2 )" | ||
|
||
LICENSE="teamspeak3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is bundling a lot of libraries. FWICS, it's using libc++, so you can't unbundle most of them. However, you need to explicitly list the license for every one of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I do look at ts3server, tsdnsserver and both libs, I only see glibc, zlib, openssl and mariadb-connector-c.
Looking at LICENSE:
/usr/portage/sys-libs/glibc/glibc-2.27-r1.ebuild:LICENSE="LGPL-2.1+ BSD HPND ISC inner-net rc PCRE"
/usr/portage/dev-libs/openssl/openssl-1.0.2n.ebuild:LICENSE="openssl"
/usr/portage/dev-db/mariadb-connector-c/mariadb-connector-c-3.0.3.ebuild:LICENSE="LGPL-2.1"
/usr/portage/sys-libs/zlib/zlib-1.2.11-r1.ebuild:LICENSE="ZLIB"
So I have to add at least "LGPL-2.1+ openssl ZLIB" to LICENSE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LICENSE
needs to express licenses for all files that are installed, even if you believe they're not being used. You can ofc strip them but I kinda doubt they're really unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so that would be in case LGPL-2.1 for mariadb-connector-c (for the single lib in redist/) and teamspeak3 for the Rest.
Group=teamspeak | ||
WorkingDirectory=/opt/teamspeak3-server | ||
Environment="LD_LIBRARY_PATH=/opt/teamspeak3-server" | ||
Environment="TS3SERVER_LICENSE=accept" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary when you already create the license-accepted file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not necessary, but I think, for the "just in case", it's nice to have it here. It doesn't hurt IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, my main concern was that it's present in systemd unit but not in OpenRC init.d. But it's not a biggie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an env var for the openrc script.
19c3647
to
e6d1eee
Compare
@mgorny: As spoken, I've dropped now mysql support, for get this first merged. When @gentoo/mysql will have a solution, I will readd mysql support. |
username=teamspeak | ||
password=teamspeak | ||
database=teamspeak | ||
socket= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the trailing newline here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it now. What's the purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the standard for regular files. Missing it just causes unnecessary noise from git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will have a look on it. I see the red symbol, you mean, in Github.
@@ -1,4 +1,6 @@ | |||
DIST teamspeak3-server_linux_amd64-3.0.13.6.tar.bz2 6492488 BLAKE2B 4cad8545968423c2e65853d73f99a46cbccce628982c0a4418eaf34802d6a171f7e89a4ffc2fbd9fd82afdd9ffcd58d214c894ad88862c2927f1aec72f2d3087 SHA512 95271e5a44c7a14b8fbe134b855973c1af53ac76e6ba01089116b1f63c03bae25f5abfd176f9e26207aa4da8501d646298128078ab5b475458a7ccaba2a48e9c | |||
DIST teamspeak3-server_linux_amd64-3.0.13.8.tar.bz2 6916065 BLAKE2B 0ff4d86a03c910739f27b624d023ba3a5f323f4d56bca6a29a5ce8a737901372ff22cf18f2cc589af07b373fd17f952896ae2aa623571fc004a653125772aa0b SHA512 d8985f5850602660a6c037c1768a97c79b5842640d618ad00d242035a12820b52ba959545f3e668eb3d6079b1a228ff648c569e7d1fc64be6743ee77995ab0be | |||
DIST teamspeak3-server_linux_amd64-3.1.1.tar.bz2 7798155 BLAKE2B 4962968b33eaaa07043cfaa23d020d3d7dcff19b9e380f797196d382a4d004fb0ca2a56246eedf246f796e1bea8f719e80e715b2eda67e5340b7042dd1111a57 SHA512 8561cbeb16a44889ddaa6ab054b47abaaa6a5c942f39c308f6afd2687110bc9e142a8711afe557fa22fe92d1395b844a0eff8c8043921aee4e8070571bee6e44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you can't download this version anymore. Could you update, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? I was able to download it?
Anyway, I've dropped RESTRICT="fetch", as I don't see, that the license would deny this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I missed SRC_URI ;-).
|
||
# Install optional docs | ||
if use doc; then | ||
local HTML_DOCS="doc/serverquery/." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bash array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, fixed.
5536d01
to
1e03b93
Compare
Closes: https://bugs.gentoo.org/648476 Package-Manager: Portage-2.3.30, Repoman-2.3.9
Pull request CI report Report generated at: 2018-04-20 10:29 UTC No issues found Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation. This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage. |
For the future bump, please add
|
Closes: https://bugs.gentoo.org/648476 Package-Manager: Portage-2.3.30, Repoman-2.3.9
media-sound/teamspeak-server-bin: bump to version 3.1.1 and drop old versions
Closes: https://bugs.gentoo.org/648476