-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-admin/syslog-ng: Bump to 3.14.1 and fix capability support. #7323
Conversation
Starting syslog-ng as user was broken, mostly due to mistakes in the daemon file. It closes bug #544766, as the main intention was the use startup and filecaps bring other implications wrt security. Closes: https://bugs.gentoo.org/544766 Package-Manager: Portage-2.3.24, Repoman-2.3.6
Pull Request assignment Areas affected: ebuilds app-admin/syslog-ng: @hydrapolic, @gentoo/proxy-maint Bugs linked: 544766 In order to force reassignment and/or bug reference scan, please append |
Thanks for the PR :) Bug https://bugs.gentoo.org/544766 added USE=filecaps, but I don't see it here - was that the intention? |
Yes, I did that intentionally. The bug report sounds to me as the primary goal was to filecaps on the other hand have a bit odd smelling, as they need to set specific bits on the binary and everyone that can run the actual binary has automagically the rights of syslog (in case of something like ping I wouldn't care). So in my eyes working USE="cap" solves the issue. I’ll post a short statement in the bugtracker and ask the reporting user if he’s fine with this. PS: The old syslog-ng versions aren't touched by this PR, so the mentioned bug in the daemon file exists pre 3.14.1. |
Enough if we enhance the new version,we won't touch the older ones. |
Please let's close this and continue with #7384. |
Starting syslog-ng as user was broken, mostly due to mistakes in the
daemon file. It closes bug #544766, as the main intention was the
use startup and filecaps bring other implications wrt security.
Closes: https://bugs.gentoo.org/544766
Package-Manager: Portage-2.3.24, Repoman-2.3.6
Changes:
-> IUSE="+caps", and add user syslog-ng when caps is set
-> dropped copyright line from hardened config to make file homogen
-# Copyright 1999-2017 Gentoo Foundation
-# Distributed under the terms of the GNU General Public License v2)
-> fixed daemon file/init script (let daemon start as root and drop its right itself + set command_background=1 for PID file generation outside of syslog-ng)
-> enabled python3_5 - upstream doc seem to be outdated