qt@g.o: fdo-mime->xdg-utils #7886
Conversation
|
Pull Request assignment Areas affected: ebuilds mail-client/trojita: @jktjkt, @gentoo/qt, @gentoo/kde No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append |
gentoo-repo-qa-bot
added
assigned
|
Pull request CI report Report generated at: 2018-04-09 06:28 UTC Issues already there before the PR (double-check them): |
| dev-libs/mimetic | ||
| >=app-crypt/gpgme-1.8.0[cxx,qt5] |
There was a problem hiding this comment.
why the unnecessary (and wrong) change?
There was a problem hiding this comment.
@a17r prolly fat-fingerd on vimdiff, gimme a sec and I'll fix that.
There was a problem hiding this comment.
Ah no, this is not that. Basically its keeping the live and versioned ebuilds as similar as possible.
There was a problem hiding this comment.
if that's the case then fix sorting in the live ebuild instead.
There was a problem hiding this comment.
Done, and I went ahead and moved the ""->() change to another commit along with the change.
Also some minor rearrangement, git://->https://, and DOCS=""->DOCS=() Package-Manager: Portage-2.3.28, Repoman-2.3.9
Package-Manager: Portage-2.3.28, Repoman-2.3.9
Package-Manager: Portage-2.3.28, Repoman-2.3.9
Package-Manager: Portage-2.3.28, Repoman-2.3.9
|
As a proxy maintainer with no knowledge of the fdo/xdg eclasses, the changes to trojita look reasonable. If I was doing them, I would split the actual changes of fdo/xdg into once commit and the unification into another commit. |
hanetzer
force-pushed
the
qt-fdo-mime
branch
2 times, most recently
from
86d1c35
to
52dbd9b
Compare
|
@jktjkt Gotcha, did so. |
No description provided.