dev-python/h11: Introducing new package

[bucefal91]

Introducing dev-python/h11 into Gentoo.

Closes: https://bugs.gentoo.org/654856
Package-Manager: Portage-2.3.33, Repoman-2.3.9

[gentoo-repo-qa-bot]

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/h11

dev-python/h11: @gentoo/proxy-maint (new package)

Bugs linked: 654856

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

---

Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

[ConiKost]

Drop it, if empty.

[ConiKost]

Drop it, if empty.

[bucefal91]

I have removed those IUSE :)

[bucefal91]

ehm... Based on the info https://pypi.org/project/h11/ am I correct in concluding that I should remove python3_6 and add pypy from both ebuilds? pypi.org page does not say it's supported for Python 3.6 (at least it appears that way to me - I am newbie with anything related to Python).

[ConiKost]

Well, so, either remove it or test it, if it works with 3.6 ;-)

[bucefal91]

I've updated the versions. I just do not trust myself with Python. I am a php developer and if it wasn't for mitmproxy I wouldn't be here doing things I barely understand with dev-python/* packages :)

Thanks for the guidance though :)

[mgorny]

I'm sorry we haven't managed to review this sooner.

[mgorny]

Is there a very good reason you're adding two versions? Both given the same visibility, users will just install the newer one and the old one won't be really used or tested.

[bucefal91]

Yes, I am creating all these dev-python/* ebuilds because https://github.com/bilelmoussaoui/Authenticator depends on them and I need that software in my gentoo laptop :) So Authenticator depends on dev-python/wsproto which in turn depends on =dev-python/h11-0.7*). Here is a snippet from my local terminal where I have those packages installed in an overlay:

dell /usr/portage/distfiles # equery depends dev-python/h11
 * These packages depend on dev-python/h11:
dev-python/wsproto-0.11.0 (=dev-python/h11-0.7*[python_targets_python2_7(-)?,python_targets_python3_5(-)?,python_targets_python3_6(-)?,-python_single_target_python2_7(-),-python_single_target_python3_5(-),-python_single_target_python3_6(-)])

[bucefal91]

My bad... actually it's mitmproxy-3.0.4 who depends on =h11-0.7* through wsproto; not authenticator. I have a few open pull requests against gentoo repo where dependencies to both authenticator and mitmproxy are being added.

[mgorny]

Ok. Just to confirm: are you sure that those versions are really necessary, and it's not just upstream forcing too specific dependencies unnecessarily?

[bucefal91]

To answer your question - no, I am not sure but I think yes, it's a neccesary thing. Here's what I have found in regards to these versions.

mitmproxy-3.0.4 depends on wsproto package. https://github.com/mitmproxy/mitmproxy/blob/v3.0.4/setup.py It states wsproto>=0.11.0,<0.12.0

Then wsproto depends on h11 - https://github.com/python-hyper/wsproto/blob/master/setup.py It states h11 ~= 0.7.0.

I quickly scanned the issue queue of wsproto and seems like there are people who have tried wsproto + h11-0.8.* and nothing good came out of it - python-hyper/wsproto#53

[mgorny]

Let''s wait on python-hyper/wsproto#54

[mgorny]

This is multi-value, so preferably please include the github homepage as well.

[mgorny]

Please include running tests. If tests require live network access, also add RESTRICT="test" with appropriate comment.

https://wiki.gentoo.org/wiki/Project:Python/Tests

[bucefal91]

Tests successfully pass on both ebuilds. I tried first to run them via unittest, but it wouldn't discover a single test. I invested some time into figuring out how to make it work, but eventually gave up and had py.test do the testing (which worked out like a charm from the 1st try).

The tests do not require internet access. I was able to emerge h11 package on a laptop entirely disconnected from the internet and tests passed too.

[mgorny]

They actually import pytest, so py.test is the way to go.

[bucefal91]

@mgorny In general I believe now all of your feedback is processed here. I also squashed all the work into a single commit to keep it pretty.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2018-06-06 19:14 UTC
Newest commit scanned: 3731bde
Status: ✅ good

No issues found