Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/kaitaistruct: Introducing new package #8263

Closed
wants to merge 10,000 commits into from

Conversation

bucefal91
Copy link
Contributor

Introducing dev-python/kaitaistruct into Gentoo repository.

Closes: https://bugs.gentoo.org/654860
Package-Manager: Portage-2.3.33, Repoman-2.3.9

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/kaitaistruct

dev-python/kaitaistruct: @gentoo/proxy-maint (new package)

Bugs linked: 654860

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.


Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 4, 2018
inherit distutils-r1

DESCRIPTION="Kaitai Struct runtime for Python"
HOMEPAGE="http://kaitai.io/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPS please

LICENSE="MIT"
SLOT="0"
KEYWORDS="~amd64 ~x86"
IUSE=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop it, if empty.

@bucefal91
Copy link
Contributor Author

@ConiKost Hello :) thanks for reviewing my stuff!

I believe I have processed your feedback (will be processing now in other pull requests too).

@@ -0,0 +1 @@
DIST kaitaistruct-0.7.tar.gz 5117 BLAKE2B d7ef62414ca07c48f8a813925d0ab157bb1c198619795b6aa99de1c9415eea397e3b24ee2f28bbc1f4315ec7cb0b81fbe7306c1444104365cd4a455ce4e54d82 SHA512 1ee2e5d1e1de6a85dcaea684bee639f6b08bc0f06b8357fe388c339287388136638d11d301319a344364dc9cf98d3247fb6fc2d8332d9aaee6ee828e5650b447
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not directly newest 0.8 release?


EAPI=6

PYTHON_COMPAT=( python2_7 python3_{3,4,5} )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3_6 is missing, is this correct?

@bucefal91
Copy link
Contributor Author

Somehow my search engine (duckduck go) threw me onto 0.7 and I didn't bother to make sure it was the latest release (I just assumed I would magically land onto the freshest one from the search results).

So I added 0.8.ebuild too. I also looked into supported versions as reported by https://pypi.org/project/kaitaistruct/0.{7,8}/ and written corresponding stuff into PYTHON_COMPAT. I also removed python3_3 as per https://wiki.gentoo.org/wiki/Project:Python/Implementations it's no longer supported.

FuzzyGophers and others added 19 commits June 2, 2018 22:58
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Upstream:
- Now an error to fetch attributes from a statement handle whose
  database handle is inactive.

Closes: https://bugs.gentoo.org/656546
Package-Manager: Portage-2.3.29, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Lars Wendler and others added 21 commits June 4, 2018 10:39
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Closes: https://bugs.gentoo.org/657182
Package-Manager: Portage-2.3.24, Repoman-2.3.6
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Closes: gentoo#8683
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Introducing dev-python/kaitaistruct into Gentoo repository.

Closes: https://bugs.gentoo.org/654860
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@bucefal91 bucefal91 force-pushed the 654860-dev-python-kaitaistruct branch from 8fe2bc1 to 954b177 Compare June 5, 2018 14:46
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-06-05 15:14 UTC
Newest commit scanned: 954b177
Status: ✅ good

No issues found

@mgorny
Copy link
Member

mgorny commented Jun 6, 2018

Is this also part of something bigger? If yes, then I would propose I'll just mark this one as reviewed but merge them all together.

@bucefal91
Copy link
Contributor Author

@mgorny , yes, it is a dependency of net-proxy/mitmproxy-3.0.4 https://bugs.gentoo.org/572170

I might be wrong, but I think repoman wouldn't allow me to commit or QA bot would throw tons of errors if I file a pull request for mitmproxy and one of its dependencies would be missing in the main gentoo tree (though present in my overlay). I have a ready & functional mitmproxy-3.0.4.ebuild; I didn't file pull request for it precisely because the dependencies were missing.

@mgorny
Copy link
Member

mgorny commented Jun 6, 2018

Let me rephrase. Let's review all the deps you have filed already, then close them and file one pull request containing all packages. Would that work for you?

@bucefal91
Copy link
Contributor Author

Yes, sure :)

Currently open I have for net-proxy/mitmproxy:

And for authenticator:

@bucefal91
Copy link
Contributor Author

@mgorny In your last comment to this pull request you said you'd like to merge a bunch of dev-python/* packages I've been working on once they are all settled. Looks like they are all reviewed (some of them are already merged by you), the ones that are still not:

Do you want me to squash it into a single commit or how do you want to proceed? :)

@mgorny
Copy link
Member

mgorny commented Jun 25, 2018

Nah, just leave it as is and I'll test both soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet