Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-im/spectrum2: New package #9098

Closed
wants to merge 1 commit into from
Closed

net-im/spectrum2: New package #9098

wants to merge 1 commit into from

Conversation

ConiKost
Copy link
Contributor

@ConiKost ConiKost commented Jul 7, 2018

Old closed PR due hack: #7815

Closes: https://bugs.gentoo.org/291437
Package-Manager: Portage-2.3.24, Repoman-2.3.6
RepoMan-Options: --force

@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-im/spectrum2

net-im/spectrum2: @gentoo/proxy-maint (new package)

Bugs linked: 291437

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 7, 2018
tonyvroon
tonyvroon suggested changes Jul 11, 2018
View reviewed changes
net-im/spectrum2/spectrum2-2.0.7.ebuild Outdated
sqlite? ( dev-db/sqlite:3 )
test? ( dev-util/cppunit )
twitter? ( net-misc/curl )
xmpp? ( net-im/swiften[ft]:= )"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is flagged up by the automated checks as an invalid dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am aware of this. I changed it now to net-im/swift. But this package is also currently NOT in portage. Please see #9099. After talking to @Dessa, I switched from swiften to swift, but there are a couple of problems open, which needs to be resolved before this can be commited..

hydrapolic
hydrapolic reviewed Jul 15, 2018
View reviewed changes
net-im/spectrum2/spectrum2-2.0.7.ebuild Outdated

newinitd "${FILESDIR}"/spectrum2.initd spectrum2

fowners -R spectrum:spectrum /etc/spectrum2 /var/lib/spectrum2 /var/log/spectrum2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is good, but from the security perspective it's not that good (please read http://michael.orlitzky.com/articles/end_root_chowning_now_%28make_pkg_postinst_great_again%29.xhtml).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right, changed now. Thanks!

@andrey-utkin
Copy link
Contributor

@ConiKost thanks for working hard on this. I am going to review this and move it forward.
I am interested, particularly because I'm running it on my own server. I am using -9999 ebuild from mva overlay, though, which worked reasonably well for a year or so. So naturally I'll be looking into merging your work and @msva 's.

@andrey-utkin andrey-utkin self-assigned this Aug 19, 2018
@andrey-utkin andrey-utkin mentioned this pull request Aug 19, 2018
Closed
Dessa
Dessa reviewed Sep 20, 2018
View reviewed changes
net-im/spectrum2/files/use_qt5_libcommuni.patch Outdated
endif()
INSTALL(TARGETS spectrum2_libcommuni_backend RUNTIME DESTINATION bin)

--- a/cmake_modules/CommuniConfig.cmake 2018-02-07 11:57:43.000000000 +0100
Copy link
Contributor

@Dessa Dessa Sep 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see this anywhere

edit: err. i was looking at 2.0.8, nevermind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, bumped to 2.0.8 and updated those patches.

@andrey-utkin
Copy link
Contributor

Really started to work on reviewing and testing this.

@ConiKost ConiKost force-pushed the spectrum2 branch 2 times, most recently from 9115531 to 354dfa6 Compare November 10, 2018 20:11
@ConiKost
Copy link
Contributor Author

Fixed RDEPEND/DEPEND and updated deps for tests, but restricted them, as the fail pretty hard.

@ConiKost ConiKost force-pushed the spectrum2 branch 2 times, most recently from 838da8f to bb4a813 Compare November 18, 2018 21:29
@andrey-utkin
Copy link
Contributor

Cool, finally it worked on my server!
I have sent Conrad a small patch to his init script.
Other than that, I am ready to merge this and #9099 .

@ConiKost
Copy link
Contributor Author

Patch merged, but slightly changed ;-)

@ConiKost ConiKost force-pushed the spectrum2 branch 2 times, most recently from d99a80b to 59effed Compare November 22, 2018 21:22
@ConiKost
net-im/spectrum2: New package
9428147 
Spectrum2 is an open source instant messaging jabber transport daemon.

Closes: https://bugs.gentoo.org/291437
Package-Manager: Portage-2.3.51, Repoman-2.3.12
RepoMan-Options: --force
Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-11-22 22:40 UTC
Newest commit scanned: 9428147
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/b84afc3/output.html#net-im/spectrum2

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/b84afc3/output.html#dev-python/django_polymorphic
https://qa-reports.gentoo.org/output/gentoo-ci/b84afc3/output.html#net-misc/dmr_utils
https://qa-reports.gentoo.org/output/gentoo-ci/b84afc3/output.html#net-misc/hblink

@andrey-utkin
Copy link
Contributor

Merged as 051f912 .
I took the liberty to rewrite the comment to checkpath usage in init.d script yet again.
Also I added myself as comaintainer in 15dad3a .

Thanks for your hard work @ConiKost !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dessa Dessa Dessa left review comments

@hydrapolic hydrapolic hydrapolic left review comments

@tonyvroon tonyvroon tonyvroon requested changes

Assignees

@andrey-utkin andrey-utkin

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
7 participants
@ConiKost @gentoo-bot @andrey-utkin @gentoo-repo-qa-bot @Dessa @tonyvroon @hydrapolic